http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11001 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |jonathan.druart@biblibre.co |ity.org |m Summary|The aqorders.branchcode |The aqorders.branchcode |field is missing into the |field is missing in the DB |DB | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11001 --- Comment #1 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 21843 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21843&action=edit Bug 11001: aqorders.branchcode is missing Some BibLibre developments have been taken into account a aqorders.branchcode field but not one adds it (cf bug 5335, 5339, etc.). This patch adds this new field in the DB and the ability to fill it from the new order empty form. Test plan: - execute the DB entry. - add a new order to a basket. - the select "library" value should be the library of the connected librarian. - save. - close the basket. - edit/show the order and verify the library value is the same as selected before. - receive the order. - search invoices by library and verify results are consistent. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11001 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Jonathan, I am a bit worried about the consequences of this. I think we can not assume safely that a library only orders items for itself, but there are also use cases where items for other branches will be ordered. How will this appear in the interface? As ordering branch? Or do we assume that the order will go to this library as well? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11001 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11001 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Sorry, just trying to think how this will work :) We have the option to set a different billing and delivery place in basket groups, so this would overwrite the aqorders branch then? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11001 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, I didn't want to discourage you :(. Just wanted to say that we have a lot of possibilities here where the branch can be a bit confusing and it should be clear what it does and what it does not. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11001 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathieu.saby@univ-rennes2.f | |r --- Comment #10 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- Hi Rather than a unique field for searching invoice for library, why not 2 fields, one for billing library and one for delivery library, which will use either aqorders.deliveryplace and aqorders.billingplace (if the basket is NOT in a basketgroup), or aqbasketgroups.deliveryplace and aqbasketgroups.billingplace (if it is in a basketgroup) ? M. Saby -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11001 --- Comment #12 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- (In reply to Jonathan Druart from comment #11)

(In reply to mathieu saby from comment #10)

...

Hi

Rather than a unique field for searching invoice for library, why not 2 fields, one for billing library and one for delivery library, which will use either aqorders.deliveryplace and aqorders.billingplace (if the basket is NOT in a basketgroup), or aqbasketgroups.deliveryplace and aqbasketgroups.billingplace (if it is in a basketgroup) ?

The main problem is an invoice can contain any orders from a vendor (so from any basket, basketgroup link to this vendor). The billing and delivery places can differ.

Oh, I did not think of that, because that's not our workflow... (By the way, I am not sure that current "flexibility" is really needed, because in real word (for my library at least), I think invoices sent by a vendor always contains orders from a single basketgroup. But maybe it is usefull for other libraries.) Mathieu -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11001 --- Comment #14 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- (In reply to Katrin Fischer from comment #13)

I think multiple basket groups is a possiblity, but I think they should all go to the shipping address, so that branch woudl be the same... unless someone makes a mistake.

Would it be an option to say the branch searched here is the branch where the invoice has been processed? (logged in branch of the staff member doing it?)

Maybe create a new field in aqinvoice, which will be filled at receipt either with (basket or basketgroup) delivery address or the library of the staff member, depending on a syspref? No sure it is needed to search on billing adress. Mathieu -- You are receiving this mail because: You are watching all bug changes.