[Bug 38515] New: Generate next serial deletes the notes from the expected serial and ignores preference PreserveSerialNotes in the new serial
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38515 Bug ID: 38515 Summary: Generate next serial deletes the notes from the expected serial and ignores preference PreserveSerialNotes in the new serial Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Serials Assignee: koha-bugs@lists.koha-community.org Reporter: adolfo.rodriguez@xercode.es QA Contact: testopia@bugs.koha-community.org If a serial with the status Expected has notes and you click the "Generate next" button, the serial status will change to Late and the notes will be gone. If the system preference PreserveSerialNotes is activated, it won't have any effect, as the new serial won't keep the notes from the previous serial. This is cause by the call to the function ModSerialStatus at serials-collection.pl inside operation cud-gennext, that passes "" where the notes should go. This means that field will be deleted in the current serial with status 1 (Expected) and won't be copied to the new serial. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38515 --- Comment #1 from Adolfo Rodríguez Taboada <adolfo.rodriguez@xercode.es> --- Created attachment 174917 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174917&action=edit Bug 38515: Keep serial notes when generating next serial. This patch prevents the loss of notes in serials when generating next serial Test plan: 1 Create a subscription, fill the notes field for the serial with Expected status and activate the system preference PreserveSerialNotes 2 Click Generate next 3 Check that the notes from the now Late serial are gone and that the new serial doesn't have notes. 4 Apply patch, restart services 5 Edit the serial with Expected status to fill the notes field. 6 Click Generate next 7 Check that the notes from the now Late serial are kepts and that they have been copied to the new serial. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38515 Adolfo Rodríguez Taboada <adolfo.rodriguez@xercode.es> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38515 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38515 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174917|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 175479 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175479&action=edit Bug 38515: Keep serial notes when generating next serial. This patch prevents the loss of notes in serials when generating next serial Test plan: 1 Create a subscription, fill the notes field for the serial with Expected status and activate the system preference PreserveSerialNotes 2 Click Generate next 3 Check that the notes from the now Late serial are gone and that the new serial doesn't have notes. 4 Apply patch, restart services 5 Edit the serial with Expected status to fill the notes field. 6 Click Generate next 7 Check that the notes from the now Late serial are kepts and that they have been copied to the new serial. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38515 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Text to go in the| |This fixes the generation release notes| |of the next serial and | |keeping the issue notes, | |when PreserveSerialNotes is | |set to "Do". If a serial | |with the status "Expected" | |had notes and the next | |issue was generated (the | |"Generate next" button), | |the serial status changed | |to "Late" and the notes | |were not copied over - as | |expected. However, if | |PreserveSerialNotes was set | |to "Do", it wasn't keeping | |the note for the next | |issue. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38515 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |adolfo.rodriguez@xercode.es |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38515 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38515 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175479|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 177378 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177378&action=edit Bug 38515: Keep serial notes when generating next serial. This patch prevents the loss of notes in serials when generating next serial Test plan: 1 Create a subscription, fill the notes field for the serial with Expected status and activate the system preference PreserveSerialNotes 2 Click Generate next 3 Check that the notes from the now Late serial are gone and that the new serial doesn't have notes. 4 Apply patch, restart services 5 Edit the serial with Expected status to fill the notes field. 6 Click Generate next 7 Check that the notes from the now Late serial are kepts and that they have been copied to the new serial. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38515 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38515 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38515 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38515 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |baptiste.wojtkowski@biblibr | |e.com Version(s)|25.05.00 |25.05.00,24.11.08 released in| | Status|Pushed to main |Pushed to stable --- Comment #5 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Pushed into 24.11.x for 24.11.08 nice work everyone -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38515 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting --- Comment #6 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x as it wasn't backported to 24.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38515 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #7 from David Nind <david@davidnind.com> --- Bug fix, no updates to the manual required. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org