[Bug 17696] New: Two missing periods in opac-suggestions.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17696 Bug ID: 17696 Summary: Two missing periods in opac-suggestions.tt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: ephetteplace@cca.edu QA Contact: testopia@bugs.koha-community.org Around line 38 of the template file a sentence is missing a period: <p>Please fill out this form to make a purchase suggestion. You will receive an email when the library processes your suggestion</p> In an attempt to make this patch more worthwhile, I went looking for other typos in the template and found another missing period around line 259 in the conditional text that appears if the user has more pending suggestions than the MaxOpenSuggestions setting allows: <p class="TooManySuggestionsText">You have reached your limit of suggestions you can place at this time.</br>Once the library has processed those suggestions you will be able to place more</p> Testing plan: - configure MaxOpenSuggestions with a low limit (e.g. 1) - visit opac-suggestions.pl?op=add, login if necessary - note that the period is missing from the second sentence of the leading paragraph under the "Enter a new purchase suggestion" heading - continue to submit suggestions until you've reached the MaxOpenSuggestions limit - observe the missing period in the "TooManySuggestionsText" paragraph - apply patch - revisit opac-suggestions.pl?op=add - note that the period is now present in the second sentence of the leading paragraph under the "Enter a new purchase suggestion" heading - note that the period is also present at the end of the "TooManySuggestionsText" paragraph Patch coming shortly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17696 Eric Phetteplace <ephetteplace@cca.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ephetteplace@cca.edu Assignee|oleonard@myacpl.org |ephetteplace@cca.edu --- Comment #1 from Eric Phetteplace <ephetteplace@cca.edu> --- Created attachment 57809 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57809&action=edit patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17696 Eric Phetteplace <ephetteplace@cca.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17696 --- Comment #2 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 57812 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57812&action=edit Bug 17696: missing periods in opac-suggestions.tt Problem: - two missing trailing periods in template Test plan: - configure MaxOpenSuggestions with a low limit (e.g. 1) - visit opac-suggestions.pl?op=add, login if necessary - note that the period is missing from the second sentence of the leading paragraph under the "Enter a new purchase suggestion" heading - continue to submit suggestions until you've reached the MaxOpenSuggestions limit - observe the missing period in the "TooManySuggestionsText" paragraph - apply patch - revisit opac-suggestions.pl?op=add - note that the period is now present in the second sentence of the leading paragraph under the "Enter a new purchase suggestion" heading - note that the period is also present at the end of the "TooManySuggestionsText" paragraph -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17696 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17696 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57812|0 |1 is obsolete| | --- Comment #3 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 57814 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57814&action=edit Attachment to Bug 17696 - Two missing periods in opac-suggestions.tt Bug 17696: missing periods in opac-suggestions.tt Problem: - two missing trailing periods in template Test plan: - configure MaxOpenSuggestions with a low limit (e.g. 1) - visit opac-suggestions.pl?op=add, login if necessary - note that the period is missing from the second sentence of the leading paragraph under the "Enter a new purchase suggestion" heading - continue to submit suggestions until you've reached the MaxOpenSuggestions limit - observe the missing period in the "TooManySuggestionsText" paragraph - apply patch - revisit opac-suggestions.pl?op=add - note that the period is now present in the second sentence of the leading paragraph under the "Enter a new purchase suggestion" heading - note that the period is also present at the end of the "TooManySuggestionsText" paragraph Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> HEAD detached from origin/master Changes to be committed: modified: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17696 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alexbuckley@catalyst.net.nz Attachment #57809|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17696 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17696 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57814|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 57831 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57831&action=edit Bug 17696: Add 2 missing periods in opac-suggestions.tt Problem: - two missing trailing periods in template Test plan: - configure MaxOpenSuggestions with a low limit (e.g. 1) - visit opac-suggestions.pl?op=add, login if necessary - note that the period is missing from the second sentence of the leading paragraph under the "Enter a new purchase suggestion" heading - continue to submit suggestions until you've reached the MaxOpenSuggestions limit - observe the missing period in the "TooManySuggestionsText" paragraph - apply patch - revisit opac-suggestions.pl?op=add - note that the period is now present in the second sentence of the leading paragraph under the "Enter a new purchase suggestion" heading - note that the period is also present at the end of the "TooManySuggestionsText" paragraph Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17696 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle@bywatersolutions.com --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 16.11, thanks Eric! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17696 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Kyle M Hall from comment #5)
Pushed to master for 16.11, thanks Eric!
16.11 or 17.05 ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17696 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Status|Pushed to Master |Pushed to Stable --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This patch has been pushed to 16.11.x, will be in 16.11.01. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org