[Bug 9215] New: non translatable string in manage-marc-import
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9215 Bug ID: 9215 Summary: non translatable string in manage-marc-import Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: paul.poulain@biblibre.com Created attachment 13892 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13892&action=edit untranslatable string There is a non translatable string in manage-marc-import (see screenshot) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9215 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9215 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 14342 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14342&action=edit Bug 9215 - non translatable string in manage-marc-import Status information about staged MARC record batches was being pulled directly from the import_batches table where they are stored as English strings. This patch puts a check on the status value into the template so that translatable strings can be embedded. To test, apply the patch and view both the table of staged MARC record batches and details about individual batches. In the default 'en' translation you should see import statuses displayed with a capital letter ("Staged"). This indicates that the status is now being pulled from the template. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9215 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9215 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9215 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14342|0 |1 is obsolete| | --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 14380 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14380&action=edit Bug 9215 - non translatable string in manage-marc-import Status information about staged MARC record batches was being pulled directly from the import_batches table where they are stored as English strings. This patch puts a check on the status value into the template so that translatable strings can be embedded. To test, apply the patch and view both the table of staged MARC record batches and details about individual batches. In the default 'en' translation you should see import statuses displayed with a capital letter ("Staged"). This indicates that the status is now being pulled from the template. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9215 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart@biblibre.co | |m --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA Comment: Works as expected: the strings are now translatable (msgid "" "%s Cleaned %s Imported %s Importing %s Reverted %s Reverting %s Staged %s %s " "%s ") Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9215 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9215 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14380|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 14566 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14566&action=edit Bug 9215 - non translatable string in manage-marc-import Status information about staged MARC record batches was being pulled directly from the import_batches table where they are stored as English strings. This patch puts a check on the status value into the template so that translatable strings can be embedded. To test, apply the patch and view both the table of staged MARC record batches and details about individual batches. In the default 'en' translation you should see import statuses displayed with a capital letter ("Staged"). This indicates that the status is now being pulled from the template. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9215 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9215 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #6 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.10.x will be in 3.10.2 Does not apply to 3.8.x please create a 3.8.x patch if you want this to be in 3.8.x also -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9215 Adrien SAURAT <adrien.saurat@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10170 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org