[Bug 6551] New: applying lending rules by item-level itypes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6551 Bug #: 6551 Summary: applying lending rules by item-level itypes Classification: Unclassified Change sponsored?: --- Product: Koha Version: rel_3_2 Platform: All OS/Version: All Status: NEW Severity: normal Priority: P5 Component: Hold requests AssignedTo: ian.walls@bywatersolutions.com ReportedBy: prosentientsystems@gmail.com QAContact: koha-bugs@lists.koha-community.org CC: gmcharlt@gmail.com The circulation rules were not being applied at the item level, but at the biblio level when attempting to place holds on an item. We noticed the problem when the 942$c indicated an itype that did not allow holds, but that rule was still being applied when some of the items' 952$y should have made them regularly available. This doesn't seem to have been fixed in 3.4, as far as we could see on the git. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6551 Justin @ Prosentient <prosentientsystems@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|ian.walls@bywatersolutions. |prosentientsystems@gmail.co |com |m --- Comment #1 from Justin @ Prosentient <prosentientsystems@gmail.com> 2011-07-04 01:17:32 UTC --- Created attachment 4554 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4554 logic change using items.itype instead of biblio We don't have git set up just yet. As soon as we do we'll submit it through there. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6551 --- Comment #2 from Justin @ Prosentient <prosentientsystems@gmail.com> 2011-07-05 04:22:44 UTC --- Created attachment 4557 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4557 Updated patch from git This replaces the previous patch we uploaded (since it's from the git and actually mentions the file we modified. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6551 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent CC| |chris@bigballofwax.co.nz Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6551 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Failed QA --- Comment #3 from Chris Cormack <chris@bigballofwax.co.nz> 2011-07-05 04:37:26 UTC --- Hi Justin Pretty close, but unfortunately this line here $select .= " LEFT JOIN itemtypes ON biblioitems.itype = Won't work, its biblioitems.itemtype Can you please fix and resend Thank you Chris -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6551 dev_patches@biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dev_patches@biblibre.com --- Comment #4 from dev_patches@biblibre.com 2011-07-22 10:36:39 UTC --- Your patch is Bad. See http://wiki.koha-community.org/wiki/Coding_Guidelines Commiting Code -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6551 --- Comment #5 from Chris Cormack <chris@bigballofwax.co.nz> 2011-07-22 21:43:27 UTC --- Hi Justin I think what Biblibre were trying to say, is your patch needs a better commit message, plus the little issue I spotted fixed up. As this is you first patch, we are happy to help you sort through any issues, either catch us on irc, or update the bug if you have something you don't understand or need help with. We always want new committers, so are happy to help you get your patch into tip top shape. Chris -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6551 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED CC| |jcamins@cpbibliography.com Resolution| |DUPLICATE --- Comment #6 from Jared Camins-Esakov <jcamins@cpbibliography.com> 2012-02-10 15:03:41 UTC --- I believe that this issue has been addressed by bug 4530. If I have misunderstood, my apologies, and please reopen the bug report! *** This bug has been marked as a duplicate of bug 4530 *** -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org