[Bug 16815] New: API routes to list, create, update, delete holds need permissions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16815 Bug ID: 16815 Summary: API routes to list, create, update, delete holds need permissions Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com The REST api for holds CRUD should require hold permissions! I think it needs reserveforothers and it's subpermissions implemented. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16815 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13903 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13903 [Bug 13903] Add API routes to list, create, update, delete holds -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16815 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |julian.maurice@biblibre.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16815 Lari Taskula <larit@student.uef.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |larit@student.uef.fi -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16815 Lari Taskula <larit@student.uef.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=14868 --- Comment #1 from Lari Taskula <larit@student.uef.fi> --- This issue is fixed in Bug 14868, however it does not directly duplicate this bug since Bug 14868 (Swagger2-driven permission checking) is last of three changes that modify the Swagger-specification aiming towards more split specification including the introduction of permissions in Path-object. Here are short descriptions for the three Bugs: 1. Bug 16212 adds a "minifier"-script to Swagger that fixes problems the current way of splitting swagger.json in master has caused; the problem is that splitting the "definitions" to $ref: definitions/index.json is not allowed (same with Paths-object) in Swagger. If we use a script to resolve the references in swagger.json, it becomes valid. You can see this problem if you try to validate our master Swagger specification with online.swagger.io validator. 2. Bug 16699 (depends on 16212) splits swagger.json further than what has already been done, and uses the minifier to make this type of split allowed. 3. Bug 14868 fixes the issue reported in this bug, but is dependant on Bug 16699. It would be cool if someone took a look at them. I'm adding it as See Also. :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16815 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Version|master |16.05 CC| |tomascohen@gmail.com --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- I mark it for 16.05 as the REST api has been enabled in that branch's latest release. And the proper solution for master what Lari mentions: bug 14868. I'll start working on it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16815 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |DUPLICATE --- Comment #3 from Tomás Cohen Arazi <tomascohen@gmail.com> --- *** This bug has been marked as a duplicate of bug 14868 *** -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org