[Bug 40318] New: "Receive shipments" should not open in a new tab/window - vendor list view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40318 Bug ID: 40318 Summary: "Receive shipments" should not open in a new tab/window - vendor list view Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.druart@gmail.com QA Contact: testopia@bugs.koha-community.org Same as bug 40067 but for the vendor list view. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40318 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |40067 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40067 [Bug 40067] "Receive shipments" should not open in a new tab/window -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40318 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40318 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 183840 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183840&action=edit Bug 40318: Add tests -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40318 --- Comment #2 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 183841 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183841&action=edit Bug 40318: (bug 40067 follow-up) Prevent receive shipments opening in a new tab - vendor list view 1. Acquisitions > Search vendors > Search 2. In the actions column, click "Receive shipments" => Without this patch the receive shipment from vendor [name] page opens in a new tab/window => With this patch applied it does not -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40318 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart@gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40318 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40318 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183840|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 183847 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183847&action=edit Bug 40318: Add tests Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40318 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183841|0 |1 is obsolete| | --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 183848 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183848&action=edit Bug 40318: (bug 40067 follow-up) Prevent receive shipments opening in a new tab - vendor list view 1. Acquisitions > Search vendors > Search 2. In the actions column, click "Receive shipments" => Without this patch the receive shipment from vendor [name] page opens in a new tab/window => With this patch applied it does not Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40318 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Text to go in the| |This fixes the "Receive release notes| |shipments" action from the | |table listing vendors in | |acquisitions - it now opens | |the receive shipment form | |in the same window, instead | |of opening in a new tab or | |window. --- Comment #5 from David Nind <david@davidnind.com> --- Thanks Jonathan for fixing! Testing notes: 1. After applying the patch, run: yarn build 2. The tests pass: yarn cypress run --spec t/cypress/integration/Acquisitions/Vendors_spec.ts -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40318 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Seeing [FAIL] t/cypress/integration/Acquisitions/Vendors_spec.ts FAIL forbidden_patterns forbidden pattern: .only detected (line 236) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40318 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183847|0 |1 is obsolete| | Attachment #183848|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 183916 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183916&action=edit Bug 40318: Add tests Signed-off-by: David Nind <david@davidnind.com> Amended-by: Jonathan Druart Remove '.only' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40318 --- Comment #8 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 183917 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183917&action=edit Bug 40318: (bug 40067 follow-up) Prevent receive shipments opening in a new tab - vendor list view 1. Acquisitions > Search vendors > Search 2. In the actions column, click "Receive shipments" => Without this patch the receive shipment from vendor [name] page opens in a new tab/window => With this patch applied it does not Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40318 --- Comment #9 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Marcel de Rooy from comment #6)
Seeing [FAIL] t/cypress/integration/Acquisitions/Vendors_spec.ts FAIL forbidden_patterns forbidden pattern: .only detected (line 236)
Fixed, sorry about that. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40318 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |ASSIGNED --- Comment #10 from Jonathan Druart <jonathan.druart@gmail.com> --- The test is not correct, we don't have the vendor in DB on Jenkins (currently we have Toolbar_spec.ts failing) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40318 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |40430 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40430 [Bug 40430] Toolbar_spec.ts is failing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40318 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183916|0 |1 is obsolete| | --- Comment #11 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 184199 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184199&action=edit Bug 40318: Add tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40318 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #12 from Jonathan Druart <jonathan.druart@gmail.com> --- The tests have been rewritten on top of bug 40430. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40318 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40318 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183917|0 |1 is obsolete| | --- Comment #13 from David Nind <david@davidnind.com> --- Created attachment 184305 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184305&action=edit Bug 40318: (bug 40067 follow-up) Prevent receive shipments opening in a new tab - vendor list view 1. Acquisitions > Search vendors > Search 2. In the actions column, click "Receive shipments" => Without this patch the receive shipment from vendor [name] page opens in a new tab/window => With this patch applied it does not Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40318 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184199|0 |1 is obsolete| | --- Comment #14 from David Nind <david@davidnind.com> --- Created attachment 184306 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184306&action=edit Bug 40318: Add tests Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40318 --- Comment #15 from David Nind <david@davidnind.com> --- Testing notes (using KTD): 1. Enable the RESTBasicAuth system preference. 2. Apply the patches and dependencies: yes | git bz apply 40318 3. Update the API/JavaScript: yarn build 4. Restart everything: restart_all 5. Run the tests - these should pass: yarn cypress run --spec t/cypress/integration/Acquisitions/Vendors_spec.ts -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40318 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |40447 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40447 [Bug 40447] Add documentation for cypress plugins -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40318 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40318 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184305|0 |1 is obsolete| | Attachment #184306|0 |1 is obsolete| | --- Comment #16 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 184351 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184351&action=edit Bug 40318: (bug 40067 follow-up) Prevent receive shipments opening in a new tab - vendor list view 1. Acquisitions > Search vendors > Search 2. In the actions column, click "Receive shipments" => Without this patch the receive shipment from vendor [name] page opens in a new tab/window => With this patch applied it does not Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40318 --- Comment #17 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 184352 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184352&action=edit Bug 40318: Add tests Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40318 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@openfifth.c | |o.uk QA Contact|testopia@bugs.koha-communit |martin.renvoize@openfifth.c |y.org |o.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40318 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40318 --- Comment #18 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40318 Bug 40318 depends on bug 40067, which changed state. Bug 40067 Summary: "Receive shipments" should not open in a new tab/window https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40067 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40318 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.11.00 |25.11.00,25.05.03 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40318 --- Comment #19 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 25.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40318 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to stable |Needs documenting --- Comment #20 from Fridolin Somers <fridolin.somers@biblibre.com> --- Depends on Bug 40067 not in 24.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40318 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #21 from David Nind <david@davidnind.com> --- Bug fix, no changes required to the manual. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40318 Bug 40318 depends on bug 40430, which changed state. Bug 40430 Summary: Toolbar_spec.ts is failing https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40430 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org