[Bug 35189] New: Itemtypes SVG icons should be limited in height/width
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35189 Bug ID: 35189 Summary: Itemtypes SVG icons should be limited in height/width Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: pablo.bianchi@gmail.com QA Contact: testopia@bugs.koha-community.org Created attachment 158067 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158067&action=edit Screenshot Steps to reproduce the issue: 1. On Staff interface, on Administration > Item types, modify any item 2. Choose an SVG image as a remote image for an Item type, for eg https://raw.githubusercontent.com/FortAwesome/Font-Awesome/afecf2af5d897b763... Save changes. When listed on itemtypes.pl the icon is not too big, but if you edit again the itemtype (using above SVG, more than 1200px width). This also impact at some degree on Advanced search (staff and OPAC, search.pl, opac-search.pl). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35189 Pablo AB <pablo.bianchi@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P4 Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35189 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- I disagree that this is something Koha should handle. The remote images option assumes you're specifying an image which is sized correctly. Just because SVG images are scalable doesn't mean the image can't be created with a sane set of display dimensions. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35189 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- Koha can handle this via the UserCSS preferences. I'd rather let the user define height/width there. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35189 --- Comment #3 from Pablo AB <pablo.bianchi@gmail.com> --- Please check these screenshots https://imgur.com/a/P7iCx45 Sure, everything could be tune with OPACUserCSS/OPACUserJS/IntranetUserCSS/IntranetUserJS. But, do we want _that_ to be the default behavior when using SVGs? Moreover, Font Awesome have a huge catalog, referring directly to its SVG is very convenient. Moreover2, all the places where this issue impact doesn't have a class to easily add a max-width, forcing to use more intricate strategies. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35189 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=37515 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Pablo AB from comment #3)
Moreover2, all the places where this issue impact doesn't have a class to easily add a max-width, forcing to use more intricate strategies.
I have submitted a patch for this issue in Bug 37515 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org