https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35883 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35883 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |david@davidnind.com --- Comment #2 from David Nind <david@davidnind.com> --- The patch no longer applies 8-(... ... Applying: Bug 35883: Use template wrapper for accordions: Table settings administration Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/en/modules/admin/columns_settings.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/columns_settings.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/admin/columns_settings.tt error: Failed to merge in the changes. Patch failed at 0001 Bug 35883: Use template wrapper for accordions: Table settings administration ... -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35883 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161331|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 161763 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161763&action=edit Bug 35883: Use template wrapper for accordions: Table settings administration This patch updates the table settings administration page so that Bootstrap accordion markup is generated by WRAPPERs. This patch also makes some changes to fix the automatic scroll when a table configuration button was clicked. To test, apply the patch and go to Administration -> Table settings. - The list of modules should be displayed as before: Collapsible panels where clicking the module name heading expands the corresponding panel of settings. - Test that direct links to configurable tables still work correctly: - Go to Administration -> Libraries. - Click the "Configure" button at the top of the table of libraries. - You should be taken to the table settings page. - The "Administration" panel should be expanded by default. - You should be scrolled down automatically to the "Libraries" table. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35883 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161763|0 |1 is obsolete| | --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 161765 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161765&action=edit Bug 35883: Use template wrapper for accordions: Table settings administration This patch updates the table settings administration page so that Bootstrap accordion markup is generated by WRAPPERs. This patch also makes some changes to fix the automatic scroll when a table configuration button was clicked. To test, apply the patch and go to Administration -> Table settings. - The list of modules should be displayed as before: Collapsible panels where clicking the module name heading expands the corresponding panel of settings. - Test that direct links to configurable tables still work correctly: - Go to Administration -> Libraries. - Click the "Configure" button at the top of the table of libraries. - You should be taken to the table settings page. - The "Administration" panel should be expanded by default. - You should be scrolled down automatically to the "Libraries" table. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35883 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161765|0 |1 is obsolete| | --- Comment #5 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 163889 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163889&action=edit Bug 35883: Use template wrapper for accordions: Table settings administration This patch updates the table settings administration page so that Bootstrap accordion markup is generated by WRAPPERs. This patch also makes some changes to fix the automatic scroll when a table configuration button was clicked. To test, apply the patch and go to Administration -> Table settings. - The list of modules should be displayed as before: Collapsible panels where clicking the module name heading expands the corresponding panel of settings. - Test that direct links to configurable tables still work correctly: - Go to Administration -> Libraries. - Click the "Configure" button at the top of the table of libraries. - You should be taken to the table settings page. - The "Administration" panel should be expanded by default. - You should be scrolled down automatically to the "Libraries" table. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35883 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |24.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35883 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |enhancement -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35883 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |36876 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36876 [Bug 36876] In table settings words are split in two and some of them cannot be translated properly -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35883 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com Status|Needs documenting |RESOLVED Resolution|--- |FIXED --- Comment #8 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Code structure change, nothing to add/edit in the manual. -- You are receiving this mail because: You are watching all bug changes.