[Bug 30474] New: Convert tools pages tabs to Bootstrap (part 1)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30474 Bug ID: 30474 Summary: Convert tools pages tabs to Bootstrap (part 1) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org Blocks: 29226 Continuing the process of phasing out jQueryUI, this patch will replace jQueryUI tabs in a few tools templates with Bootstrap: - additional-contents.tt - batch_delete_records.tt - batch_record_modification.tt Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29226 [Bug 29226] OMNIBUS: Replace the use of jQueryUI tabs -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30474 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30474 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 133046 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133046&action=edit Bug 30474: Convert tools pages tabs to Bootstrap (part 1) This patch converts jQueryUI tabs on three tools templates to Bootstrap tabs. To test, apply the patch and go to Tools -> HTML customizations. - Click "New entry." - On the entry form you should see two tabs, "Default" and "English (en)" - The tabs should look correct and work correctly. Go to Tools -> Batch record deletion. - Test the three tabs: "Upload a file", "Select a list of records", and "Enter a list of record numbers." Go to Tools -> Batch record modification. - Test the same three tabs on this page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30474 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- On additional-contents.tt this patch seems to have a unintended effect of moving the CodeMirror-linenumber. When you use HTML customizations or New and use the CodeMirror editor (Edit with text editor) the line numbers are awkwardly placed now. This happens to me in both Chrome and FF with the patch applied. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30474 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30474 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30474 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30474 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133046|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 133236 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133236&action=edit Bug 30474: Convert tools pages tabs to Bootstrap (part 1) This patch converts jQueryUI tabs on three tools templates to Bootstrap tabs. To test, apply the patch and go to Tools -> HTML customizations. - Click "New entry." - On the entry form you should see two tabs, "Default" and "English (en)" - The tabs should look correct and work correctly. Go to Tools -> Batch record deletion. - Test the three tabs: "Upload a file", "Select a list of records", and "Enter a list of record numbers." Go to Tools -> Batch record modification. - Test the same three tabs on this page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30474 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 133237 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133237&action=edit Bug 30474: (follow-up) Tie editor initialization to tab activation The way Bootstrap tabs manipulate the DOM, CodeMirror has problems initializing correctly, I think because of redraws and CodeMirror's attemps to position things absolutely. The solution seems to be to wait until after a Bootstrap tab has activated before initializing the CodeMirror instance. This patch implements that, along with a check to prevent double-initializing the same textarea. I've also made a similar change to the way TinyMCE is initialized, which I hope will help with the issue of the editor not always loading correctly. To test, apply the patch and go to Tools -> HTML customizations. - Test creation and editing of HTML customization entries using both the default editor and the text editor (Edit -> Edit with text editor). - Verify that the editor (CodeMirror or TinyMCE) loads correctly and looks correct, both upon page load and upon switching tabs between "Default" and other language tabs - Verify that your edits are saved correctly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30474 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30474 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133236|0 |1 is obsolete| | --- Comment #5 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 133271 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133271&action=edit Bug 30474: Convert tools pages tabs to Bootstrap (part 1) This patch converts jQueryUI tabs on three tools templates to Bootstrap tabs. To test, apply the patch and go to Tools -> HTML customizations. - Click "New entry." - On the entry form you should see two tabs, "Default" and "English (en)" - The tabs should look correct and work correctly. Go to Tools -> Batch record deletion. - Test the three tabs: "Upload a file", "Select a list of records", and "Enter a list of record numbers." Go to Tools -> Batch record modification. - Test the same three tabs on this page. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30474 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133237|0 |1 is obsolete| | --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 133272 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133272&action=edit Bug 30474: (follow-up) Tie editor initialization to tab activation The way Bootstrap tabs manipulate the DOM, CodeMirror has problems initializing correctly, I think because of redraws and CodeMirror's attemps to position things absolutely. The solution seems to be to wait until after a Bootstrap tab has activated before initializing the CodeMirror instance. This patch implements that, along with a check to prevent double-initializing the same textarea. I've also made a similar change to the way TinyMCE is initialized, which I hope will help with the issue of the editor not always loading correctly. To test, apply the patch and go to Tools -> HTML customizations. - Test creation and editing of HTML customization entries using both the default editor and the text editor (Edit -> Edit with text editor). - Verify that the editor (CodeMirror or TinyMCE) loads correctly and looks correct, both upon page load and upon switching tabs between "Default" and other language tabs - Verify that your edits are saved correctly. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30474 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133271|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 133485 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133485&action=edit Bug 30474: Convert tools pages tabs to Bootstrap (part 1) This patch converts jQueryUI tabs on three tools templates to Bootstrap tabs. To test, apply the patch and go to Tools -> HTML customizations. - Click "New entry." - On the entry form you should see two tabs, "Default" and "English (en)" - The tabs should look correct and work correctly. Go to Tools -> Batch record deletion. - Test the three tabs: "Upload a file", "Select a list of records", and "Enter a list of record numbers." Go to Tools -> Batch record modification. - Test the same three tabs on this page. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30474 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133272|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 133486 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133486&action=edit Bug 30474: (follow-up) Tie editor initialization to tab activation The way Bootstrap tabs manipulate the DOM, CodeMirror has problems initializing correctly, I think because of redraws and CodeMirror's attemps to position things absolutely. The solution seems to be to wait until after a Bootstrap tab has activated before initializing the CodeMirror instance. This patch implements that, along with a check to prevent double-initializing the same textarea. I've also made a similar change to the way TinyMCE is initialized, which I hope will help with the issue of the editor not always loading correctly. To test, apply the patch and go to Tools -> HTML customizations. - Test creation and editing of HTML customization entries using both the default editor and the text editor (Edit -> Edit with text editor). - Verify that the editor (CodeMirror or TinyMCE) loads correctly and looks correct, both upon page load and upon switching tabs between "Default" and other language tabs - Verify that your edits are saved correctly. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30474 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize@ptfs-europe | |.com --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Looking good.. again the top padding is fixed elsewhere already.. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30474 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply CC| |fridolin.somers@biblibre.co | |m --- Comment #10 from Fridolin Somers <fridolin.somers@biblibre.com> --- Sorry, needs a rebase -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30474 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30474 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133485|0 |1 is obsolete| | Attachment #133486|0 |1 is obsolete| | --- Comment #11 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 134532 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134532&action=edit Bug 30474: Convert tools pages tabs to Bootstrap (part 1) This patch converts jQueryUI tabs on three tools templates to Bootstrap tabs. To test, apply the patch and go to Tools -> HTML customizations. - Click "New entry." - On the entry form you should see two tabs, "Default" and "English (en)" - The tabs should look correct and work correctly. Go to Tools -> Batch record deletion. - Test the three tabs: "Upload a file", "Select a list of records", and "Enter a list of record numbers." Go to Tools -> Batch record modification. - Test the same three tabs on this page. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30474 --- Comment #12 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 134533 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134533&action=edit Bug 30474: (follow-up) Tie editor initialization to tab activation The way Bootstrap tabs manipulate the DOM, CodeMirror has problems initializing correctly, I think because of redraws and CodeMirror's attemps to position things absolutely. The solution seems to be to wait until after a Bootstrap tab has activated before initializing the CodeMirror instance. This patch implements that, along with a check to prevent double-initializing the same textarea. I've also made a similar change to the way TinyMCE is initialized, which I hope will help with the issue of the editor not always loading correctly. To test, apply the patch and go to Tools -> HTML customizations. - Test creation and editing of HTML customization entries using both the default editor and the text editor (Edit -> Edit with text editor). - Verify that the editor (CodeMirror or TinyMCE) loads correctly and looks correct, both upon page load and upon switching tabs between "Default" and other language tabs - Verify that your edits are saved correctly. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30474 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply --- Comment #13 from Fridolin Somers <fridolin.somers@biblibre.com> --- Ouch, There are merge conflicts inside patch on koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_record_modification.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30474 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133486|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30474 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133485|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30474 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134532|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30474 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134533|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30474 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30474 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133485|0 |1 is obsolete| | Attachment #133486|0 |1 is obsolete| | --- Comment #14 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 134609 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134609&action=edit Bug 30474: Convert tools pages tabs to Bootstrap (part 1) This patch converts jQueryUI tabs on three tools templates to Bootstrap tabs. To test, apply the patch and go to Tools -> HTML customizations. - Click "New entry." - On the entry form you should see two tabs, "Default" and "English (en)" - The tabs should look correct and work correctly. Go to Tools -> Batch record deletion. - Test the three tabs: "Upload a file", "Select a list of records", and "Enter a list of record numbers." Go to Tools -> Batch record modification. - Test the same three tabs on this page. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30474 --- Comment #15 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 134610 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134610&action=edit Bug 30474: (follow-up) Tie editor initialization to tab activation The way Bootstrap tabs manipulate the DOM, CodeMirror has problems initializing correctly, I think because of redraws and CodeMirror's attemps to position things absolutely. The solution seems to be to wait until after a Bootstrap tab has activated before initializing the CodeMirror instance. This patch implements that, along with a check to prevent double-initializing the same textarea. I've also made a similar change to the way TinyMCE is initialized, which I hope will help with the issue of the editor not always loading correctly. To test, apply the patch and go to Tools -> HTML customizations. - Test creation and editing of HTML customization entries using both the default editor and the text editor (Edit -> Edit with text editor). - Verify that the editor (CodeMirror or TinyMCE) loads correctly and looks correct, both upon page load and upon switching tabs between "Default" and other language tabs - Verify that your edits are saved correctly. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30474 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30474 --- Comment #16 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org