http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13028 --- Comment #1 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 32005 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32005&action=edit Bug 13028: Resolve uninitialized value in string eq at cmp_sysprefs.pl line 194 If you use the restore option with a partial pref file not containing a version, you will have this error. Also the count of updated prefs will be one too high. This is corrected by a better test of the hash value in the CheckVersionPref subroutine. Test plan: [1] Create a small pref file and remove the version pref (if present). You could for instance do a pref backup and remove most lines. [2] Use the restore option with and without this patch. So, something like: maintclone/misc/maintenance/cmp_sysprefs.pl -c r -f 9999crucial.pref [3] Check on the error message and the pref count. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13028 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Use of uninitialized value |Remove uninitialized value |in string eq at |warning and add partial |misc/maintenance/cmp_syspre |flag to cmp_sysprefs script |fs.pl line 194 | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13028 --- Comment #2 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 32062 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32062&action=edit Bug 13028: Followup adding a -partial flag for partial compares If you compare the database with a partial pref file, you may not be interested in lots of lines saying that a pref is not in the file. You were already aware of that ;) If you add the -partial flag, these lines will be skipped. Test plan: Do as described above. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13028 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32005|0 |1 is obsolete| | --- Comment #3 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 32641 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32641&action=edit Bug 13028: Resolve uninitialized value in string eq at cmp_sysprefs.pl line 194 If you use the restore option with a partial pref file not containing a version, you will have this error. Also the count of updated prefs will be one too high. This is corrected by a better test of the hash value in the CheckVersionPref subroutine. Test plan: [1] Create a small pref file and remove the version pref (if present). You could for instance do a pref backup and remove most lines. [2] Use the restore option with and without this patch. So, something like: maintclone/misc/maintenance/cmp_sysprefs.pl -c r -f 9999crucial.pref [3] Check on the error message and the pref count. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13028 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32062|0 |1 is obsolete| | --- Comment #4 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 32643 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32643&action=edit Bug 13028: Followup adding a -partial flag for partial compares If you compare the database with a partial pref file, you may not be interested in lots of lines saying that a pref is not in the file. You were already aware of that ;) If you add the -partial flag, these lines will be skipped. Test plan: Do as described above. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13028 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13028 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 32646 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32646&action=edit [PASSED QA] Bug 13028: Followup adding a -partial flag for partial compares If you compare the database with a partial pref file, you may not be interested in lots of lines saying that a pref is not in the file. You were already aware of that ;) If you add the -partial flag, these lines will be skipped. Test plan: Do as described above. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Works as described, passes tests and QA script. -- You are receiving this mail because: You are watching all bug changes.