[Bug 42928] New: In viewlog.tt #actionRETURN should be Retrun, not Check-in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42928 Bug ID: 42928 Summary: In viewlog.tt #actionRETURN should be Retrun, not Check-in Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Target Milestone: --- Bug 42131 updated the terminology in the table. We should also update the label for the #actionRETURN checkbox to be "Retrun". -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42928 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42928 Laura O'Neil <laura@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |laura@bywatersolutions.com Summary|In viewlog.tt #actionRETURN |In viewlog.tt #actionRETURN |should be Retrun, not |should be Return, not |Check-in |Check-in -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42928 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|In viewlog.tt #actionRETURN |In viewlog.tt #actionRETURN |should be Return, not |should be Check-in, not |Check-in |Return -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42928 --- Comment #1 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- We should also update the label for the #actionRETURN checkbox to be "Check in". -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42928 --- Comment #2 from SamSowanick <sam.sowanick@corvallisoregon.gov> --- Created attachment 201411 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201411&action=edit Bug 429428: Update Action terminology to match label in viewlog.inc To test: 1. Checkin item. 2. Run action log. 3. Note returns action "Return" 4. apply patch. 5. Run log. 6. Notes returns "Check-in", matching the label. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42928 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42928 SamSowanick <sam.sowanick@corvallisoregon.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |sam.sowanick@corvallisorego | |n.gov -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42928 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42928 --- Comment #3 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 201659 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201659&action=edit Bug 42928: Updated viewlog terminology in table to match label. From Return to Check-in. Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42928 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |me@paulderscheid.xyz |y.org | CC| |lisette@bywatersolutions.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42928 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com QA Contact|me@paulderscheid.xyz |david@davidnind.com Assignee|oleonard@myacpl.org |sam.sowanick@corvallisorego | |n.gov --- Comment #4 from David Nind <david@davidnind.com> --- Updated assignee and QA contact. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42928 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #201411|0 |1 is obsolete| | --- Comment #5 from David Nind <david@davidnind.com> --- Comment on attachment 201411 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201411 Bug 429428: Update Action terminology to match label in viewlog.inc Obsoleted older patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42928 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42928 --- Comment #6 from David Nind <david@davidnind.com> --- Created attachment 202270 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202270&action=edit Bug 42928: Update log viewer action terminology - Return to Check-in The log viewer results table uses "Return" for "Check-in" actions. See the terminology list: https://wiki.koha-community.org/wiki/Terminology#C Test plan: 1. Check out an item to a patron, then check it back in again. 2. Go to the log view (Tools > Additional tools > Log viewer). 3. Click "Submit". 4. Note that the action column for the results shows "Return". 5. Apply the patch. 6. Refresh the log viewer page. 6. Note that the action column now correctly shows "Check-in". Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42928 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #201659|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42928 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes the terminology release notes| |used in the log viewer tool | |results. "Check-in" (noun) | |is now used instead of | |"Return". Summary|In viewlog.tt #actionRETURN |Terminology: Log viewer |should be Check-in, not |results - show "Check-in" |Return |instead of "Return" in the | |action column See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=42131 --- Comment #7 from David Nind <david@davidnind.com> --- QA script happy, straight-forward string change consistent with the terminology guidelines. Have: 1. Updated the bug title. 2. Added a release note. 3. Edited the commit message so that it is more consistent with the commit message guidelines https://wiki.koha-community.org/wiki/Commit_messages Note: Related bug 42131 fixed the log viewer tool actions selection option, this fixes what is shown in the results table. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42928 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42928 --- Comment #8 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Thanks everyone! Pushed to main for 26.11! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42928 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|26.11.00 |26.11.00,26.05.03 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42928 --- Comment #9 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to 26.05.x for the upcoming 26.05.03 release. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org