http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13525 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13525 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 35004 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35004&action=edit Bug 13525 - Date sorting on accounts (fines) tab doesn't work correctly Date sorting of charges under Patron -> Fines -> Account is done based on formatted dates, so sorting is broken depending on your dateformat system preference. This patch implements the standard "title-string" date sorting method. To test, apply the patch and view the Account tab. Test sorting of charges under various settings of the dateformat system preference. Date sorting should work correctly in all cases. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13525 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 35137 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35137&action=edit wrongly sorted dates in accountlines Thx for testing! It's easier to see when you have a lot of different dates and change the dateformat system preference to "dd/mm/yyyy". -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13525 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35004|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 35358 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35358&action=edit [PASSED QA] Bug 13525 - Date sorting on accounts (fines) tab doesn't work correctly Date sorting of charges under Patron -> Fines -> Account is done based on formatted dates, so sorting is broken depending on your dateformat system preference. This patch implements the standard "title-string" date sorting method. To test, apply the patch and view the Account tab. Test sorting of charges under various settings of the dateformat system preference. Date sorting should work correctly in all cases. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described and fixes sorting problem. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13525 --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 35377 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35377&action=edit Bug 13525 - Date sorting on accounts (fines) tab doesn't work correctly Date sorting of charges under Patron -> Fines -> Account is done based on formatted dates, so sorting is broken depending on your dateformat system preference. This patch implements the standard "title-string" date sorting method. To test, apply the patch and view the Account tab. Test sorting of charges under various settings of the dateformat system preference. Date sorting should work correctly in all cases. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described and fixes sorting problem. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13525 --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- I must note I was not able to reproduce the issue, even with dd/mm/yyyy, I got: 15/07/2013 11/06/2014 20/08/2014 19/01/2015 I can confirm this patch introduces the correct way to sort dates with datatables and I did not find any regression. Marked as Passed QA -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13525 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #8 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.18.x will be in 3.18.4 -- You are receiving this mail because: You are watching all bug changes.