[Bug 34866] New: Use template wrapper for breadcrumbs: OPAC part 4
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34866 Bug ID: 34866 Summary: Use template wrapper for breadcrumbs: OPAC part 4 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org Depends on: 34849 To continue the process started by Bug 32507, this patch will update several templates in the OPAC so that they use the template wrapper for breadcrumbs. - opac-registration-confirmation.tt - opac-registration-email-sent.tt - opac-registration-invalid.tt - opac-request-article.tt - opac-reserve.tt - opac-results.tt - opac-serial-issues.tt - opac-shareshelf.tt - opac-showreviews.tt - opac-suggestions.tt - opac-tags_subject.tt - opac-topissues.tt - svc/suggestion.tt Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34849 [Bug 34849] Use template wrapper for breadcrumbs: OPAC part 1 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34866 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34866 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 156004 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156004&action=edit Bug 34866: Use template wrapper for breadcrumbs: OPAC part 4 This patch updates several OPAC templates so that they use a new WRAPPER for displaying breadcrumbs. Apply the patch and log in to the OPAC. Test each of the following pages and their variations. Breadcrumbs should look correct, and each link should be correct: - Recent comments - Most popular - Enable "PatronSelfRegistration" and set "PatronSelfRegistrationVerifyByEmail" to "Don't require." - In the OPAC, go to "Register here." Fill out the form and submit your registration. - Check the "Registration complete" page. - Set "PatronSelfRegistrationVerifyByEmail" to "Require" - Submit another registration and check the "Confirm your registration" page. - Visit the registration page passing an invalid token: /cgi-bin/koha/opac-registration-verify.pl?token=foo Check the "Registration invalid" page. - Enable the "ArticleRequests" system preference and log in to the OPAC. - Perform a search which will return results. - Check the search results page - View the detail page for one of the results. - Click "Request article." - Return to the detail page and click "Place hold." - Complete each step of the hold process. - Enable the "OpacAllowSharingPrivateLists" system preference. - Create a private list if necessary. - Click the "Share" link - Locate a serial record and view the detail page. - Click the "More details" link under the "Subscriptions" plan - Enable the system preference "suggestion." - From the logged-in user summary page click "Purchase suggestions" - Click the "New purchase suggestion" link - Enable the "AnonSuggestions" and "OPACViewOthersSuggestions" system preferences and log out of the OPAC. - View the purchase suggestions page. - Enable the "OpacCloud" system preference and go to the "Subject cloud" page. (the feature doesn't need to be configured to test). - Populate the "RestrictedPageTitle" and "RestrictedPageContent" system preferences and navigate directly to /cgi-bin/koha/opac-restrictedpage.pl - Remove the contents of "RestrictedPageTitle" and check the page again. - This patch also updates svc/suggestion.tt but I don't know how to test it! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34866 Bug 34866 depends on bug 34849, which changed state. Bug 34849 Summary: Use template wrapper for breadcrumbs: OPAC part 1 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34849 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34866 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Keywords| |Sandbox -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34866 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |david@davidnind.com --- Comment #2 from David Nind <david@davidnind.com> --- Patch no longer applies 8-(.. kohadev-koha@kohadevbox:koha(bz34866)$ git bz apply 34866 Bug 34866 - Use template wrapper for breadcrumbs: OPAC part 4 156004 - Bug 34866: Use template wrapper for breadcrumbs: OPAC part 4 Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 34866: Use template wrapper for breadcrumbs: OPAC part 4 Using index info to reconstruct a base tree... M koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt M koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt M koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt M koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-topissues.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-topissues.tt Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt CONFLICT (content): Merge conflict in koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt error: Failed to merge in the changes. Patch failed at 0001 Bug 34866: Use template wrapper for breadcrumbs: OPAC part 4 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34866 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34866 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156004|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 158239 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158239&action=edit Bug 34866: Use template wrapper for breadcrumbs: OPAC part 4 This patch updates several OPAC templates so that they use a new WRAPPER for displaying breadcrumbs. Apply the patch and log in to the OPAC. Test each of the following pages and their variations. Breadcrumbs should look correct, and each link should be correct: - Recent comments - Most popular - Enable "PatronSelfRegistration" and set "PatronSelfRegistrationVerifyByEmail" to "Don't require." - In the OPAC, go to "Register here." Fill out the form and submit your registration. - Check the "Registration complete" page. - Set "PatronSelfRegistrationVerifyByEmail" to "Require" - Submit another registration and check the "Confirm your registration" page. - Visit the registration page passing an invalid token: /cgi-bin/koha/opac-registration-verify.pl?token=foo Check the "Registration invalid" page. - Enable the "ArticleRequests" system preference and log in to the OPAC. - Perform a search which will return results. - Check the search results page - View the detail page for one of the results. - Click "Request article." - Return to the detail page and click "Place hold." - Complete each step of the hold process. - Enable the "OpacAllowSharingPrivateLists" system preference. - Create a private list if necessary. - Click the "Share" link - Locate a serial record and view the detail page. - Click the "More details" link under the "Subscriptions" plan - Enable the system preference "suggestion." - From the logged-in user summary page click "Purchase suggestions" - Click the "New purchase suggestion" link - Enable the "AnonSuggestions" and "OPACViewOthersSuggestions" system preferences and log out of the OPAC. - View the purchase suggestions page. - Enable the "OpacCloud" system preference and go to the "Subject cloud" page. (the feature doesn't need to be configured to test). - Populate the "RestrictedPageTitle" and "RestrictedPageContent" system preferences and navigate directly to /cgi-bin/koha/opac-restrictedpage.pl - Remove the contents of "RestrictedPageTitle" and check the page again. - This patch also updates svc/suggestion.tt but I don't know how to test it! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34866 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34866 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158239|0 |1 is obsolete| | --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 158265 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158265&action=edit Bug 34866: Use template wrapper for breadcrumbs: OPAC part 4 This patch updates several OPAC templates so that they use a new WRAPPER for displaying breadcrumbs. Apply the patch and log in to the OPAC. Test each of the following pages and their variations. Breadcrumbs should look correct, and each link should be correct: - Recent comments - Most popular - Enable "PatronSelfRegistration" and set "PatronSelfRegistrationVerifyByEmail" to "Don't require." - In the OPAC, go to "Register here." Fill out the form and submit your registration. - Check the "Registration complete" page. - Set "PatronSelfRegistrationVerifyByEmail" to "Require" - Submit another registration and check the "Confirm your registration" page. - Visit the registration page passing an invalid token: /cgi-bin/koha/opac-registration-verify.pl?token=foo Check the "Registration invalid" page. - Enable the "ArticleRequests" system preference and log in to the OPAC. - Perform a search which will return results. - Check the search results page - View the detail page for one of the results. - Click "Request article." - Return to the detail page and click "Place hold." - Complete each step of the hold process. - Enable the "OpacAllowSharingPrivateLists" system preference. - Create a private list if necessary. - Click the "Share" link - Locate a serial record and view the detail page. - Click the "More details" link under the "Subscriptions" plan - Enable the system preference "suggestion." - From the logged-in user summary page click "Purchase suggestions" - Click the "New purchase suggestion" link - Enable the "AnonSuggestions" and "OPACViewOthersSuggestions" system preferences and log out of the OPAC. - View the purchase suggestions page. - Enable the "OpacCloud" system preference and go to the "Subject cloud" page. (the feature doesn't need to be configured to test). - Populate the "RestrictedPageTitle" and "RestrictedPageContent" system preferences and navigate directly to /cgi-bin/koha/opac-restrictedpage.pl - Remove the contents of "RestrictedPageTitle" and check the page again. - This patch also updates svc/suggestion.tt but I don't know how to test it! Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34866 --- Comment #5 from David Nind <david@davidnind.com> --- Testing notes (using KTD): 1. Enable OpacShowRecentComments and OpacTopissue system preferences 2. Set AnonymousPatron for anonymous suggestions form to appear (otherwise, you are prompted to log in). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34866 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Will these ever end? :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34866 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34866 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34866 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158265|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 158384 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158384&action=edit Bug 34866: Use template wrapper for breadcrumbs: OPAC part 4 This patch updates several OPAC templates so that they use a new WRAPPER for displaying breadcrumbs. Apply the patch and log in to the OPAC. Test each of the following pages and their variations. Breadcrumbs should look correct, and each link should be correct: - Recent comments - Most popular - Enable "PatronSelfRegistration" and set "PatronSelfRegistrationVerifyByEmail" to "Don't require." - In the OPAC, go to "Register here." Fill out the form and submit your registration. - Check the "Registration complete" page. - Set "PatronSelfRegistrationVerifyByEmail" to "Require" - Submit another registration and check the "Confirm your registration" page. - Visit the registration page passing an invalid token: /cgi-bin/koha/opac-registration-verify.pl?token=foo Check the "Registration invalid" page. - Enable the "ArticleRequests" system preference and log in to the OPAC. - Perform a search which will return results. - Check the search results page - View the detail page for one of the results. - Click "Request article." - Return to the detail page and click "Place hold." - Complete each step of the hold process. - Enable the "OpacAllowSharingPrivateLists" system preference. - Create a private list if necessary. - Click the "Share" link - Locate a serial record and view the detail page. - Click the "More details" link under the "Subscriptions" plan - Enable the system preference "suggestion." - From the logged-in user summary page click "Purchase suggestions" - Click the "New purchase suggestion" link - Enable the "AnonSuggestions" and "OPACViewOthersSuggestions" system preferences and log out of the OPAC. - View the purchase suggestions page. - Enable the "OpacCloud" system preference and go to the "Subject cloud" page. (the feature doesn't need to be configured to test). - Populate the "RestrictedPageTitle" and "RestrictedPageContent" system preferences and navigate directly to /cgi-bin/koha/opac-restrictedpage.pl - Remove the contents of "RestrictedPageTitle" and check the page again. - This patch also updates svc/suggestion.tt but I don't know how to test it! Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34866 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34866 --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34866 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED CC| |fridolin.somers@biblibre.co | |m --- Comment #9 from Fridolin Somers <fridolin.somers@biblibre.com> --- Depends on Bug 34849 not in 23.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34866 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35676 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35676 [Bug 35676] OPAC search results - link for "Check for suggestions" generates a blank page -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org