[Bug 24121] New: Item types icons not showing in intra search results if item-level_itypes syspref is set to biblio
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24121 Bug ID: 24121 Summary: Item types icons not showing in intra search results if item-level_itypes syspref is set to biblio Change sponsored?: --- Product: Koha Version: 19.05 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Searching Assignee: koha-bugs@lists.koha-community.org Reporter: pjamorim91@gmail.com QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24121 --- Comment #1 from Pedro Amorim <pjamorim91@gmail.com> --- Created attachment 95827 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95827&action=edit Fix for knowing correct interface (opac or intra) when requesting itemtype icons -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24121 --- Comment #2 from Pedro Amorim <pjamorim91@gmail.com> --- Itemtype icons in intra search results are pointing to opac image path, this patch fixes that. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24121 Pedro Amorim <pjamorim91@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Item types icons not |Item types icons in intra |showing in intra search |search results are |results if |requesting icons from opac |item-level_itypes syspref |images path if |is set to biblio |item-level_itypes syspref | |is set to biblio -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24121 --- Comment #3 from Pedro Amorim <pjamorim91@gmail.com> --- Edited original title of "Item types icons not showing in intra search results if item-level_itypes syspref is set to biblio" to something more accurate. The original reason it was not showing for my installation is something specific (IP and port access - instead of url) but the fix still remains relevant, I believe. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24121 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Version|19.05 |master CC| |jonathan.druart@bugs.koha-c | |ommunity.org Assignee|koha-bugs@lists.koha-commun |pjamorim91@gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24121 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14385 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Caused by commit 5e4e10c4ca558180137bf5a4ff5a68495efa0ec7 Bug 14385: Extend OpacHiddenItems to allow specifying exempt borrower categories Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24121 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Pedro this patch looks good and I'm ready so sign off on it, but it needs a good commit message. Please look at the guidelines here: https://wiki.koha-community.org/wiki/Commit_messages Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24121 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- *** Bug 24198 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24121 --- Comment #7 from Pedro Amorim <pjamorim91@gmail.com> --- Created attachment 96146 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96146&action=edit Bug 24121 - Item types icons in intra search results are requesting icons from opac images path if item-level_itypes syspref is set to biblio Please let me know if this looks good, Owen. Thank you. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24121 --- Comment #8 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- (In reply to Pedro Amorim from comment #7)
Created attachment 96146 [details] [review] Bug 24121 - Item types icons in intra search results are requesting icons from opac images path if item-level_itypes syspref is set to biblio
Please let me know if this looks good, Owen. Thank you.
Not yet, commit message must start with : "Bug 24121: " And message is too long, I propose you remove "if item-level_itypes syspref is set to biblio" it is in description. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24121 Pedro Amorim <pjamorim91@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Item types icons in intra |Item types icons in intra |search results are |search results are |requesting icons from opac |requesting icons from opac |images path if |images path |item-level_itypes syspref | |is set to biblio | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24121 Pedro Amorim <pjamorim91@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95827|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24121 Pedro Amorim <pjamorim91@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96146|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24121 --- Comment #9 from Pedro Amorim <pjamorim91@gmail.com> --- Created attachment 96194 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96194&action=edit Bug 24121 - Item types icons in intra search results are requesting icons from opac images path Hello Fridolin, thank you for your time. Let me know if it's okay now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24121 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24121 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24121 --- Comment #10 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 96506 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96506&action=edit Bug 24121: Item types icons in intra search results are requesting icons from opac images path When searching in INTRA you'll notice the item type icons not showing. To test: 1) Set syspref item-level_itypes to biblio 2) Confirm that there is a biblioitems.itemtype mapping to a MARC field 3) Verify that item type icons are set for all the types 4) Perform a search where biblios with said MARC field is filled with a type value 5) Verify that where the icon should appear, it's showing the browser icon for image not found 6) Apply patch. 7) Repeat step 4. 8) Observe the icons are now displayed correctly Sponsored-by: Governo Regional dos Açores Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24121 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96194|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24121 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24121 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96506|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 96575 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96575&action=edit Bug 24121: Item types icons in intra search results are requesting icons from opac images path When searching in INTRA you'll notice the item type icons not showing. To test: 1) Set syspref item-level_itypes to biblio 2) Confirm that there is a biblioitems.itemtype mapping to a MARC field 3) Verify that item type icons are set for all the types 4) Perform a search where biblios with said MARC field is filled with a type value 5) Verify that where the icon should appear, it's showing the browser icon for image not found 6) Apply patch. 7) Repeat step 4. 8) Observe the icons are now displayed correctly Sponsored-by: Governo Regional dos Açores Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24121 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24121 --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24121 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00 |20.05.00, 19.11.02 released in| | CC| |joy@bywatersolutions.com Status|Pushed to master |Pushed to stable --- Comment #13 from Joy Nelson <joy@bywatersolutions.com> --- Pushed to 19.11.x branch for 19.11.02 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24121 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable CC| |lucas@bywatersolutions.com --- Comment #14 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 19.05.x for 19.05.07 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24121 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hayleymapley@catalyst.net.n | |z Version(s)|20.05.00, 19.11.02 |20.05.00, 19.11.02, released in| |19.05.07, 18.11.13 Status|Pushed to oldstable |Pushed to oldoldstable --- Comment #15 from Hayley Mapley <hayleymapley@catalyst.net.nz> --- Backported to 18.11.x for 18.11.13 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24121 Andreas Roussos <a.roussos@dataly.gr> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32908 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24121 Andreas Roussos <a.roussos@dataly.gr> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32909 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org