[Bug 40865] New: Single patron result does not redirect
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40865 Bug ID: 40865 Summary: Single patron result does not redirect Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff interface Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Possibly related to bug 36302 To recreate: 1 - Search for 'edna acosta' in check out search on koha home page 2 - See the one result 3 - You are expected to be redirected to the patron's page -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40865 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |36302 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36302 [Bug 36302] Patron search from search bar broken -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40865 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|36302 |38255 CC| |pedro.amorim@openfifth.co.u | |k --- Comment #1 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- e9b8004d197876dea8c38374c08ec00451e37020 is the first bad commit commit e9b8004d197876dea8c38374c08ec00451e37020 Author: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Date: Thu Nov 28 16:20:24 2024 +0100 Bug 38255: Replace dataTable constructor with kohaTable - Staff Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> ---- reset HEAD to commit before 38255, redirect works: b4662eb60acbfe64ca60934ec31d9d078f0fac5a reset HEAD to first commit of bug 38255, redirect doesnt work: e9b8004d197876dea8c38374c08ec00451e37020 reset to final commit of bug 38255, redirect still doesnt work: 8ff56432d125fee3fdb32499382e01707876c758 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36302 [Bug 36302] Patron search from search bar broken https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38255 [Bug 38255] Do not use dataTable constructor directly -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40865 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33495 CC| |cbrannon@cdalibrary.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40865 Eric Phetteplace <ephetteplace@cca.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ephetteplace@cca.edu -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40865 Rebecca Coert <rcoert@arlingtonva.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rcoert@arlingtonva.us -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40865 Mikko Liimatainen <mikko.liimatainen@turku.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mikko.liimatainen@turku.fi --- Comment #2 from Mikko Liimatainen <mikko.liimatainen@turku.fi> --- This is a good feature for us. Name searches should never redirect even if there is a single result. I would like to again suggest that there should be a system preference similar to the catalogue preference RedirectToSoleResult for patrons. We would like it to only redirect on exact match of a card number. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40865 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com Assignee|koha-bugs@lists.koha-commun |jonathan.druart@gmail.com |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40865 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40865 --- Comment #3 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 186917 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186917&action=edit Bug 40865: Redirect if only one patron is found Regression from commit e9b8004d197876dea8c38374c08ec00451e37020 Bug 38255: Replace dataTable constructor with kohaTable - Staff We should keep the params passed and not override them Test plan: 1 - Search for 'edna acosta' in check out search on koha home page 2 - See the one result 3 - You are expected to be redirected to the patron's page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40865 --- Comment #4 from Jonathan Druart <jonathan.druart@gmail.com> --- Several things to note: 1. main is broken at the moment (we are waiting for bug 40876 and bug 40565) 2. We need a test here 3. I am currently trying to catch possible side-effects -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40865 --- Comment #5 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 186920 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186920&action=edit Bug 40865: Add a cypress test -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40865 Kristi Krueger <kkrueger@cuyahogalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kkrueger@cuyahogalibrary.or | |g -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40865 Sarah Cornell <sbcornell@cityofportsmouth.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sbcornell@cityofportsmouth. | |com --- Comment #6 from Sarah Cornell <sbcornell@cityofportsmouth.com> --- +1 for a system preference selecting the behavior. We would like name searches even with partial information to redirect to the patron's page when there is only one result. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40865 --- Comment #7 from Jonathan Druart <jonathan.druart@gmail.com> --- This patch is restoring the historical behaviour. If we need a pref it should be on a separate bug report IMO. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40865 --- Comment #8 from Christopher Brannon <cbrannon@cdalibrary.org> --- Great. That would be perfect for bug 33495. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40865 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40865 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186917|0 |1 is obsolete| | --- Comment #9 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 186926 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186926&action=edit Bug 40865: Redirect if only one patron is found Regression from commit e9b8004d197876dea8c38374c08ec00451e37020 Bug 38255: Replace dataTable constructor with kohaTable - Staff We should keep the params passed and not override them Test plan: 1 - Search for 'edna acosta' in check out search on koha home page 2 - See the one result 3 - You are expected to be redirected to the patron's page Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40865 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186920|0 |1 is obsolete| | --- Comment #10 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 186927 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186927&action=edit Bug 40865: Add a cypress test Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40865 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |blawlor@clamsnet.org --- Comment #11 from Brendan Lawlor <blawlor@clamsnet.org> --- This works as described to restore the original behavior of redirecting when one result is returned. Note when testing you may have to do yarn build && restart_all for it to take effect -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40865 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40865 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186926|0 |1 is obsolete| | --- Comment #12 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 186955 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186955&action=edit Bug 40865: Redirect if only one patron is found Regression from commit e9b8004d197876dea8c38374c08ec00451e37020 Bug 38255: Replace dataTable constructor with kohaTable - Staff We should keep the params passed and not override them Test plan: 1 - Search for 'edna acosta' in check out search on koha home page 2 - See the one result 3 - You are expected to be redirected to the patron's page Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40865 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186927|0 |1 is obsolete| | --- Comment #13 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 186956 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186956&action=edit Bug 40865: Add a cypress test Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40865 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40865 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40865 --- Comment #14 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40865 Gretchen Maxeiner <maxeinergl@gcc.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |maxeinergl@gcc.edu --- Comment #15 from Gretchen Maxeiner <maxeinergl@gcc.edu> --- Will this fix also restore direct access for other non-cardnumber searches besides name? Our patrons use ProxIDs at the circulation desk, and that uses a unique ID that is in a sort field. We need this to go direct to the patron record and check-out screen as it did before. This is affecting every checkout we do. For this reason I would also ask if this be backported to 25.05 so that it will be available sooner. Thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40865 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40865 Julie <julie@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eric_styles@loomis.org, | |julie@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40865 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_25_05_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40865 --- Comment #16 from Kristi Krueger <kkrueger@cuyahogalibrary.org> --- Is this a candidate for backport? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40865 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.11.00 |25.11.00,25.05.05 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40865 --- Comment #17 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 25.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40865 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting CC| |baptiste.wojtkowski@biblibr | |e.com --- Comment #18 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Bug not reproduced in 24.11.x, code is different, not backporting. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40865 carthur@slolibrary.org <carthur@slolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |carthur@slolibrary.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40865 Bug 40865 depends on bug 38255, which changed state. Bug 38255 Summary: Do not use dataTable constructor directly https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38255 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40865 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_25_05_candidate | CC| |paul.derscheid@lmscloud.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40865 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Status|Needs documenting |RESOLVED Resolution|--- |FIXED --- Comment #19 from David Nind <david@davidnind.com> --- Bug fix, no changes to the documentation required. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40865 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org