[Bug 19769] New: 'Pickup library is different' message does not display library branch name when placing hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19769 Bug ID: 19769 Summary: 'Pickup library is different' message does not display library branch name when placing hold Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: claire_gravely@hotmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com When placing a hold for a patron whose pickup library and home library are different, the message displayed only shows the branch code and not the branch name. To reproduce: Go to place a hold on an item for a patron whose home library is different to that of the item. The message: 'Pickup library is different...' will be displayed but the branch name is missing. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19769 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |claire_gravely@hotmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19769 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19769 --- Comment #1 from Claire Gravely <claire_gravely@hotmail.com> --- Created attachment 69594 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69594&action=edit When placing a hold for a patron whose pickup library and home library are different, the message displayed only shows the branch code and not the branch name. This patch displays the branch name as well as the branch code. To test: 1. Search for an item 2. Click 'place hold' 3. Enter patron name/card number for a patron whose home library is different to the item's 4. Note the message displayed only shows the branch code but not the name 5. Apply Patch 6. Repeat 1-3 7. Message should not also display the branch name -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19769 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19769 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69594|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 69605 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69605&action=edit Bug 19769: 'Pickup library is different' message does not display library branch name when placing hold When placing a hold for a patron whose pickup library and home library are different, the message displayed only shows the branch code and not the branch name. This patch displays the branch name as well as the branch code. To test: 1. Search for an item 2. Click 'place hold' 3. Enter patron name/card number for a patron whose home library is different to the item's 4. Note the message displayed only shows the branch code but not the name 5. Apply Patch 6. Repeat 1-3 7. Message should not also display the branch name https://bugs.koha-community.org/show_bug.cgi?id=19769 Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19769 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19769 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69605|0 |1 is obsolete| | --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 69609 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69609&action=edit Bug 19769: 'Pickup library is different' message does not display library branch name when placing hold When placing a hold for a patron whose pickup library and home library are different, the message displayed only shows the branch code and not the branch name. This patch displays the branch name as well as the branch code. To test: 1. Search for an item 2. Click 'place hold' 3. Enter patron name/card number for a patron whose home library is different to the item's 4. Note the message displayed only shows the branch code but not the name 5. Apply Patch 6. Repeat 1-3 7. Message should now also display the branch name https://bugs.koha-community.org/show_bug.cgi?id=19769 Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19769 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15758 CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Caused by commit df97814f3034a3d5015546c4eca21f08ae951e37 Bug 15758: Koha::Libraries - Remove GetBranches (certainly a bad merge conflict) Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758 [Bug 15758] Move the C4::Branch related code to Koha::Libraries - part 4 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19769 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19769 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |nick@bywatersolutions.com --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to stable for 17.11.01 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org