http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12879 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12879 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com Assignee|chris@bigballofwax.co.nz |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12879 --- Comment #2 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 31622 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31622&action=edit [SIGNED OFF] Bug 12879: Remove unnecesary diags from Holds.t There are two unnecessary diag statements: - Creating biblio instance for testing. - Creating item instance for testing. TEST PLAN --------- 1) prove t/db_dependent/Holds.t t/db_dependent/Holds.t .. 1/38 # Creating biblio instance for testing. Use of uninitialized value in subroutine entry at /home/tcohen/git/koha-community-src/C4/Charset.pm line 181. # Creating item instance for testing. Use of uninitialized value in subroutine entry at /home/tcohen/git/koha-community-src/C4/Charset.pm line 181. Use of uninitialized value in subroutine entry at /home/tcohen/git/koha-community-src/C4/Charset.pm line 181. t/db_dependent/Holds.t .. ok All tests successful. Files=1, Tests=38, 1 wallclock secs ( 0.03 usr 0.01 sys + 1.13 cusr 0.11 csys = 1.28 CPU) Result: PASS -- They are in the first and fourth lines of this sample output 2) apply patch 3) prove t/db_dependent/Holds.t t/db_dependent/Holds.t .. 1/38 Use of uninitialized value in subroutine entry at /home/mtompset/kohaclone/C4/Charset.pm line 186. Use of uninitialized value in subroutine entry at /home/mtompset/kohaclone/C4/Charset.pm line 186. Use of uninitialized value in subroutine entry at /home/mtompset/kohaclone/C4/Charset.pm line 186. t/db_dependent/Holds.t .. ok All tests successful. Files=1, Tests=38, 1 wallclock secs ( 0.01 usr 0.00 sys + 0.78 cusr 0.09 csys = 0.88 CPU) Result: PASS -- They are no longer in the first and fourth lines of this sample output 4) run koha QA test tool Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12879 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31415|0 |1 is obsolete| | Attachment #31622|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 31628 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31628&action=edit Bug 12879: Remove unnecesary diags from Holds.t There are two unnecessary diag statements: - Creating biblio instance for testing. - Creating item instance for testing. TEST PLAN --------- 1) prove t/db_dependent/Holds.t t/db_dependent/Holds.t .. 1/38 # Creating biblio instance for testing. Use of uninitialized value in subroutine entry at /home/tcohen/git/koha-community-src/C4/Charset.pm line 181. # Creating item instance for testing. Use of uninitialized value in subroutine entry at /home/tcohen/git/koha-community-src/C4/Charset.pm line 181. Use of uninitialized value in subroutine entry at /home/tcohen/git/koha-community-src/C4/Charset.pm line 181. t/db_dependent/Holds.t .. ok All tests successful. Files=1, Tests=38, 1 wallclock secs ( 0.03 usr 0.01 sys + 1.13 cusr 0.11 csys = 1.28 CPU) Result: PASS -- They are in the first and fourth lines of this sample output 2) apply patch 3) prove t/db_dependent/Holds.t t/db_dependent/Holds.t .. 1/38 Use of uninitialized value in subroutine entry at /home/mtompset/kohaclone/C4/Charset.pm line 186. Use of uninitialized value in subroutine entry at /home/mtompset/kohaclone/C4/Charset.pm line 186. Use of uninitialized value in subroutine entry at /home/mtompset/kohaclone/C4/Charset.pm line 186. t/db_dependent/Holds.t .. ok All tests successful. Files=1, Tests=38, 1 wallclock secs ( 0.01 usr 0.00 sys + 0.78 cusr 0.09 csys = 0.88 CPU) Result: PASS -- They are no longer in the first and fourth lines of this sample output 4) run koha QA test tool Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.