[Bug 28919] New: When placing a multi-hold from results in staff pickup location is empty
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28919 Bug ID: 28919 Summary: When placing a multi-hold from results in staff pickup location is empty Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, tomascohen@gmail.com When placing multiple holds from the result list, the pick-up location is empty now, which makes it a more tedious process than it needs to be. When placing a single hold the home library of the patron is used a default, same should apply if you place multiple holds. Could this be a side effect of bug 28273? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28919 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm testing again - it's actually probably the library currently logged in at? Not the homebranch... in any case: same logic should apply for single hold and multi-holds. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28919 --- Comment #2 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 124419 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124419&action=edit Bug 28919: Select logged in library as pickup for multi holds When placing multiple holds from the result list, the pick-up location is empty now, which makes it a more tedious process than it needs to be. Logged in library must be selected to match the single hold logic. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28919 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |jonathan.druart+koha@gmail. |ity.org |com CC| |jonathan.druart+koha@gmail. | |com --- Comment #3 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- The very happy with the patch but it's working. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28919 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28919 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28919 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124419|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 125221 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125221&action=edit Bug 28919: Select logged in library as pickup for multi holds When placing multiple holds from the result list, the pick-up location is empty now, which makes it a more tedious process than it needs to be. Logged in library must be selected to match the single hold logic. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28919 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am sorry, I tried "restart_all" multiple times, but the pull downs remain empty. I am using the admin user (42), logged in at Centerville. When placing a single hold, Centerville is selected. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28919 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28919 --- Comment #6 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Katrin Fischer from comment #5)
I am sorry, I tried "restart_all" multiple times, but the pull downs remain empty.
I am using the admin user (42), logged in at Centerville.
When placing a single hold, Centerville is selected.
The pull down from the top, the "Pickup at:"? https://snipboard.io/pRHAMn.jpg -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28919 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> ---
The pull down from the top, the "Pickup at:"?
Oh! I never noticed the one on top - will try to retry :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28919 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28919 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28919 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125221|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 125658 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125658&action=edit Bug 28919: Select logged in library as pickup for multi holds When placing multiple holds from the result list, the pick-up location is empty now, which makes it a more tedious process than it needs to be. Logged in library must be selected to match the single hold logic. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28919 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Ok, this works as I think it should, pre-selecting the right branch. BUT: When you try to save the holds, it complains: Please make sure all selected titles have a pickup location set If you switch the pick-up location to another, they will all be set below as well. So I think we do not only need to pre-select for the one on top, but for all holds displayed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28919 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |In Discussion --- Comment #10 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Well, what's the point of the first/main select then? Tomas? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28919 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au Depends on| |28273 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28273 [Bug 28273] Multi-holds allow invalid pickup locations -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28919 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|28273 | See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28273 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28273 [Bug 28273] Multi-holds allow invalid pickup locations -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28919 --- Comment #11 from David Cook <dcook@prosentient.com.au> --- Created attachment 128144 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128144&action=edit Bug 28919: [Alternative] Select logged in library as pickup for multi holds Default pickup location to the logged in library for staff placed multiholds. Holds with a blank pickup location will cause 500 errors in the Reserves tab of the circulation screen, so we want to make sure the pickup location does not default to blank. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28919 --- Comment #12 from David Cook <dcook@prosentient.com.au> --- Attaching an alternative patch here, although I think Jonathan's is better overall (just needs to be applies to the "Pickup location" as well). This is causing frequent problems for a library of mine, so I'm keen to get a fix implemented ASAP. Personally, I think a lot of holds logic and error-handling needs work, but I don't mind just putting out fires for now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28919 --- Comment #13 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Jonathan Druart from comment #10)
Well, what's the point of the first/main select then? Tomas?
This form had a problem, orginally: it allowed you to place holds with invalid pickup locations, and didn't even require AllowHoldPolicyOverride. The idea was to make it so you weren't offered bad pickup locations. Asking different libraries, it turned out this wasn't a bad workflow: - You select several biblios and click place hold - A form is presented (similar to the one before - There's a dropdown that lets you choose the union of the valid pickup locations from all selected titles - Only those for which the chosen one is a valid one are set - The rest require manually setting them - If you manually set one, changing the top-level 'Pickup at' one should not change it - It needs to honour the UI decision we made about overriden pickup locations, having them show a notice about them being an override to rules So that's it. Reading the bug description, my guess is that: - The 'Pickup at' dropdown might need some better explanation in the UI (a hint, a visible text) - I read a comment from dcook somewhere else, and it felt like he found a bug that made the form send empty pickup locations, that actually hit the DB, that'd be a bug, not a usability discussion. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28919 --- Comment #14 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Tomás Cohen Arazi from comment #13)
(In reply to Jonathan Druart from comment #10)
Well, what's the point of the first/main select then? Tomas?
This form had a problem, orginally: it allowed you to place holds with invalid pickup locations, and didn't even require AllowHoldPolicyOverride. The idea was to make it so you weren't offered bad pickup locations.
Asking different libraries, it turned out this wasn't a bad workflow: - You select several biblios and click place hold - A form is presented (similar to the one before - There's a dropdown that lets you choose the union of the valid pickup locations from all selected titles - Only those for which the chosen one is a valid one are set - The rest require manually setting them - If you manually set one, changing the top-level 'Pickup at' one should not change it - It needs to honour the UI decision we made about overriden pickup locations, having them show a notice about them being an override to rules
So that's it. Reading the bug description, my guess is that: - The 'Pickup at' dropdown might need some better explanation in the UI (a hint, a visible text) - I read a comment from dcook somewhere else, and it felt like he found a bug that made the form send empty pickup locations, that actually hit the DB, that'd be a bug, not a usability discussion.
And making a default selection is good too. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28919 --- Comment #15 from David Cook <dcook@prosentient.com.au> --- (In reply to Tomás Cohen Arazi from comment #13)
- I read a comment from dcook somewhere else, and it felt like he found a bug that made the form send empty pickup locations, that actually hit the DB, that'd be a bug, not a usability discussion.
Yeah I was thinking the same thing. We could throw an exception client-side or server-side (or both). (In reply to Tomás Cohen Arazi from comment #14)
And making a default selection is good too.
I think this would be a good first step, since it requires only a small change and brings multiholds in line with require holds I think. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28919 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugs.koha-community |https://bugs.koha-community |.org/bugzilla3/show_bug.cgi |.org/bugzilla3/show_bug.cgi |?id=28273 |?id=29349 Depends on| |28273 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28273 [Bug 28273] Multi-holds allow invalid pickup locations -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28919 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com --- Comment #16 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- I like Jonathan's patch here, it does what libraries have indicated they want. Though I agree that on initial page load all dropdowns (the overall dropdown at the top and the individual dropdowns on each title) should default to the logged in branch if that's a valid pickup location. But if the logged-in branch is not a valid pickup location for one of the titles, then that title's dropdown should be blank to start and require one to select a valid pickup location before the form can be submitted. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28919 --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Andrew Fuerste-Henry from comment #16)
I like Jonathan's patch here, it does what libraries have indicated they want. Though I agree that on initial page load all dropdowns (the overall dropdown at the top and the individual dropdowns on each title) should default to the logged in branch if that's a valid pickup location.
But if the logged-in branch is not a valid pickup location for one of the titles, then that title's dropdown should be blank to start and require one to select a valid pickup location before the form can be submitted.
+1 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28919 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #18 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to Andrew Fuerste-Henry from comment #16)
I like Jonathan's patch here, it does what libraries have indicated they want. Though I agree that on initial page load all dropdowns (the overall dropdown at the top and the individual dropdowns on each title) should default to the logged in branch if that's a valid pickup location.
But if the logged-in branch is not a valid pickup location for one of the titles, then that title's dropdown should be blank to start and require one to select a valid pickup location before the form can be submitted.
+1 I think this would be behavior that is consistent with that Tomas did in Bug 29349 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28919 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|jonathan.druart+koha@gmail. |tomascohen@gmail.com |com | Status|In Discussion |ASSIGNED --- Comment #19 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Tomas, I think you are the best placed to finish the work here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28919 --- Comment #20 from David Cook <dcook@prosentient.com.au> --- I'm having libraries still experiencing this issue. At the moment, the build_holds_queue.pl is now sending them emails with error messages every 15 minutes... -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org