[Bug 23168] New: Ability to disable some plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23168 Bug ID: 23168 Summary: Ability to disable some plugins Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Installation and upgrade (command-line installer) Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvoize@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org CC: agustinmoyano@theke.io, alex.arnaud@biblibre.com, axel.amghar@gmail.com, dcook@prosentient.com.au, gmcharlt@gmail.com, jose-mario.monteiro-santos@inlibro.com, katrin.fischer@bsz-bw.de, martin.renvoize@ptfs-europe.com, nick@bywatersolutions.com, tomascohen@gmail.com Depends on: 22053 Blocks: 21073, 22906 Target Milestone: --- With the combination of bug 21073 and bug 22053 in master now we have a breakage in updatedatabase. Bug 21073 uses Koha::Plugins to handle the GetPlugins call, but GetPlugins was changed to use DB tables which are built after the db update for bug 21073 runs and so the call fails during upgrades. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073 [Bug 21073] Improve plugin performance https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22053 [Bug 22053] Ability to disable some plugins https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22906 [Bug 22906] Minor corrections to plugins home page -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23168 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Ability to disable some |Database Updates broken due |plugins |to conflicts in bug 21073 | |and bug 22053 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23168 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|The ability to | release notes|enable/disable plugins is | |added. This is particularly | |handy when testing new | |plugins or when plugins are | |not (yet) fully configured | |for production use. | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23168 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|21073, 22906 | Depends on| |21073 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073 [Bug 21073] Improve plugin performance https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22906 [Bug 22906] Minor corrections to plugins home page -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23168 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23168 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23168 --- Comment #1 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Thankfully.. this one does only effect master at the moment. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23168 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |23171 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23171 [Bug 23171] Improve plugin performance -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23168 --- Comment #2 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- We may ask to run an atomic perl script after upgrade ? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23168 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think if anyway possible we should avoid separate update scripts. They get missed too often and cause lots of issues then. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23168 --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- I have a patch for this -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23168 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23168 --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 90851 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90851&action=edit Bug 23168: Enable plugins using plain SQL Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23168
Tomás Cohen Arazi <tomascohen@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #90851|0 |1
is obsolete| |
--- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> ---
Created attachment 90852
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90852&action=edit
Bug 23168: Enable plugins using plain SQL
To test:
- On a clean 18.11.x, install a plugin [1]
- Run:
$ sudo koha-mysql kohadev
> SELECT * FROM plugin_data;
=> SUCCESS: Notice there's a __INSTALLED_VERSION__ line for your plugin
- Checkout latest master, restart all the things
- Run:
$ updatedatabase
=> FAIL: It fails on 18.12.00.069 because the plugin_methods table doesn't
exist
- Run:
$ sudo koha-mysql kohadev
> SELECT * FROM plugin_data;
=> FAIL: No __ENABLED__ line for your plugin
- Apply the patch
- Run:
$ updatedatabase
=> SUCCESS: Update passes the 18.12.00.069 step correctly
- Run:
$ sudo koha-mysql kohadev
> SELECT * FROM plugin_data;
=> SUCCESS: There's an __ENABLED__ line for your plugin
- Sign off :-D
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23168 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23168
Kyle M Hall <kyle@bywatersolutions.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #90852|0 |1
is obsolete| |
--- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> ---
Created attachment 90853
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90853&action=edit
Bug 23168: Enable plugins using plain SQL
To test:
- On a clean 18.11.x, install a plugin [1]
- Run:
$ sudo koha-mysql kohadev
> SELECT * FROM plugin_data;
=> SUCCESS: Notice there's a __INSTALLED_VERSION__ line for your plugin
- Checkout latest master, restart all the things
- Run:
$ updatedatabase
=> FAIL: It fails on 18.12.00.069 because the plugin_methods table doesn't
exist
- Run:
$ sudo koha-mysql kohadev
> SELECT * FROM plugin_data;
=> FAIL: No __ENABLED__ line for your plugin
- Apply the patch
- Run:
$ updatedatabase
=> SUCCESS: Update passes the 18.12.00.069 step correctly
- Run:
$ sudo koha-mysql kohadev
> SELECT * FROM plugin_data;
=> SUCCESS: There's an __ENABLED__ line for your plugin
- Sign off :-D
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23168
Martin Renvoize <martin.renvoize@ptfs-europe.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #90853|0 |1
is obsolete| |
--- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> ---
Created attachment 90854
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90854&action=edit
Bug 23168: Enable plugins using plain SQL
To test:
- On a clean 18.11.x, install a plugin [1]
- Run:
$ sudo koha-mysql kohadev
> SELECT * FROM plugin_data;
=> SUCCESS: Notice there's a __INSTALLED_VERSION__ line for your plugin
- Checkout latest master, restart all the things
- Run:
$ updatedatabase
=> FAIL: It fails on 18.12.00.069 because the plugin_methods table doesn't
exist
- Run:
$ sudo koha-mysql kohadev
> SELECT * FROM plugin_data;
=> FAIL: No __ENABLED__ line for your plugin
- Apply the patch
- Run:
$ updatedatabase
=> SUCCESS: Update passes the 18.12.00.069 step correctly
- Run:
$ sudo koha-mysql kohadev
> SELECT * FROM plugin_data;
=> SUCCESS: There's an __ENABLED__ line for your plugin
- Sign off :-D
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23168
Martin Renvoize <martin.renvoize@ptfs-europe.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #90854|0 |1
is obsolete| |
--- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> ---
Created attachment 90855
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90855&action=edit
Bug 23168: Enable plugins using plain SQL
To test:
- On a clean 18.11.x, install a plugin [1]
- Run:
$ sudo koha-mysql kohadev
> SELECT * FROM plugin_data;
=> SUCCESS: Notice there's a __INSTALLED_VERSION__ line for your plugin
- Checkout latest master, restart all the things
- Run:
$ updatedatabase
=> FAIL: It fails on 18.12.00.069 because the plugin_methods table doesn't
exist
- Run:
$ sudo koha-mysql kohadev
> SELECT * FROM plugin_data;
=> FAIL: No __ENABLED__ line for your plugin
- Apply the patch
- Run:
$ updatedatabase
=> SUCCESS: Update passes the 18.12.00.069 step correctly
- Run:
$ sudo koha-mysql kohadev
> SELECT * FROM plugin_data;
=> SUCCESS: There's an __ENABLED__ line for your plugin
- Sign off :-D
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23168 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Test plan works for me, Passing QA.. thanks for the quick fix Tomas. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23168 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23168 --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23168 --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Isn't it the same problem at 19.06.00.006? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23168 Bug 23168 depends on bug 23171, which changed state. Bug 23171 Summary: The plugin_methods table should not include imported methods https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23171 What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org