[Bug 40031] New: MARC modification templates should have a unique URL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40031 Bug ID: 40031 Summary: MARC modification templates should have a unique URL Change sponsored?: --- Product: Koha Version: 24.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: esther.melander@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl To replicate: 1. Go to Cataloging > MARC Modification templates note the URL = /cgi-bin/koha/tools/marc_modification_templates.pl 2. Add a new template notice the URL = /cgi-bin/koha/tools/marc_modification_templates.pl It would be nice if the template name is incorporated into the URL so the URL can be shared and the user can be taken directly to a template. Currently the user has to go to /cgi-bin/koha/tools/marc_modification_templates.pl and search for the template to see the actions. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40031 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #1 from David Cook <dcook@prosentient.com.au> --- (In reply to Esther Melander from comment #0)
To replicate:
1. Go to Cataloging > MARC Modification templates
note the URL = /cgi-bin/koha/tools/marc_modification_templates.pl
2. Add a new template
notice the URL = /cgi-bin/koha/tools/marc_modification_templates.pl
It would be nice if the template name is incorporated into the URL so the URL can be shared and the user can be taken directly to a template. Currently the user has to go to /cgi-bin/koha/tools/marc_modification_templates.pl and search for the template to see the actions.
Good point! Although it wouldn't be the template name. It would be the template ID. For instance, if you go to edit the actions for the template, you'll have a URL like /cgi-bin/koha/tools/marc_modification_templates.pl?template_id=2&op=select_template So the fix for this would be to add the new template with a POST and then after a successful add, it should redirect the user to /cgi-bin/koha/tools/marc_modification_templates.pl?template_id=<TEMPLATE ID>&op=select_template -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40031 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy --- Comment #2 from David Cook <dcook@prosentient.com.au> --- I'm a bit time poor at the moment, but that should be a simple fix for someone. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40031 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CONFIRMED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40031 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|24.11 |23.11 --- Comment #3 from David Cook <dcook@prosentient.com.au> --- Btw confirmed back to 23.11, but probably an issue for much older versions too -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40031 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|MARC modification templates |Creation of a new MARC |should have a unique URL |modification template | |should redirect to have the | |template ID in the URL CC| |aleisha@catalyst.net.nz --- Comment #4 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Renaming so easier to understand what bug this is addressing -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40031 Raguram Gopinath <aviatorgaming309@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|CONFIRMED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40031 --- Comment #5 from Raguram Gopinath <aviatorgaming309@gmail.com> --- Created attachment 191741 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191741&action=edit Bug 40031: Redirect to add action page from add template form Test plan: 1. Login to staff client. 2. Go to: Cataloging > MARC modification templates > New template 3. Give new template a name and click submit. 4. Following URL loads: http://localhost:8081/cgi-bin/koha/tools/marc_modification_templates.pl If you are using KTD 5. Apply patch and restart services. 6. Repeat steps 2 and 3. 7. Following URL loads: http://localhost:8081/cgi-bin/koha/tools/marc_modification_templates.pl?template_id=(template_id)&op=select_template 8. You can now add actions for your new template. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40031 Raguram Gopinath <aviatorgaming309@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aviatorgaming309@gmail.com Assignee|koha-bugs@lists.koha-commun |aviatorgaming309@gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40031 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Comma delimited| |Catalyst list of Sponsors| | Sponsorship status|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40031 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40031 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191741|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40031 --- Comment #6 from David Nind <david@davidnind.com> --- Created attachment 191769 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191769&action=edit Bug 40031: Redirect to add action page from add template form Test plan: 1. Login to staff client. 2. Go to: Cataloging > MARC modification templates > New template 3. Give new template a name and click submit. 4. Following URL loads: http://localhost:8081/cgi-bin/koha/tools/marc_modification_templates.pl If you are using KTD 5. Apply patch and restart services. 6. Repeat steps 2 and 3. 7. Following URL loads: http://localhost:8081/cgi-bin/koha/tools/marc_modification_templates.pl?template_id=(template_id)&op=select_template 8. You can now add actions for your new template. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40031 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This updates the URL when release notes| |adding a new MARC | |modification template | |(Cataloging > Batch editing | |> MARC modification | |templates). It adds the | |template ID so that you can | |directly link to the | |template. | | | |Previously, you had to | |click `Edit actions` from | |the list of templates, and | |couldn't directly link to | |the template to see the | |actions: | |- Previous URL after adding | |a template: | | | |STAFF-INTERFACE-URL/cgi-bin | |/koha/tools/marc_modificati | |on_templates.pl | |- New URL after adding a | |template: | | | |STAFF-INTERFACE-URL/cgi-bin | |/koha/tools/marc_modificati | |on_templates.pl?template_id | |=(template_id)&op=select_te | |mplate Version|23.11 |Main CC| |david@davidnind.com --- Comment #7 from David Nind <david@davidnind.com> --- I attempted a release note, not sure I got this right... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40031 --- Comment #8 from David Nind <david@davidnind.com> --- Thanks for the patch Raguram! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40031 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com QA Contact|testopia@bugs.koha-communit |lucas@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40031 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40031 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191769|0 |1 is obsolete| | --- Comment #9 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 191843 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191843&action=edit Bug 40031: Redirect to add action page from add template form Test plan: 1. Login to staff client. 2. Go to: Cataloging > MARC modification templates > New template 3. Give new template a name and click submit. 4. Following URL loads: http://localhost:8081/cgi-bin/koha/tools/marc_modification_templates.pl If you are using KTD 5. Apply patch and restart services. 6. Repeat steps 2 and 3. 7. Following URL loads: http://localhost:8081/cgi-bin/koha/tools/marc_modification_templates.pl?template_id=(template_id)&op=select_template 8. You can now add actions for your new template. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40031 --- Comment #10 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Works good! Passing QA here. Thanks Raguram! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40031 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |26.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40031 --- Comment #11 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40031 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|26.05.00 |26.05.00,25.11.03 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40031 --- Comment #12 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Thanks all, pushed to 25.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40031 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This updates the URL when |This updates the URL when release notes|adding a new MARC |adding a new MARC |modification template |modification template |(Cataloging > Batch editing |(Cataloging > Batch editing |> MARC modification |> MARC modification |templates). It adds the |templates). It adds the |template ID so that you can |template ID to the URL so |directly link to the |that you can directly link |template. |to the template. | | |Previously, you had to |Previously, you had to |click `Edit actions` from |click `Edit actions` from |the list of templates, and |the list of templates, and |couldn't directly link to |couldn't directly link to |the template to see the |the template to see the |actions: |actions: |- Previous URL after adding |- Previous URL after adding |a template: |a template: | | |STAFF-INTERFACE-URL/cgi-bin |STAFF-INTERFACE-URL/cgi-bin |/koha/tools/marc_modificati |/koha/tools/marc_modificati |on_templates.pl |on_templates.pl |- New URL after adding a |- New URL after adding a |template: |template: | | |STAFF-INTERFACE-URL/cgi-bin |STAFF-INTERFACE-URL/cgi-bin |/koha/tools/marc_modificati |/koha/tools/marc_modificati |on_templates.pl?template_id |on_templates.pl?template_id |=(template_id)&op=select_te |=(template_id)&op=select_te |mplate |mplate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40031 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Laura.escamilla@bywatersolu | |tions.com Status|Pushed to stable |Needs documenting --- Comment #13 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Not backporting to 25.05 as this is an enhancement. Happy to revisit if needed. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org