https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18629 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel@gmail.com, | |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18629 --- Comment #2 from Marc Véron <veron@veron.ch> --- Created attachment 63573 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63573&action=edit Bug 18629 - Web installer 17.05 not properly translatable Fix for step1.tt Work in progress. Comments welcome. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18629 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #4 from Marc Véron <veron@veron.ch> --- Found some more issues... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18629 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63679|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18629 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18665 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18665 [Bug 18665] Translatability: Add tt filter to allow html tags inside tt directives -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18629 --- Comment #7 from Marc Véron <veron@veron.ch> --- Created attachment 63741 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63741&action=edit Bug 18629 - Translatability: Fix problems with web installer 17.05 The new web installer for 17.05 has a great new design - but it has a lot of translatability issues. Some strings are not picked for translations, some expose the content of tt directives, and others are splitted by html tags, resulting in small text fragments that are not easy to translate. This patch weeds out such translation problems for step1.tt, step2.tt and step3.tt To test: - Apply patch (on top of Bug 18665 because of html tags inside of tt directives in step2.tt) - Prepare a fresh install (drop database, create database) - Walk through the installation process and verify that it works as before - Verify that string changes (in English) make sense - Create a translation( cd misc/translator, then perl translate create aa-AA) then: vim po/aa-AA-staff-prog.po and search for: /installer\/step Verify that strings for step1.tt, step2.tt, step3.tt are not fragmented, do not contain [%%, and are easily translatable (make sense without having to search in source files for context). -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18629 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |Fix translatability issues release notes| |with web installer. Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18629 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63742|0 |1 is obsolete| | --- Comment #9 from Marc Véron <veron@veron.ch> --- Created attachment 63759 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63759&action=edit Bug 18629 - Translatability: Fix problems with web installer 17.05 The new web installer for 17.05 has a great new design - but it has a lot of translatability issues. Some strings are not picked for translations, some expose the content of tt directives, and others are splitted by html tags, resulting in small text fragments that are not easy to translate. This patch weeds out such translation problems for step1.tt, step2.tt and step3.tt To test: - Apply patch (on top of Bug 18665 because of html tags inside of tt directives in step2.tt) - Prepare a fresh install (drop database, create database) - Walk through the installation process and verify that it works as before - Verify that string changes (in English) make sense - Create a translation( cd misc/translator, then perl translate create aa-AA) then: vim po/aa-AA-staff-prog.po and search for: /installer\/step Verify that strings for step1.tt, step2.tt, step3.tt are not fragmented, do not contain [%%, and are easily translatable (make sense without having to search in source files for context). (Amended to remove some superfluous chomps 2017-06-27 mv) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18629 --- Comment #11 from Marc Véron <veron@veron.ch> --- (In reply to Alex Buckley from comment #10)

Hi Marc

When running perl translate create aa-AA I keep getting:

...

Warning: Can't determine original templates' charset, defaulting to UTF-8 Warning: Charset Out defaulting to UTF-8 Removing empty file /home/vagrant/kohaclone/misc/translator/po/aa-AA-staff-prog.po I UTF-8 O UTF-8 at /home/vagrant/kohaclone/misc/translator/tmpl_process3.pl line 345. msgmerge: error while opening "/home/vagrant/kohaclone/misc/translator/po/aa-AA-staff-prog.po" for reading: No such file or directory

The equivalent output happens for all of the other aa-AA files.

Do you have any ideas as to why this may be happening? as I cannot find any useful answers online

On my vm, I do: marc@debian8vm:~/koha/misc/translator$ perl translate create aa-AA I get the same warnings about the charset and the message about revoming an emty file However I do not get the error about opening a file. Does the folder /home/vagrant/kohaclone/misc/translator/po exist? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18629 --- Comment #13 from Marc Véron <veron@veron.ch> --- (In reply to Alex Buckley from comment #12)

yes the folder /home/vagrant/kohaclone/misc/translator/po does exist

Maybe an issue with permissions? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18629 --- Comment #15 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Hi Marc Thanks for the suggestions. So the permissions are fine with the po directory having the following correct permissions: drwxr-xr-x Whilst I can install existing languages using the command: sudo env KOHA_CONF=/etc/koha/sites/kohadev/koha-conf.xml PERL5LIB=/home/vagrant/kohaclone perl translate install fr-FR To install French for example, which worked successfully -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18629 --- Comment #17 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Ah brilliant thanks Marc Although it is displaying the same output as before (see below) the files have actually been created this time. Thanks very much I will test your patches now

Warning: Can't determine original templates' charset, defaulting to UTF-8 Warning: Charset Out defaulting to UTF-8 Removing empty file /home/vagrant/kohaclone/misc/translator/po/aa-AA-staff-prog.po I UTF-8 O UTF-8 at /home/vagrant/kohaclone/misc/translator/tmpl_process3.pl line 345.

-- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18629 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63759|0 |1 is obsolete| | --- Comment #18 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 63768 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63768&action=edit Bug 18629 - Translatability: Fix problems with web installer 17.05 The new web installer for 17.05 has a great new design - but it has a lot of translatability issues. Some strings are not picked for translations, some expose the content of tt directives, and others are splitted by html tags, resulting in small text fragments that are not easy to translate. This patch weeds out such translation problems for step1.tt, step2.tt and step3.tt To test: - Apply patch (on top of Bug 18665 because of html tags inside of tt directives in step2.tt) - Prepare a fresh install (drop database, create database) - Walk through the installation process and verify that it works as before - Verify that string changes (in English) make sense - Create a translation( cd misc/translator, then perl translate create aa-AA) then: vim po/aa-AA-staff-prog.po and search for: /installer\/step Verify that strings for step1.tt, step2.tt, step3.tt are not fragmented, do not contain [%%, and are easily translatable (make sense without having to search in source files for context). (Amended to remove some superfluous chomps 2017-06-27 mv) Followed test plan worked as intended Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18629 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|18688 | See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18688 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18688 [Bug 18688] Warnings about UTF-8 charset when creating a new language -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18629 --- Comment #20 from Marc Véron <veron@veron.ch> --- (In reply to Jonathan Druart from comment #19)

I do not understand how using txt_continue is helping translators:

Before the patch: msgid "Continue to the next step"

After the patch: msgid "%s %sContinue to the next step%s %s"

My intention was to have repeating test at one place, but you are right, the result in the po file is not what we want, and isolating with div tags does not work here. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18629 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #22 from Marc Véron <veron@veron.ch> --- Hope it's OK to set back to SO. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18629 --- Comment #24 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Before and after: msgid "Database name : " => OK Before: msgid "%s (probably OK if blank)" After: msgid "(probably okay if blank)" => This may remove flexibility in some languages? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18629 Bug 18629 depends on bug 18665, which changed state. Bug 18665 Summary: Translatability: Add tt filter to allow html tags inside tt directives https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18665 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18629 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63768|0 |1 is obsolete| | Attachment #64274|0 |1 is obsolete| | --- Comment #26 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 66648 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66648&action=edit Bug 18629 - Translatability: Fix problems with web installer 17.05 The new web installer for 17.05 has a great new design - but it has a lot of translatability issues. Some strings are not picked for translations, some expose the content of tt directives, and others are splitted by html tags, resulting in small text fragments that are not easy to translate. This patch weeds out such translation problems for step1.tt, step2.tt and step3.tt To test: - Apply patch (on top of Bug 18665 because of html tags inside of tt directives in step2.tt) - Prepare a fresh install (drop database, create database) - Walk through the installation process and verify that it works as before - Verify that string changes (in English) make sense - Create a translation( cd misc/translator, then perl translate create aa-AA) then: vim po/aa-AA-staff-prog.po and search for: /installer\/step Verify that strings for step1.tt, step2.tt, step3.tt are not fragmented, do not contain [%%, and are easily translatable (make sense without having to search in source files for context). (Amended to remove some superfluous chomps 2017-06-27 mv) Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18629 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #28 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18629 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|Fix translatability issues | release notes|with web installer. | -- You are receiving this mail because: You are watching all bug changes.