[Bug 24662] New: Remove global variables MSG_* from datatables.inc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24662 Bug ID: 24662 Summary: Remove global variables MSG_* from datatables.inc Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: julian.maurice@biblibre.com Reporter: julian.maurice@biblibre.com QA Contact: testopia@bugs.koha-community.org CC: frederic@tamil.fr Now that bug 21156 is pushed, we don't need to have global variables in .inc or .tt files for translation in .js file. We can simply declare our translatable strings where they are used. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24662 --- Comment #1 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 98921 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98921&action=edit Bug 24662: Remove global variables MSG_* from datatables.inc Now that bug 21156 is pushed, we don't need to have global variables in .inc or .tt files for translation in .js file. We can simply declare our translatable strings where they are used. This patch removes all global variables used in DataTables configuration Test plan: 1. cd misc/translator && ./translate update fr-FR 2. Translate strings in misc/tranlator/po/fr-FR-messages-js.po 3. cd misc/translator && ./translate install fr-FR 4. Go to the staff interface, in english, and check that DataTables tables are still working. You should check at least the following pages: - catalogue/detail.pl - circ/circulation.pl - tools/quotes.pl - tools/letter.pl 5. Switch to french and check again DataTables tables, and verify that strings are translated This patch depends on bug 24661 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24662 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24661 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24661 [Bug 24661] Inclusion of locale-related javascript files is broken -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24662 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24662 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel@gmail.com --- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Hi, two comments: a) You need to create fr-FR-messages-js.po first, or update fails. I'll try to write a Bug to create them all b) There are problems with qa-tools FAIL koha-tmpl/intranet-tmpl/prog/js/checkouts.js OK git manipulation FAIL untranslatable_strings Untranslatable string found (Loading... you may continue scanning.) - See coding guideline JS5 FAIL koha-tmpl/intranet-tmpl/prog/js/datatables.js OK git manipulation FAIL untranslatable_strings Untranslatable string found (First) - See coding guideline JS5 Untranslatable string found (Last) - See coding guideline JS5 Untranslatable string found (Next) - See coding guideline JS5 Untranslatable string found (Previous) - See coding guideline JS5 Untranslatable string found (No data available in table) - See coding guideline JS5 Untranslatable string found (Showing _START_ to _END_ of _TOTAL_ entries) - See coding guideline JS5 Untranslatable string found (No entries to show) - See coding guideline JS5 Untranslatable string found ((filtered from _MAX_ total entries)) - See coding guideline JS5 Untranslatable string found (Show _MENU_ entries) - See coding guideline JS5 Untranslatable string found (Loading...) - See coding guideline JS5 Untranslatable string found (Processing...) - See coding guideline JS5 Untranslatable string found (Search:) - See coding guideline JS5 Untranslatable string found (No matching records found) - See coding guideline JS5 Untranslatable string found (Copy to clipboard) - See coding guideline JS5 Untranslatable string found (Press <i>ctrl</i> or <i>⌘</i> + <i>C</i> to copy the table data<br>to your system clipboard.<br><br>To cancel, click this message or press escape.) - See coding guideline JS5 Untranslatable string found (Copied %d rows to clipboard) - See coding guideline JS5 Untranslatable string found (Copied one row to clipboard) - See coding guideline JS5 Untranslatable string found (Clear filter) - See coding guideline JS5 Untranslatable string found (Clear filter) - See coding guideline JS5 Untranslatable string found (All) - See coding guideline JS5 Untranslatable string found (a an the) - See coding guideline JS5 False positives perhaps. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24662 --- Comment #3 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- See Bug 24664 for missing *-messages-js.po -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24662 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24664 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24664 [Bug 24664] Add missing *-messages-js.po -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24662 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- QA script fixes awaiting merge, but we wanted to get the rmaints to pull in the translation js bug first. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24662 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24662 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98921|0 |1 is obsolete| | --- Comment #5 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 100147 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100147&action=edit Bug 24662: Remove global variables MSG_* from datatables.inc Now that bug 21156 is pushed, we don't need to have global variables in .inc or .tt files for translation in .js file. We can simply declare our translatable strings where they are used. This patch removes all global variables used in DataTables configuration Test plan: 1. cd misc/translator && ./translate update fr-FR 2. Translate strings in misc/tranlator/po/fr-FR-messages-js.po 3. cd misc/translator && ./translate install fr-FR 4. Go to the staff interface, in english, and check that DataTables tables are still working. You should check at least the following pages: - catalogue/detail.pl - circ/circulation.pl - tools/quotes.pl - tools/letter.pl 5. Switch to french and check again DataTables tables, and verify that strings are translated This patch depends on bug 24661 Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Tested using es-ES or de-DE (build compendium, update, translate, install) cd misc/translator msgcat --use-first -o de.po po/de-DE-*.po ./translate update de-DE msgmerge de.po po/de-DE-messages-js.po -o - | msgattrib --no-obsolete -o po/de-DE-messages-js.po ./translate install de-DE DataTables works, and are translated. There are some messages from qa-tools. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24662 --- Comment #6 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- (In reply to Martin Renvoize from comment #4)
QA script fixes awaiting merge, but we wanted to get the rmaints to pull in the translation js bug first.
Ok! It works, so I signed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24662 Bug 24662 depends on bug 24661, which changed state. Bug 24661 Summary: Inclusion of locale-related javascript files is broken https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24661 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24662 Bug 24662 depends on bug 24661, which changed state. Bug 24661 Summary: Inclusion of locale-related javascript files is broken https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24661 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24662 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100147|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 100525 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100525&action=edit Bug 24662: Remove global variables MSG_* from datatables.inc Now that bug 21156 is pushed, we don't need to have global variables in .inc or .tt files for translation in .js file. We can simply declare our translatable strings where they are used. This patch removes all global variables used in DataTables configuration Test plan: 1. cd misc/translator && ./translate update fr-FR 2. Translate strings in misc/tranlator/po/fr-FR-messages-js.po 3. cd misc/translator && ./translate install fr-FR 4. Go to the staff interface, in english, and check that DataTables tables are still working. You should check at least the following pages: - catalogue/detail.pl - circ/circulation.pl - tools/quotes.pl - tools/letter.pl 5. Switch to french and check again DataTables tables, and verify that strings are translated This patch depends on bug 24661 Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24662 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- A nice clarification of the code here.. PQA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24662 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24662 --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24662 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy@bywatersolutions.com --- Comment #10 from Joy Nelson <joy@bywatersolutions.com> --- QA errors when applying to 19.11.x Are these necessary to correct before pushing to 19.11.x branch? FAIL koha-tmpl/intranet-tmpl/prog/js/checkouts.js OK git manipulation FAIL untranslatable_strings Untranslatable string found (Loading... you may continue scanning.) - See coding guideline JS5 FAIL koha-tmpl/intranet-tmpl/prog/js/datatables.js OK git manipulation FAIL untranslatable_strings Untranslatable string found (First) - See coding guideline JS5 Untranslatable string found (Last) - See coding guideline JS5 Untranslatable string found (Next) - See coding guideline JS5 Untranslatable string found (Previous) - See coding guideline JS5 Untranslatable string found (No data available in table) - See coding guideline JS5 Untranslatable string found (Showing _START_ to _END_ of _TOTAL_ entries) - See coding guideline JS5 Untranslatable string found (No entries to show) - See coding guideline JS5 Untranslatable string found ((filtered from _MAX_ total entries)) - See coding guideline JS5 Untranslatable string found (Show _MENU_ entries) - See coding guideline JS5 Untranslatable string found (Loading...) - See coding guideline JS5 Untranslatable string found (Processing...) - See coding guideline JS5 Untranslatable string found (Search:) - See coding guideline JS5 Untranslatable string found (No matching records found) - See coding guideline JS5 Untranslatable string found (Copy to clipboard) - See coding guideline JS5 Untranslatable string found (Press <i>ctrl</i> or <i>⌘</i> + <i>C</i> to copy the table data<br>to your system clipboard.<br><br>To cancel, click this message or press escape.) - See coding guideline JS5 Untranslatable string found (Copied %d rows to clipboard) - See coding guideline JS5 Untranslatable string found (Copied one row to clipboard) - See coding guideline JS5 Untranslatable string found (Clear filter) - See coding guideline JS5 Untranslatable string found (Clear filter) - See coding guideline JS5 Untranslatable string found (All) - See coding guideline JS5 Untranslatable string found (a an the) - See coding guideline JS5 FAIL koha-tmpl/intranet-tmpl/prog/js/letter.js OK git manipulation FAIL untranslatable_strings Untranslatable string found (Loading...) - See coding guideline JS5 FAIL koha-tmpl/intranet-tmpl/prog/js/table_filters.js OK git manipulation FAIL untranslatable_strings Untranslatable string found (Deactivate filters) - See coding guideline JS5 Untranslatable string found (Activate filters) - See coding guideline JS5 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org