[Bug 36109] New: Port default ODUE notice to Template Toolkit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36109 Bug ID: 36109 Summary: Port default ODUE notice to Template Toolkit Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: roadmap_24_05 Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs@lists.koha-community.org Reporter: emily.lamancusa@montgomerycountymd.gov QA Contact: testopia@bugs.koha-community.org Depends on: 17976 Blocks: 15278 Bug 17967 added tests to show how the default ODUE notice at the time could be rendered in Template Toolkit - that patch could be used for reference here. At the time, bug 17976 was filed to add a TT equivalent for <<items.fine>>. That bug is still in NEW status, and TemplateToolkit.t still has the related #FIXME. That may need to be added before updating this notice. Strangely, the current default notice both says "Your library does not charge late fines" and lists the late fine. That contradiction should be corrected too. I'd be inclined to keep the listing of the late fine so it can serve as an example, and remove the sentence about not charging late fines. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15278 [Bug 15278] [Omnibus] Port default slips and notices from bespoke syntax to Template Toolkit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17976 [Bug 17976] TT syntax for notices - Add an equivalence for items.fine -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36109 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #1 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- So, you can get all charges for the checkouts, including overdue charges.. so we could plausibly convert the notice without any other code changes. I'll take a look at creating the template. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36109 --- Comment #2 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Poping this here for reference: [%- USE Price -%] Dear [% borrower.firstname %] [% borrower.surname %], According to our current records, you have items that are overdue.Your library does not charge late fines, but please return or renew them at the branch below as soon as possible. [% branch.branchname %] [% branch.branchaddress1 %] [% branch.branchaddress2 %] [% branch.branchaddress3 %] Phone: [% branch.branchphone %] Fax: [% branch.branchfax %] Email: [% branch.branchemail %] If you have registered a password with the library, and you have a renewal available, you may renew online. If an item becomes more than 30 days overdue, you will be unable to use your library card until the item is returned. The following item(s) is/are currently overdue: [% FOREACH overdue IN overdues %] [%~ SET item = overdue.item ~%] "[% item.biblio.title %]" by [% item.biblio.author %], [% item.itemcallnumber %], Barcode: [% item.barcode %], Fine: [% overdue.overdue_fines.total_outstanding | \$Price %] [% END %] [% FOREACH overdue IN overdues %] [%~ SET item = overdue.item ~%] [% overdue.date_due | \$KohaDates %]\t[% item.biblio.title %]\t[% item.barcode %]\t[% item.biblio.author %]\t[% item.itemnumber %] [% END %] Thank-you for your prompt attention to this matter. [% branch.branchname %] Staff ----------- The above only works with 17976 applied, however you can get almost the same by replacing [% overdue.overdue_fines.total_outstanding | $Price %] with [% overdue.account_lines.total_outstanding | $Price %]. The only difference is that the later will include other related charges, like a rental. ----------- What I'd be really interested in know is what people might like the 'perfect' notice to include.. we have the opportunity to 'upgrade' it here.. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36109 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrewfh@dubcolib.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36109 --- Comment #3 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 172285 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172285&action=edit Bug 36109: Convert sample ODUE notice to TT This is an initial submission to convert the existing <<>> sample notice to TT. We could do more here, like including the due date and making the fines display more clearly optional. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36109 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36109 Ray Delahunty <r.delahunty@arts.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |r.delahunty@arts.ac.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36109 --- Comment #4 from Ray Delahunty <r.delahunty@arts.ac.uk> --- Created attachment 172377 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172377&action=edit Digest with singular / plural dealt with -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36109 --- Comment #5 from Ray Delahunty <r.delahunty@arts.ac.uk> --- (In reply to Martin Renvoize (ashimema) from comment #2) [...]
What I'd be really interested in know is what people might like the 'perfect' notice to include.. we have the opportunity to 'upgrade' it here.. Ah, the 'perfect notice'! We are doing lots of (relatively simple) work to improve our notices. One feature we find useful is the inclusion of the success / error counters in the AUTO_RENEWALS_DGST as it allows us to deal with singular & plural problems. We'd love to see counters available in other notices so we could use them. The screen grab of our DGST email shows how we have used the counters, and shows some other changes we have made (and exposes a puzzle that isn't relevant to the 'perfect notice' discussion).
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36109 --- Comment #6 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- I'm really impressed by what you've achieved there Ray, thanks for the example. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36109 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |RM_priority -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36109 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisette@bywatersolutions.co | |m --- Comment #7 from Lisette Scheer <lisette@bywatersolutions.com> ---
What I'd be really interested in know is what people might like the 'perfect' notice to include.. we have the opportunity to 'upgrade' it here..
I always like to do things like: [% IF branch.branchaddress2 %][% branch.branchaddress2 %][% END %] So there aren't blank lines if there's no branchaddress2. Though I wonder if instead we might want to do a branch-address.inc that does all that logic for you, like with biblio-title.inc and patron_title.inc -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36109 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #8 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> ---
What I'd be really interested in know is what people might like the 'perfect' notice to include.. we have the opportunity to 'upgrade' it here..
Is the perfect notice an HTML one, or no HTML? If I am printing a notice the perfect one fits within my envelope window when I fold it. If its emailed the perfect one includes HTML and is responsive to the device I am looking at it on. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36109 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- The dependencies have been resolved, but time is a bit short with translations now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36109 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com Status|Needs Signoff |Signed Off --- Comment #10 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- (In reply to Emily Lamancusa (emlam) from comment #0)
Strangely, the current default notice both says "Your library does not charge late fines" and lists the late fine. That contradiction should be corrected too. I'd be inclined to keep the listing of the late fine so it can serve as an example, and remove the sentence about not charging late fines.
Thank you! I was just coming here to say this :) I think the current patch looks fine. It simply changes the syntax and the above sentence which is what the bug report is about. The only minor things I would change are the capitalization of "Staff" at the end and the hypen in "Thank-you". But this is not a blocker for me. If we enhance it, I'd like to see Lisette's suggestions of adding IFs to prevent blank lines included, but I wouldn't consider this a blocker either. Also, I never understood why we include the library's address in the middle of the message, before the list of overdue items, which is the most important information IMO. If the patron needs the address, I would put it at the end with the signature. But I don't consider this a blocker either. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36109 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172285|0 |1 is obsolete| | --- Comment #11 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 175673 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175673&action=edit Bug 36109: Convert sample ODUE notice to TT This is an initial submission to convert the existing <<>> sample notice to TT. We could do more here, like including the due date and making the fines display more clearly optional. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36109 --- Comment #12 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 175674 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175674&action=edit Bug 36109: Typo corrections -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36109 --- Comment #13 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- I added a mini patch for the "Thank-you" and "Staff"... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36109 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36109 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175673|0 |1 is obsolete| | --- Comment #14 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 178473 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178473&action=edit Bug 36109: Convert sample ODUE notice to TT This is an initial submission to convert the existing <<>> sample notice to TT. We could do more here, like including the due date and making the fines display more clearly optional. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36109 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175674|0 |1 is obsolete| | --- Comment #15 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 178474 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178474&action=edit Bug 36109: Typo corrections Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36109 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36109 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36109 --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36109 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Port default ODUE notice to |Port default ODUE notice to |Template Toolkit |Template Toolkit syntax -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36109 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|RM_priority, roadmap_24_05 | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36109 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting CC| |fridolin.somers@biblibre.co | |m --- Comment #17 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 24.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36109 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED --- Comment #18 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- The text of the notices are not documented in the manual. I'm closing this as there is nothing to change. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org