[Bug 42093] New: Use the REST API and kohaTable to list and search sysprefs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42093 Bug ID: 42093 Summary: Use the REST API and kohaTable to list and search sysprefs Initiative type: --- Sponsorship --- status: Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff interface Assignee: jonathan.druart@gmail.com Reporter: jonathan.druart@gmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42093 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |41995 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41995 [Bug 41995] Autocomplete for syspref search -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42093 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |41891 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41891 [Bug 41891] Move C4::Context->preferences to a separate package -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42093 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42093 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 195332 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195332&action=edit Bug 42093: Use the REST API and kohaTable to list and search sysprefs The idea is to have one kohaTable per module and search using the REST API TODO * git grep FIXME * test cookieconsent * perfs? * adjust t/db_dependent/check_sysprefs.t * Advertise that syspref's value is now the one from the cache * How to update systempreference_explanations? * POD + unit and e2e tests (!) minor: * highlight also applies on elements outside tbody * remove unecessary rules from preferences.css (?) later: perfs - fetch all and filter client-side? implement and use PUT /sysprefs -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42093 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #195332|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42093 --- Comment #2 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 195335 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195335&action=edit Bug 42093: Use the REST API and kohaTable to list and search sysprefs The idea is to have one kohaTable per module and search using the REST API TODO * git grep FIXME * test cookieconsent * perfs? * adjust t/db_dependent/check_sysprefs.t * Advertise that syspref's value is now the one from the cache * How to update systempreference_explanations? * POD + unit and e2e tests (!) minor: * highlight also applies on elements outside tbody * remove unecessary rules from preferences.css (?) later: perfs - fetch all and filter client-side? implement and use PUT /sysprefs -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42093 --- Comment #3 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 195336 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195336&action=edit Bug 42093: Fix countries Patch from commit 8e16a54 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42093 --- Comment #4 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 195337 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195337&action=edit Bug 42093: Lazy load ChoiceProviders Without the tree under bug 41890 it's not possible to use those modules. They introduce too many circ dependencies "__" is not exported by the Koha::I18N module We need to get rid of them before restoring the `use` statements. We should remove C4::Context dependency from C4::Languages and/or remove C4::Languages::getlangage to a separate module that would not need C4::Context -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42093 --- Comment #5 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 195338 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195338&action=edit Bug 42093: Fix ill-backends Patch from commit 0014c83 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42093 --- Comment #6 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 195339 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195339&action=edit Bug 42093: Fix for localized interface Patch from commit 9b39986 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42093 --- Comment #7 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 195340 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195340&action=edit Bug 42093: Restore 'Local use' TODO Code is duplicated admin/systempreferences.pl and admin/preferences.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42093 --- Comment #8 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 195341 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195341&action=edit Bug 42093: Fix some syspref descriptions Patch from commit 47ea765 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42093 --- Comment #9 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 195342 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195342&action=edit Bug 42093: Add a 'parent' for grouped_prefs Decided to keep the route as it (one entry per syspref) but then we need to deal with the grouping on the UI -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42093 --- Comment #10 from Jonathan Druart <jonathan.druart@gmail.com> --- Patches for feedback, testing and discussion. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42093 Donna <bwsdonna@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bwsdonna@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42093 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisette@bywatersolutions.co | |m --- Comment #11 from Lisette Scheer <lisette@bywatersolutions.com> --- Doing some clicking around and looking at the comments from the thread, here are my notes: I would expect the "View all X preferences" link to clear the filter in the datatable search box. It works as expected if you do a search from the top bar, but if you filter after clicking unto a section, it doesn't. Currently Accounting is automatically loaded when you go to /cgi-bin/koha/admin/preferences.pl and I think retaining that would be good. Highlighting is working nicely Everything isn't collapsed anymore by default I think if we're making changes, having the save button follow you like with saving a patron would be nice. I think a good followup could also be Martin's suggestion from the thread to hide system preferences that only matter if other ones are turned on -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42093 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42093 --- Comment #12 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 195545 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195545&action=edit Bug 42093: Fix race condition when populating the explanation - FIXME This is not ready for QA, we need to discuss how to populate this table correctly, when and where. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42093 --- Comment #13 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 195546 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195546&action=edit Bug 42093: Fix for 'short' Patch from commit 14faf35 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42093 --- Comment #14 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 195547 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195547&action=edit Bug 42093: Correctly handle 'view all' links Patch from commit 6720671 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42093 --- Comment #15 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 195548 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195548&action=edit Bug 42093: Restore sticky toolbar It was correctly display on the first init, but not restored on next ones. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42093 --- Comment #16 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Lisette Scheer from comment #11) Thanks a lot of testing! :)
Doing some clicking around and looking at the comments from the thread, here are my notes:
I would expect the "View all X preferences" link to clear the filter in the datatable search box. It works as expected if you do a search from the top bar, but if you filter after clicking unto a section, it doesn't.
Fixed!
Currently Accounting is automatically loaded when you go to /cgi-bin/koha/admin/preferences.pl and I think retaining that would be good.
We can restore that. I haven't because it triggers a REST API call and the "loading" modal is displayed for a couple (or more) seconds. Waiting for more feedback.
I think if we're making changes, having the save button follow you like with saving a patron would be nice.
Fixed!
I think a good followup could also be Martin's suggestion from the thread to hide system preferences that only matter if other ones are turned on
Yes, definitely. I would like to discuss several things during the hackfest, the current implementation has a lot or FIXMEs that need to be fixed. Then we will be able to iterate on top of it.
From Mattermost: The patches from bug 41891 are not applied with git-bz because of the "in discussion" status. I've pushed a remote branch to ease testing: https://gitlab.com/joubu/Koha/-/commits/bug_42093
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42093 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42093 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #195335|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42093 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #195336|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42093 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #195337|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42093 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #195338|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42093 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #195339|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42093 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #195340|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42093 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #195341|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42093 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #195342|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42093 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #195545|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42093 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #195546|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42093 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #195547|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42093 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #195548|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42093 --- Comment #17 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 196468 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196468&action=edit Bug 42093: Use the REST API and kohaTable to list and search sysprefs The idea is to have one kohaTable per module and search using the REST API TODO * git grep FIXME * test cookieconsent * perfs? * adjust t/db_dependent/check_sysprefs.t * Advertise that syspref's value is now the one from the cache * How to update systempreference_explanations? * POD + unit and e2e tests (!) minor: * highlight also applies on elements outside tbody * remove unecessary rules from preferences.css (?) later: perfs - fetch all and filter client-side? implement and use PUT /sysprefs -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42093 --- Comment #18 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 196469 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196469&action=edit Bug 42093: DBIC changes Patch from commit 04f2431 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42093 --- Comment #19 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 196470 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196470&action=edit Bug 42093: Fix countries Patch from commit f38dae0 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42093 --- Comment #20 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 196471 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196471&action=edit Bug 42093: Lazy load ChoiceProviders Without the tree under bug 41890 it's not possible to use those modules. They introduce too many circ dependencies "__" is not exported by the Koha::I18N module We need to get rid of them before restoring the `use` statements. We should remove C4::Context dependency from C4::Languages and/or remove C4::Languages::getlangage to a separate module that would not need C4::Context -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42093 --- Comment #21 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 196472 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196472&action=edit Bug 42093: Fix ill-backends Patch from commit bfdedbc -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42093 --- Comment #22 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 196473 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196473&action=edit Bug 42093: Fix for localized interface Patch from commit 8920cd2 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42093 --- Comment #23 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 196474 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196474&action=edit Bug 42093: Restore 'Local use' TODO Code is duplicated admin/systempreferences.pl and admin/preferences.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42093 --- Comment #24 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 196475 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196475&action=edit Bug 42093: Fix some syspref descriptions Patch from commit be2c46e -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42093 --- Comment #25 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 196476 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196476&action=edit Bug 42093: Add a 'parent' for grouped_prefs Decided to keep the route as it (one entry per syspref) but then we need to deal with the grouping on the UI -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42093 --- Comment #26 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 196477 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196477&action=edit Bug 42093: Fix race condition when populating the explanation - FIXME This is not ready for QA, we need to discuss how to populate this table correctly, when and where. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42093 --- Comment #27 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 196478 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196478&action=edit Bug 42093: Fix for 'short' Patch from commit 5331727 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42093 --- Comment #28 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 196479 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196479&action=edit Bug 42093: Correctly handle 'view all' links Patch from commit 55223e8 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42093 --- Comment #29 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 196480 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196480&action=edit Bug 42093: Restore sticky toolbar It was correctly display on the first init, but not restored on next ones. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42093 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Use the REST API and |Use the REST API and |kohaTable to list and |kohaTable to list and |search sysprefs |search system preferences -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42093 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com, | |katrin.fischer@bsz-bw.de Status|In Discussion |Needs Signoff --- Comment #30 from Jonathan Druart <jonathan.druart@gmail.com> --- I would like feedback from testers to know if I spend more time to clean the code and make it ready for QA. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42093 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org