[Bug 18135] New: Can submit batch deletion for authorities without selecting any
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18135 Bug ID: 18135 Summary: Can submit batch deletion for authorities without selecting any Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: gmcharlt@gmail.com Reporter: aleishaamohia@hotmail.com QA Contact: testopia@bugs.koha-community.org At the moment, batch deletion for biblios does not let you submit the deletion form without selecting a checkbox - an alert pops up. This behaviour is not the same for authorities. If nothing is selected, the form still submits and says the deletion was successful. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18135 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18135 --- Comment #1 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 60370 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60370&action=edit Bug 18135: Show alert if no authorities selected in batch record deletion To test: 1) Go to Tools -> Batch record deletion 2) Select Authorities as record type, put in an auth id, click Continue 3) Unselect the authorities and click Delete selected records 4) Confirm an alert shows up 5) Clear the alert and confirm deleting the authority still works as normal Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18135 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored Assignee|gmcharlt@gmail.com |aleishaamohia@hotmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18135 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com --- Comment #2 from M. Tompsett <mtompset@hotmail.com> --- Eyeballs well. It's a cut-and-paste tweak of the same code for Biblios. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18135 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18135 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60370|0 |1 is obsolete| | --- Comment #3 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 60591 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60591&action=edit Bug 18135: Show alert if no authorities selected in batch record deletion To test: 1) Go to Tools -> Batch record deletion 2) Select Authorities as record type, put in an auth id, click Continue 3) Unselect the authorities and click Delete selected records 4) Confirm an alert shows up 5) Clear the alert and confirm deleting the authority still works as normal Sponsored-by: Catalyst IT Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18135 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18135 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60591|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 60620 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60620&action=edit Bug 18135: Show alert if no authorities selected in batch record deletion To test: 1) Go to Tools -> Batch record deletion 2) Select Authorities as record type, put in an auth id, click Continue 3) Unselect the authorities and click Delete selected records 4) Confirm an alert shows up 5) Clear the alert and confirm deleting the authority still works as normal Sponsored-by: Catalyst IT Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18135 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 17.05, thanks Aleisha! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18135 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial CC| |katrin.fischer@bsz-bw.de Status|Pushed to Master |Pushed to Stable --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- 'Upping' this to be a bug fix as this fixes the former inconsistent behaviour. This patch has been pushed to 16.11.x and will be in 16.11.05. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org