[Bug 5075] New: Terms not highlighted w/ xslt on
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5075 Summary: Terms not highlighted w/ xslt on Change sponsored?: --- Product: Koha Version: HEAD Platform: All OS/Version: All Status: NEW Severity: normal Priority: P5 Component: OPAC AssignedTo: oleonard@myacpl.org ReportedBy: nengard@gmail.com QAContact: koha-bugs@lists.koha-community.org Estimated Hours: 0.0 Created attachment 2437 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=2437 XSLT & no highlights If you have OPACXSLTResultsDisplay and OpacHighlightedWords turned on the terms on your results are not highlighted. If you turn OPACXSLTResultsDisplay off the terms are highlighed normally. See attached. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5075 --- Comment #1 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 2438 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=2438 same search, no xslt, highlights work -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5075 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 2440 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=2440 Proposed fix - XSLT didn't contain the class markup which acts as a hook for the JavaScript highlighting system. - Standard results page also contained a typo which prevented data other than title and author from being highlighted -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5075 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent Status|NEW |ASSIGNED Version|HEAD |rel_3_2 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5075 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt@gmail.com Version|rel_3_2 |HEAD --- Comment #3 from Galen Charlton <gmcharlt@gmail.com> 2010-10-26 13:28:28 UTC --- (In reply to comment #2)
Created attachment 2440 [details] Proposed fix
- XSLT didn't contain the class markup which acts as a hook for the JavaScript highlighting system. - Standard results page also contained a typo which prevented data other than title and author from being highlighted
This patch has a broader effect than is desirable. For example, try a search on 'a'. Besides the letter 'a' being highlighted in strings coming from the bib records, it is also highlighted elsewhere - i.e., the a's in "Action: Add to Cart", etc. Still, this is getting close. I have pushed this to a topic branch called new/bug5075 in the public repo for further work. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5075 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent |P1 --- Comment #4 from Galen Charlton <gmcharlt@gmail.com> 2010-10-30 12:17:47 UTC --- (In reply to comment #3)
Still, this is getting close. I have pushed this to a topic branch called new/bug5075 in the public repo for further work.
Since new/bug5075 is now in master (merge was premature, IMO), the overzealousness of the search highlighting is now a bit more urgent. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5075 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> 2010-11-01 14:56:05 UTC ---
This patch has a broader effect than is desirable. For example, try a search on 'a'. Besides the letter 'a' being highlighted in strings coming from the bib records, it is also highlighted elsewhere - i.e., the a's in "Action: Add to Cart", etc.
A valid concern, but for the purposes of tracking this particular bug it should be noted that the same is true of the non-XSLT view. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5075 --- Comment #6 from MJ Ray (software.coop) <mjr@ttllp.co.uk> 2010-11-11 13:42:40 UTC --- This bug is mentioned in: Fix for Bug 5075 - Terms not highlighted w/ xslt on http://lists.koha-community.org/pipermail/koha-patches/2010-October/012716.h... -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5075 --- Comment #7 from Chris Nighswonger <cnighswonger@foundations.edu> 2010-11-18 03:15:35 UTC --- This bug has a patch presently committed to HEAD and 3.2.x. Please take the appropriate action to update the status of this bug. Remember, bugs which have been resolved should be tested and marked closed, preferably by the original reporter. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5075 Chris Nighswonger <cnighswonger@foundations.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cnighswonger@foundations.ed | |u --- Comment #8 from Chris Nighswonger <cnighswonger@foundations.edu> 2010-11-30 13:49:39 UTC --- This bug has a fix which was committed to the 3.2.x branch and released in 3.2.1. Please take time to update the status of this bug and mark it RESOLVED FIXED so that it may be closed. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5075 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5075 Chris Nighswonger <cnighswonger@foundations.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org