[Bug 6120] New: Add search links in detail pages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6120 Bug #: 6120 Summary: Add search links in detail pages Classification: Unclassified Change sponsored?: --- Product: Koha Version: rel_3_4 Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P5 Component: OPAC AssignedTo: oleonard@myacpl.org ReportedBy: fridolyn.somers@gmail.com QAContact: koha-bugs@lists.koha-community.org Based on features F10 and F11 developed for Lyon 2 University by Progilone. See http://git.progilone.com/?p=koha-lyon2.git;a=shortlog;h=F10-F11 After a search is performed, add in detail pages 3 links : - Back to results : Leads to current search results page (same index, query and limits). Not shown if search leads directly to a detail page. - Back to simple search : Leads to main page with header filled with current search index, query and limits (like result page). - Back to advanced search : Leads to advanced search page. Also adds 'focus' class to query input field in header. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6120 --- Comment #1 from Fridolyn SOMERS <fridolyn.somers@gmail.com> 2011-04-07 14:22:07 UTC --- Created attachment 3803 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3803 Proposed patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6120 Fridolyn SOMERS <fridolyn.somers@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6120 Fridolyn SOMERS <fridolyn.somers@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #3803|0 |1 is obsolete| | --- Comment #2 from Fridolyn SOMERS <fridolyn.somers@gmail.com> 2011-04-07 15:00:32 UTC --- Created attachment 3808 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3808 Proposed patch (corrected) Recreated patch, a new file was missing. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6120 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Version|rel_3_4 |rel_3_6 Patch Status|--- |Needs Signoff --- Comment #3 from Chris Cormack <chris@bigballofwax.co.nz> 2011-04-07 18:22:27 UTC --- This has missed the feature freeze for 3.4.0 I'm afraid, but once it is signed off it can go into master as soon as the rel_3_4_0 branch is created -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6120 --- Comment #4 from Fridolyn SOMERS <fridolyn.somers@gmail.com> 2011-04-08 15:19:51 UTC --- Created attachment 3842 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3842 Details page view Screen shot of biblio details page -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6120 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr --- Comment #5 from Frédéric Demians <frederic@tamil.fr> 2011-05-13 13:00:02 UTC --- This patch doesn't apply anymore on HEAD. Please rebase it. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6120 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|oleonard@myacpl.org |fridolyn.somers@gmail.com --- Comment #6 from Owen Leonard <oleonard@myacpl.org> 2011-05-13 13:27:35 UTC --- I object to the inclusion of a "back to simple search" link. Does this take you to the home page? There's a simple search form on every page. Aren't we encouraging the user to think that they must return to the home page to perform another quick search? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6120 --- Comment #7 from Fridolyn SOMERS <fridolyn.somers@gmail.com> 2011-05-13 15:01:04 UTC --- (In reply to comment #6)
I object to the inclusion of a "back to simple search" link. Does this take you to the home page? There's a simple search form on every page. Aren't we encouraging the user to think that they must return to the home page to perform another quick search?
Not really, the link leads to home page but with search toolbar filled with previous search. So user can modify or relaunch it. Bu the way, I think your right, it whould be better to fill the current search in details page. So user doesn't need a link to see his current simple search. I'll try work on it soon. Regards, -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6120 Fridolyn SOMERS <fridolyn.somers@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Does not apply -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6120 Fridolyn SOMERS <fridolyn.somers@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #3808|0 |1 is obsolete| | --- Comment #8 from Fridolyn SOMERS <fridolyn.somers@gmail.com> 2011-05-17 17:50:43 UTC --- Created attachment 4150 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4150 Proposed patch (updated) Proposed patch updated for 3.4 (with TT) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6120 Fridolyn SOMERS <fridolyn.somers@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #3842|0 |1 is obsolete| | --- Comment #9 from Fridolyn SOMERS <fridolyn.somers@gmail.com> 2011-05-17 17:51:59 UTC --- Created attachment 4151 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4151 Details page view (updated) Details view page. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6120 Fridolyn SOMERS <fridolyn.somers@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Does not apply |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6120 --- Comment #10 from Fridolyn SOMERS <fridolyn.somers@gmail.com> 2011-05-17 17:58:50 UTC --- I changed the patch and reduced behavior : Only one link appears in actions list to come back to current search results. Simple and advanced search can be relaunched in any page because they are in the header, no link needed. Hope it is better. Thanks for signing-off. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6120 --- Comment #11 from Owen Leonard <oleonard@myacpl.org> 2011-05-17 18:32:10 UTC --- I think this updated patch is a great improvement. I did notice a couple of issues with it: 1. It doesn't remember the sorting options from the advanced search page. If you go "back to results" it will default to a "relevance" sort. 2. If you do a search without a keyword you won't see a "back to results" link on the detail page for any of your results. For instance, a search where the user only checks an itemtype limit or a date limit. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6120 --- Comment #12 from Frédéric Demians <frederic@tamil.fr> 2011-05-17 19:34:12 UTC --- And: 3. If you were on multi-pages result page, and that you were on let say page 5, if you click on Back to results, you are redirected on the first page of the result page not on the 5th. The 'offset' parameter should be saved in session and used to generated Back to results link. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6120 --- Comment #13 from Fridolyn SOMERS <fridolyn.somers@gmail.com> 2011-05-18 08:49:21 UTC --- Ok, So I should store in session the entire search URL ? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6120 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Failed QA -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6120 Fridolyn SOMERS <fridolyn.somers@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #4150|0 |1 is obsolete| | --- Comment #14 from Fridolyn SOMERS <fridolyn.somers@gmail.com> 2011-05-27 13:17:16 UTC --- Created attachment 4276 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4276 Proposed patch (full url) Link leads to results page with all URL parameters : sort_by, ... -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6120 Fridolyn SOMERS <fridolyn.somers@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Failed QA |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6120 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #4276|0 |1 is obsolete| | --- Comment #15 from Frédéric Demians <frederic@tamil.fr> 2011-05-27 17:16:09 UTC --- Created attachment 4285 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4285 Signed-off patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6120 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6120 --- Comment #16 from Frédéric Demians <frederic@tamil.fr> 2011-05-27 17:17:20 UTC --- Thanks Fridolyn. Point 1, 2, 3 are solved with your last patch. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6120 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #4285|0 |1 is obsolete| | --- Comment #17 from Paul Poulain <paul.poulain@biblibre.com> 2011-08-10 10:44:38 UTC --- Created attachment 4925 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4925 proposed patch (passed QA) QA comment * works as announced * nice feature, graphically consistent * no comment on code itself Marking passed QA -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6120 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain@biblibre.com Patch Status|Signed Off |Passed QA -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6120 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=6483 Patch Status|Passed QA |Signed Off --- Comment #18 from Paul Poulain <paul.poulain@biblibre.com> 2011-08-12 07:40:15 UTC --- This patch overlap with bug 6483, that does much more. I remove the "passed QA" status, to avoid this patch being applied and causing problems to 6483. Let's discuss of options we have (here or in koha-devel ?) I think 6483 can be applied and this one discarded. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6120 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com --- Comment #19 from Nicole C. Engard <nengard@gmail.com> 2011-08-12 19:19:05 UTC --- If it matters, I kind of like the look of the patch for bug 6483 better ... -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6120 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|rel_3_6 |Rel_3_8 --- Comment #20 from Paul Poulain <paul.poulain@biblibre.com> 2011-10-24 11:40:14 UTC --- Updating version : This ENH could be in Koha 3.8 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6120 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |DUPLICATE --- Comment #21 from Owen Leonard <oleonard@myacpl.org> 2011-10-24 12:26:48 UTC --- *** This bug has been marked as a duplicate of bug 6483 *** -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org