[Bug 27613] New: Pipe separated online resource links are hard to customize
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27613 Bug ID: 27613 Summary: Pipe separated online resource links are hard to customize Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org In the opac results and detail page multiple 856 online resource links are seperated by a '|', which is added via XSLT. Since they are not wrapped inside any HTML element it can be hard to customize with CSS/JS. If they were instead psuedo elements it would be easier to remove them or style them differently. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27613 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27613 --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 116298 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116298&action=edit Bug 27613: Change pipe seperated online resource links to psuedo elements To test: 1. Have a record with many 856 links 2. Look at the links on both the results and detail pages. 3. Look at the '|' and notice it is outside any HTML element, making it hard to remove. 4. Apply the patch and regenerate the CSS 5. Look at both the pages again and notice that the '|' is now a psuedo element. 6. It should look identical to the way it did without the patch 7. Switch the system pref OPACURLOpenInNewWindow to 'do' and make sure the the links look and function right still. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27613 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27613 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27613 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27613 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116298|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 116328 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116328&action=edit Bug 27613: Change pipe seperated online resource links to psuedo elements To test: 1. Have a record with many 856 links 2. Look at the links on both the results and detail pages. 3. Look at the '|' and notice it is outside any HTML element, making it hard to remove. 4. Apply the patch and regenerate the CSS 5. Look at both the pages again and notice that the '|' is now a psuedo element. 6. It should look identical to the way it did without the patch 7. Switch the system pref OPACURLOpenInNewWindow to 'do' and make sure the the links look and function right still. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27613 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27627 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27627 [Bug 27627] Fix invalid HTMl in OPAC results XSLT: change spans to divs -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27613 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am not completely sure about this one. The existing pattern at the moment would be to use <span class="separator"> | </span>. What is the advantage of the pseudo element? That it can be overwritten using CSS instead of jQuery? I tried to remove the 3rd link out of 4 by using: $("a:contains('Table')").remove(); Sample data: Philippics. I-II / Cicero ; edited by John T. Ramsey. In this case I end up with || and have no idea how to fix that. Previously I would just hide the preceeding one with jQuery as well and that would solve he issue. I am not sure if and how I could do that now. We often get requests for hiding some or highlighting other URLs, so that's a common use case for me. Remember: Our records are created in a union catalog, there are often tons of links, but changing the records locally is not an option as the union catalog is the primary database. I am failing this, because I think if we change it on the detail page, we should really change it in the results list too. And personally I'd really like to know if you can still hide elements in a nice way somehow! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27613 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am not completely sure about this one. The existing pattern at the moment would be to use <span class="separator"> | </span>. What is the advantage of the pseudo element? That it can be overwritten using CSS instead of jQuery? I tried to remove the 3rd link out of 4 by using: $("a:contains('Table')").remove(); Sample data: Philippics. I-II / Cicero ; edited by John T. Ramsey. In this case I end up with || and have no idea how to fix that. Previously I would just hide the preceeding one with jQuery as well and that would solve he issue. I am not sure if and how I could do that now. We often get requests for hiding some or highlighting other URLs, so that's a common use case for me. Remember: Our records are created in a union catalog, there are often tons of links, but changing the records locally is not an option as the union catalog is the primary database. I am failing this, because I think if we change it on the detail page, we should really change it in the results list too. And personally I'd really like to know if you can still hide elements in a nice way somehow! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27613 --- Comment #5 from Lucas Gass <lucas@bywatersolutions.com> --- Cait, 1. This patch does change both the OPAC detail and the OPAC results page. 2. I think we can still easily, even more easily, remove links with jQuery. In your example I would use this: $('a[href="http://www.loc.gov/catdir/toc/cam041/2003273871.html"] ').parent().hide(); // This works for hiding it on both the results and detials. 3. I think to semantically describe the online_resource section as a list of links is good. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27613 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Lucas, I will test it, but meant all the other repeating fields using the existing pattern. I think having 2 ways do to things is not necessarily good, better to agree to switch or keep. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27613 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27613 --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 125742 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125742&action=edit Bug 27613: (follow-up) Modify additional repeating entries for consistency This patch makes further changes to the detail and results XSLT in the OPAC so that previously pipe-separated fields are styled with CSS. The following tags are modified on the detail page: 020 ISBN 022 ISSN 050 LOC classification 060 NLM classification 082 DDC classification 084 Other classification 130/240/730 Uniform titles 246 Other title 336 Content type 337 Media type 338 Carrier type 385 Audience 508 Production credits 583 Action note 586 Awards 655 Genre/Form 700/710/711 Contained works 700/710/711 Related works 770 Supplement 772 Supplement to 856 Online resources These are modified on the results page: 028 Publisher number 246 Other title To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). In order to better see the effect of the CSS change you can add something ike this to your OPACUserCSS system preference: .resource_list li::after { content: "♦"; } View catalog search results and detail pages for records which contain repeated entries from the tag list above. The entries should be separated by "|" without customization, or the symbol from your OPACUserCSS if you specified one. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27613 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eliana@flo.org --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- *** Bug 29176 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27613 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27613 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116328|0 |1 is obsolete| | Attachment #125742|0 |1 is obsolete| | --- Comment #9 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 127453 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127453&action=edit Bug 27613: Change pipe seperated online resource links to psuedo elements To test: 1. Have a record with many 856 links 2. Look at the links on both the results and detail pages. 3. Look at the '|' and notice it is outside any HTML element, making it hard to remove. 4. Apply the patch and regenerate the CSS 5. Look at both the pages again and notice that the '|' is now a psuedo element. 6. It should look identical to the way it did without the patch 7. Switch the system pref OPACURLOpenInNewWindow to 'do' and make sure the the links look and function right still. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27613 --- Comment #10 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 127454 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127454&action=edit Bug 27613: (follow-up) Modify additional repeating entries for consistency This patch makes further changes to the detail and results XSLT in the OPAC so that previously pipe-separated fields are styled with CSS. The following tags are modified on the detail page: 020 ISBN 022 ISSN 050 LOC classification 060 NLM classification 082 DDC classification 084 Other classification 130/240/730 Uniform titles 246 Other title 336 Content type 337 Media type 338 Carrier type 385 Audience 508 Production credits 583 Action note 586 Awards 655 Genre/Form 700/710/711 Contained works 700/710/711 Related works 770 Supplement 772 Supplement to 856 Online resources These are modified on the results page: 028 Publisher number 246 Other title To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). In order to better see the effect of the CSS change you can add something ike this to your OPACUserCSS system preference: .resource_list li::after { content: "♦"; } View catalog search results and detail pages for records which contain repeated entries from the tag list above. The entries should be separated by "|" without customization, or the symbol from your OPACUserCSS if you specified one. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27613 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127453|0 |1 is obsolete| | --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 127542 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127542&action=edit Bug 27613: Change pipe seperated online resource links to psuedo elements To test: 1. Have a record with many 856 links 2. Look at the links on both the results and detail pages. 3. Look at the '|' and notice it is outside any HTML element, making it hard to remove. 4. Apply the patch and regenerate the CSS 5. Look at both the pages again and notice that the '|' is now a psuedo element. 6. It should look identical to the way it did without the patch 7. Switch the system pref OPACURLOpenInNewWindow to 'do' and make sure the the links look and function right still. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27613 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127454|0 |1 is obsolete| | --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 127543 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127543&action=edit Bug 27613: (follow-up) Modify additional repeating entries for consistency This patch makes further changes to the detail and results XSLT in the OPAC so that previously pipe-separated fields are styled with CSS. The following tags are modified on the detail page: 020 ISBN 022 ISSN 050 LOC classification 060 NLM classification 082 DDC classification 084 Other classification 130/240/730 Uniform titles 246 Other title 336 Content type 337 Media type 338 Carrier type 385 Audience 508 Production credits 583 Action note 586 Awards 655 Genre/Form 700/710/711 Contained works 700/710/711 Related works 770 Supplement 772 Supplement to 856 Online resources These are modified on the results page: 028 Publisher number 246 Other title To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). In order to better see the effect of the CSS change you can add something ike this to your OPACUserCSS system preference: .resource_list li::after { content: "♦"; } View catalog search results and detail pages for records which contain repeated entries from the tag list above. The entries should be separated by "|" without customization, or the symbol from your OPACUserCSS if you specified one. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27613 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Needs Signoff |Signed Off --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Looks great to me, signing off. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27613 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Ok, I came around to the change :) Only one question: could we throw in the contributurs/authors list to make this more complete of a change? There might be some more in the Utils file that need attention. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27613 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27613 --- Comment #15 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 128425 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128425&action=edit Bug 27613: (follow-up) add authors and contributors -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27613 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27613 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127542|0 |1 is obsolete| | Attachment #127543|0 |1 is obsolete| | Attachment #128425|0 |1 is obsolete| | --- Comment #16 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 129051 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129051&action=edit Bug 27613: Change pipe seperated online resource links to psuedo elements To test: 1. Have a record with many 856 links 2. Look at the links on both the results and detail pages. 3. Look at the '|' and notice it is outside any HTML element, making it hard to remove. 4. Apply the patch and regenerate the CSS 5. Look at both the pages again and notice that the '|' is now a psuedo element. 6. It should look identical to the way it did without the patch 7. Switch the system pref OPACURLOpenInNewWindow to 'do' and make sure the the links look and function right still. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27613 --- Comment #17 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 129052 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129052&action=edit Bug 27613: (follow-up) Modify additional repeating entries for consistency This patch makes further changes to the detail and results XSLT in the OPAC so that previously pipe-separated fields are styled with CSS. The following tags are modified on the detail page: 020 ISBN 022 ISSN 050 LOC classification 060 NLM classification 082 DDC classification 084 Other classification 130/240/730 Uniform titles 246 Other title 336 Content type 337 Media type 338 Carrier type 385 Audience 508 Production credits 583 Action note 586 Awards 655 Genre/Form 700/710/711 Contained works 700/710/711 Related works 770 Supplement 772 Supplement to 856 Online resources These are modified on the results page: 028 Publisher number 246 Other title To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). In order to better see the effect of the CSS change you can add something ike this to your OPACUserCSS system preference: .resource_list li::after { content: "♦"; } View catalog search results and detail pages for records which contain repeated entries from the tag list above. The entries should be separated by "|" without customization, or the symbol from your OPACUserCSS if you specified one. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27613 --- Comment #18 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 129053 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129053&action=edit Bug 27613: (follow-up) add authors and contributors Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27613 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27613 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129051|0 |1 is obsolete| | --- Comment #19 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 130973 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130973&action=edit Bug 27613: Change pipe seperated online resource links to psuedo elements To test: 1. Have a record with many 856 links 2. Look at the links on both the results and detail pages. 3. Look at the '|' and notice it is outside any HTML element, making it hard to remove. 4. Apply the patch and regenerate the CSS 5. Look at both the pages again and notice that the '|' is now a psuedo element. 6. It should look identical to the way it did without the patch 7. Switch the system pref OPACURLOpenInNewWindow to 'do' and make sure the the links look and function right still. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27613 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129052|0 |1 is obsolete| | --- Comment #20 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 130974 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130974&action=edit Bug 27613: (follow-up) Modify additional repeating entries for consistency This patch makes further changes to the detail and results XSLT in the OPAC so that previously pipe-separated fields are styled with CSS. The following tags are modified on the detail page: 020 ISBN 022 ISSN 050 LOC classification 060 NLM classification 082 DDC classification 084 Other classification 130/240/730 Uniform titles 246 Other title 336 Content type 337 Media type 338 Carrier type 385 Audience 508 Production credits 583 Action note 586 Awards 655 Genre/Form 700/710/711 Contained works 700/710/711 Related works 770 Supplement 772 Supplement to 856 Online resources These are modified on the results page: 028 Publisher number 246 Other title To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). In order to better see the effect of the CSS change you can add something ike this to your OPACUserCSS system preference: .resource_list li::after { content: "♦"; } View catalog search results and detail pages for records which contain repeated entries from the tag list above. The entries should be separated by "|" without customization, or the symbol from your OPACUserCSS if you specified one. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27613 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129053|0 |1 is obsolete| | --- Comment #21 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 130975 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130975&action=edit Bug 27613: (follow-up) add authors and contributors Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27613 --- Comment #22 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Forgot my sign-off lines! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27613 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130973|0 |1 is obsolete| | --- Comment #23 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 130977 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130977&action=edit Bug 27613: Change pipe seperated online resource links to psuedo elements To test: 1. Have a record with many 856 links 2. Look at the links on both the results and detail pages. 3. Look at the '|' and notice it is outside any HTML element, making it hard to remove. 4. Apply the patch and regenerate the CSS 5. Look at both the pages again and notice that the '|' is now a psuedo element. 6. It should look identical to the way it did without the patch 7. Switch the system pref OPACURLOpenInNewWindow to 'do' and make sure the the links look and function right still. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27613 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130974|0 |1 is obsolete| | --- Comment #24 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 130978 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130978&action=edit Bug 27613: (follow-up) Modify additional repeating entries for consistency This patch makes further changes to the detail and results XSLT in the OPAC so that previously pipe-separated fields are styled with CSS. The following tags are modified on the detail page: 020 ISBN 022 ISSN 050 LOC classification 060 NLM classification 082 DDC classification 084 Other classification 130/240/730 Uniform titles 246 Other title 336 Content type 337 Media type 338 Carrier type 385 Audience 508 Production credits 583 Action note 586 Awards 655 Genre/Form 700/710/711 Contained works 700/710/711 Related works 770 Supplement 772 Supplement to 856 Online resources These are modified on the results page: 028 Publisher number 246 Other title To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). In order to better see the effect of the CSS change you can add something ike this to your OPACUserCSS system preference: .resource_list li::after { content: "♦"; } View catalog search results and detail pages for records which contain repeated entries from the tag list above. The entries should be separated by "|" without customization, or the symbol from your OPACUserCSS if you specified one. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27613 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130975|0 |1 is obsolete| | --- Comment #25 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 130979 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130979&action=edit Bug 27613: (follow-up) add authors and contributors Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27613 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Pipe separated online |Pipe separated online |resource links are hard to |resource links are hard to |customize |customize (OPAC) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27613 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30148 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30148 [Bug 30148] Pipe separated online resource links are hard to customize (staff interface) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27613 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27613 --- Comment #26 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27613 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27613 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Pipe separated online |Pipe separated contents on |resource links are hard to |detail pages are hard to |customize (OPAC) |customize (OPAC) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27613 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Pipe separated contents on |Pipe separated contents are |detail pages are hard to |hard to customize (OPAC) |customize (OPAC) | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27613 --- Comment #27 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Fridolin Somers from comment #26)
Pushed to master for 22.05, thanks to everybody involved 🦄
I found some display issues that might be related to this bug: Example in ktd sample database: http://localhost:8080/cgi-bin/koha/opac-detail.pl?biblionumber=70 The label by is 'below' the content that is 'above' it. Could some CSS be missing? I think it looked ok in testing. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27613 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33830 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33830 [Bug 33830] Title and author not on same line anymore -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27613 --- Comment #28 from Fridolin Somers <fridolin.somers@biblibre.com> --- (In reply to Katrin Fischer from comment #27)
I found some display issues that might be related to this bug:
Example in ktd sample database: http://localhost:8080/cgi-bin/koha/opac-detail.pl?biblionumber=70
The label by is 'below' the content that is 'above' it.
Could some CSS be missing? I think it looked ok in testing.
I confirm this is not normal. I've opened Bug 33830. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org