[Bug 38232] New: Materials specified note un-checks Forgive overdue charges box
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38232 Bug ID: 38232 Summary: Materials specified note un-checks Forgive overdue charges box Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: hebah@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com To recreate: FinesMode on, have an item with a materials specified note (952$3). Check in item with 'forgive overdue charge' selected, no materials note, box stays checked. Materials note checkin deselects the box. There have been similar issues with things deselecting a check in box (wrong transfer, bug 36199), and I know materials specified notes can interact with things like since-fixed bug 29671 (materials note items deselecting book drop mode), or current bug 37424 (batch checkout silently failing with materials notes) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38232 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #1 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- I cannot reproduce this in current main. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38232 --- Comment #2 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- One extra step to recreate in main is to make sure `CircConfirmItemParts` is on. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38232 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38232 --- Comment #3 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 174283 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174283&action=edit Bug 38232: Pass exemptfine value into circ-needsconfirmation-modal form To test: 1. FinesMode on 2. CircConfirmItemParts on 3. have an item with a materials specified note (952$3) 4. Check in item with 'forgive overdue charge' selected, no materials note, box stays checked. 5. Check in item with 'forgive overdue charge' selected, with a material note, Materials note checkin deselects the box. 6. APPLY PATCH 7. Try steps 4-5 again, the correct value should be retained in the 'forgive overdue charge' checkbox. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38232 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Severity|enhancement |normal Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38232 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #4 from David Nind <david@davidnind.com> --- How do you get "... 'forgive overdue charge' selected... " to appear when you check the item in? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38232 --- Comment #5 from hebah@bywatersolutions.com --- FinesMode must also be on. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38232 --- Comment #6 from David Nind <david@davidnind.com> --- (In reply to hebah from comment #5)
FinesMode must also be on.
This is what I did (using koha-testing-docker and the sample data): 1. Set system preference finesMode = "Calculate and charge". 2. Set system preference CircConfirmItemParts = "Require". 3. Edited the item for CGI programming with Perl (record number 11), so that it has some text in "3 - Materials specified (bound volume or other part for" (barcode 39999000000498, item number 32). 4. Check out 39999000000498 to Mary Burton, and specified the due date as 1 December 2024 (so it is overdue). 5. Checked the item in: - Only get dialog box with "Please confirm checkin - Please confirm that the accompanying materials are present: [text from 952$3].", with the option of "Yes, checkin (Y) and "No, don't checkin (N)". - "Yes" checks the item in. I don't get the "forgive overdue charge" message, or any other messages. So what needs to be done to make this appear? Add a manual charge, something else? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38232 --- Comment #7 from hebah@bywatersolutions.com --- Ahhh. Bet you need a circ rule with some amount of fines. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38232 --- Comment #8 from hebah@bywatersolutions.com --- And a backdated due date such that it would otherwise accrue them. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38232 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38232 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174283|0 |1 is obsolete| | --- Comment #9 from David Nind <david@davidnind.com> --- Created attachment 175950 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175950&action=edit Bug 38232: Pass exemptfine value into circ-needsconfirmation-modal form To test: 1. FinesMode on 2. CircConfirmItemParts on 3. have an item with a materials specified note (952$3) 4. Check in item with 'forgive overdue charge' selected, no materials note, box stays checked. 5. Check in item with 'forgive overdue charge' selected, with a material note, Materials note checkin deselects the box. 6. APPLY PATCH 7. Try steps 4-5 again, the correct value should be retained in the 'forgive overdue charge' checkbox. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38232 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes the remembering release notes| |of the options when | |checking in items from | |Circulation > Check in > | |options icon in the barcode | |field. | | | |If the "Forgive | |overdue charges" option was | |selected (shown when the | |finesMode system preference | |is set to "Calculate and | |charge"), this selection | |was not remembered after | |checking in an item with a | |materials specified note | |(952$3). --- Comment #10 from David Nind <david@davidnind.com> --- I managed to work out how to replicate the issue (go to Circulation > Check in and select the icon in barcode field to show the options - not from the check in menu item in the header!), and have signed off. While the change works as per the test plan, is this the correct behavour? I understand the rationale for the other options remaining selected after you check in an item - it makes sense to remember these if you have multiple items to check in: - Specify return date (MM/DD/YYYY) - Remember return date for next check in - Book drop mode However, I would have thought that "Forgive overdue charges" would be a more one-off event, and you wouldn't want to remember this for each subsequent check in. I'm sure there is a rationale for remembering the "Forgive overdue charges" option for the current session! Here are my updated testing notes (using KTD): 1. Set system preference finesMode = "Calculate and charge". 2. Set system preference CircConfirmItemParts = "Require". 3. Edit an item so that it has some text in "3 - Materials specified (bound volume or other part for" (I did this for CGI programming with Perl (record number 11), barcode 39999000000498, item number 32). 4. Go to check in an item WITHOUT a material note (952$3), from Circulation > Check in : 4.1. Go to Circulation > Check in (not from the check in menu item in the header!) 4.2. Click the settings icon in the "Enter item barcode" box 4.3. There are now options for: - Specify return date (MM/DD/YYYY) - Remember return date for next check in - Forgive overdue charges - Book drop mode 4.4. Tick the box for "Forgive overdue charges" 4.5. Paste in a barcode (I used 39999000005776) 4.6. Note that "Forgive overdue charges" remains checked. 5. Repeat step 4 for an item WITH a material note (952$3) (I used 39999000000498): 5.1. You get a dialog box with: "Please confirm checkin Please confirm that the accompanying materials are present: [text from 952$3]. Yes, checkin (Y) No, don't checkin (N)" 5.2 Click "Yes". 5.3 Note that the "Forgive overdue charges" option is no longer selected. 6. Apply the patch and go to Circulation > Check in again, and expand the check in options. 7. Repeat steps 4 and 5, the "Forgive overdue charges" option should now remain selected. Additional notes: 1. I didn't really need to set up charging of fines in the circulation rules (for Patron category = All and Item type = All) and running misc/cronjobs/fines.pl to replicate the issue: - Fine amount: 5.00 - Fine charging interval: 5 2. Checking an item in from the header bar (which is what I was doing), doesn't give you the settings icon and a chance to select any of the options. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38232 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38232 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175950|0 |1 is obsolete| | --- Comment #11 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 176365 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176365&action=edit Bug 38232: Pass exemptfine value into circ-needsconfirmation-modal form To test: 1. FinesMode on 2. CircConfirmItemParts on 3. have an item with a materials specified note (952$3) 4. Check in item with 'forgive overdue charge' selected, no materials note, box stays checked. 5. Check in item with 'forgive overdue charge' selected, with a material note, Materials note checkin deselects the box. 6. APPLY PATCH 7. Try steps 4-5 again, the correct value should be retained in the 'forgive overdue charge' checkbox. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38232 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |blawlor@clamsnet.org --- Comment #12 from Brendan Lawlor <blawlor@clamsnet.org> --- This works and passes the qa script. The code makes sense and is implemented the exact same way as in the other modals on the Check in page, the hold-found1, hold-found2 and item-transfer-modal. Nice one, passing QA. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38232 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |blawlor@clamsnet.org |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38232 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Materials specified note |Materials specified note |un-checks Forgive overdue |un-checks 'forgive overdue |charges box |charges' box -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38232 --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Brendan Lawlor from comment #12)
This works and passes the qa script.
The code makes sense and is implemented the exact same way as in the other modals on the Check in page, the hold-found1, hold-found2 and item-transfer-modal.
Nice one, passing QA.
Good job! :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38232 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38232 --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38232 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|25.05.00 |25.05.00,24.11.04 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38232 --- Comment #15 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 24.11.x for 24.11.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38232 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz Status|Pushed to stable |Needs documenting --- Comment #16 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x as it wasn't backported to 24.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38232 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED --- Comment #17 from David Nind <david@davidnind.com> --- Bug fix, no changes to the manual required. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org