[Bug 15992] New: Moving item search fields actions into a drop-down menu
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15992 Bug ID: 15992 Summary: Moving item search fields actions into a drop-down menu Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: aleishaamohia@hotmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Similar to Bug 15932, Bug 13778, Bug 15830, Bug 15952, Bug 15966, Bug 15988, Bug 15989, Bug 15990, Bug 15991 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15992 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15992 --- Comment #1 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 48719 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48719&action=edit Bug 15992: Moving item search fields actions into a drop-down menu To test: 1) Go to Administration -> Item search fields 2) Confirm that the actions 'Edit' and 'Delete' have been moved into a drop-down menu and buttons behave as expected. Sponsored-by: Catalyst IT -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15992 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored Assignee|koha-bugs@lists.koha-commun |aleishaamohia@hotmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15992 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15992 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48719|0 |1 is obsolete| | --- Comment #2 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 48825 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48825&action=edit Bug 15992: Moving item search fields actions into a drop-down menu To test: 1) Go to Administration -> Item search fields 2) Confirm that the actions 'Edit' and 'Delete' have been moved into a drop-down menu and buttons behave as expected. Sponsored-by: Catalyst IT Signed-off-by: Nicole C Engard <nengard@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15992 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15887 CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- You are loosing the confirmation and highlight made on bug 15887. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15992 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15992 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15992 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48825|0 |1 is obsolete| | --- Comment #4 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 48905 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48905&action=edit Bug 15992: Renaming 'Operations' column heading to 'Actions' to be consistent with other Administration tables These actions were already made into buttons so will just make this small string change To test: 1) Go to Admin -> Item search fields 2) Confirm column heading now reads 'Actions' Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15992 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Moving item search fields |Renaming 'Operations' |actions into a drop-down |column heading to 'Actions' |menu | Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15992 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15992 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48905|0 |1 is obsolete| | --- Comment #5 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 48907 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48907&action=edit [SIGNED-OFF] Bug 15992: Renaming 'Operations' column heading to 'Actions' to be consistent with other Administration tables These actions were already made into buttons so will just make this small string change To test: 1) Go to Admin -> Item search fields 2) Confirm column heading now reads 'Actions' Sponsored-by: Catalyst IT NOTE: Trivial string change, screen refresh confirms change. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15992 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Aleisha, seems to be the common way to "named" the actions column: % git grep '<th> </th>' **/*.tt|wc 127 339 13098 % git grep '<th>Actions</th>' **/*.tt|wc 15 33 1485 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15992 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16036 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15992 --- Comment #7 from Aleisha Amohia <aleishaamohia@hotmail.com> --- (In reply to Jonathan Druart from comment #6)
Aleisha, seems to be the common way to "named" the actions column:
% git grep '<th> </th>' **/*.tt|wc 127 339 13098 % git grep '<th>Actions</th>' **/*.tt|wc 15 33 1485
I think it tends to be that when the actions have been moved into a drop down menu, the column gets named because each drop down has Actions on it. But when there is no drop down and it is just buttons like this, the column name should be Actions. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15992 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15992 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48907|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 48989 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48989&action=edit Bug 15992: Renaming 'Operations' column heading to 'Actions' to be consistent with other Administration tables These actions were already made into buttons so will just make this small string change To test: 1) Go to Admin -> Item search fields 2) Confirm column heading now reads 'Actions' Sponsored-by: Catalyst IT NOTE: Trivial string change, screen refresh confirms change. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15992 --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Aleisha Amohia from comment #7)
(In reply to Jonathan Druart from comment #6)
Aleisha, seems to be the common way to "named" the actions column:
% git grep '<th> </th>' **/*.tt|wc 127 339 13098 % git grep '<th>Actions</th>' **/*.tt|wc 15 33 1485
I think it tends to be that when the actions have been moved into a drop down menu, the column gets named because each drop down has Actions on it. But when there is no drop down and it is just buttons like this, the column name should be Actions.
Indeed, it makes sense! Thanks for the clarification :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15992 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan@bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #10 from Brendan Gallagher <brendan@bywatersolutions.com> --- Pushed to Master - Should be in the May 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org