[Bug 30936] New: Reindent authority detail template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30936 Bug ID: 30936 Summary: Reindent authority detail template Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org I propose to reformat the authority detail template in the staff interface (authorities/detail.tt) so that it has consistent spacing and indentation. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30936 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30936 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 135911 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135911&action=edit Bug 30936: Reindent authority detail template This patch updates the authority detail template so that indentation is consistent. To test, apply the patch and go to Authorities. - Locate an authority record and view the detail page. - Everything should look correct, with working numbered tabs. - If the AuthDisplayHierarchy preference is enabled, you should see a collapsible tree of elements in the authority hierarchy. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30936 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 135912 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135912&action=edit Bug 30936: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the page's appearance or functionality. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30936 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30936 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135911|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 136315 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136315&action=edit Bug 30936: Reindent authority detail template This patch updates the authority detail template so that indentation is consistent. To test, apply the patch and go to Authorities. - Locate an authority record and view the detail page. - Everything should look correct, with working numbered tabs. - If the AuthDisplayHierarchy preference is enabled, you should see a collapsible tree of elements in the authority hierarchy. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30936 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135912|0 |1 is obsolete| | --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 136316 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136316&action=edit Bug 30936: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the page's appearance or functionality. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30936 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Reindent authority detail |Reindent authority detail |template |template in staff interface -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30936 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30936 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30936 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136315|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 136318 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136318&action=edit Bug 30936: Reindent authority detail template This patch updates the authority detail template so that indentation is consistent. To test, apply the patch and go to Authorities. - Locate an authority record and view the detail page. - Everything should look correct, with working numbered tabs. - If the AuthDisplayHierarchy preference is enabled, you should see a collapsible tree of elements in the authority hierarchy. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30936 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136316|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 136319 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136319&action=edit Bug 30936: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the page's appearance or functionality. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30936 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30936 --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30936 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00 |22.11.00, 22.05.04 released in| | CC| |lucas@bywatersolutions.com Status|Pushed to master |Pushed to stable --- Comment #8 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 22.05.x for 22.05.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30936 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arthur.suzuki@biblibre.com --- Comment #9 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- conflicts when trying to apply to 21.11.x. please provide backport if needed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30936 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to stable |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org