[Bug 27195] New: Set focus for cursor to city input box when creating new cities
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27195 Bug ID: 27195 Summary: Set focus for cursor to city input box when creating new cities Change sponsored?: --- Product: Koha Version: 20.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: barbara.johnson@bedfordtx.gov QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com When adding a new city on cities.pl you have to click in the city input box, which is a required field, so that you can enter text. It would be more efficient to set the focus for the cursor to always be in the city input box so that you could just begin typing and eliminate an extra click. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27195 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy Component|System Administration |Templates -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27195 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|20.05 |master --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- There are quite a few similar bugs with recent patches that can be used to see how this can be done. Look for "focus", an example would be bug 27192. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27195 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #2 from Aleisha Amohia <aleisha@catalyst.net.nz> --- *** Bug 27456 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27195 Ella <ellawipatene@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |ellawipatene@gmail.com |ity.org | CC| |ellawipatene@gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27195 Ella <ellawipatene@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27195 --- Comment #3 from Ella <ellawipatene@gmail.com> --- Created attachment 115264 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115264&action=edit bug 27195:Set focus for cursor to city input box when creating new cities (Before downloading the patch) 1. Go to administration 2. Go to cities 3. Click on add new city 4. See if the cursor automatically focuses to the first city container (It shouldn't). 5. Apply patch 6. Repeat steps 1-4 7. If the cursor automatically focuses in the first city container, the patch has worked! Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27195 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Hello Ella, The commit message must start with "Bug 27195: ". Also you should try and avoid adding empty lines as it could cause unnecessary conflicts with other patches. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27195 Ella <ellawipatene@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27195 --- Comment #5 from Ella <ellawipatene@gmail.com> --- Created attachment 115350 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115350&action=edit Bug 27195: Set focus for cursor to city input box when creating new cities (Before downloading the patch) 1. Go to administration 2. Go to cities 3. Click on add new city 4. See if the cursor automatically focuses to the first city con Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27195 --- Comment #6 from Ella <ellawipatene@gmail.com> --- Created attachment 115355 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115355&action=edit Bug 27195: Set focus for cursor to city input bo when creating new cities Was removing an empty line in the patch (For testing, do the same tests as above) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27195 Ella <ellawipatene@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115264|0 |1 is obsolete| | Attachment #115350|0 |1 is obsolete| | Attachment #115355|0 |1 is obsolete| | --- Comment #7 from Ella <ellawipatene@gmail.com> --- Created attachment 115360 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115360&action=edit Bug 27195: Set focus for cursor to city input box when creating new cities (Before downloading the patch) 1. Go to administration 2. Go to cities 3. Click on add new city 4. See if the cursor automatically focuses to the first city container (It shouldn't). 5. Apply patch 6. Repeat steps 1-4 7. If the cursor automatically focuses in the first city container, the patch has worked! Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27195 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115360|0 |1 is obsolete| | --- Comment #8 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 115365 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115365&action=edit Bug 27195: Set focus for cursor to city input box when creating new cities (Before downloading the patch) 1. Go to administration 2. Go to cities 3. Click on add new city 4. See if the cursor automatically focuses to the first city container (It shouldn't). 5. Apply patch 6. Repeat steps 1-4 7. If the cursor automatically focuses in the first city container, the patch has worked! Sponsored-by: Catalyst IT Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27195 Barbara Johnson <barbara.johnson@bedfordtx.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27195 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |kyle@bywatersolutions.com |y.org | CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27195 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27195 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115365|0 |1 is obsolete| | --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 115615 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115615&action=edit Bug 27195: Set focus for cursor to city input box when creating new cities (Before downloading the patch) 1. Go to administration 2. Go to cities 3. Click on add new city 4. See if the cursor automatically focuses to the first city container (It shouldn't). 5. Apply patch 6. Repeat steps 1-4 7. If the cursor automatically focuses in the first city container, the patch has worked! Sponsored-by: Catalyst IT Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27195 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Focus must be put using the "focus" class instead. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27195 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27195 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115615|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 139418 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139418&action=edit Bug 27195: Set focus on first input when adding a new city When adding a new city, the focus/cursor should be in the first input field of the form: City To test: * Add a new city in administration > cities - cursur is in no field * Apply patch * Add another new city - cursor is now in the first input field of the form: City https://bugs.koha-community.org/show_bug.cgi?id=27193 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27195 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139418|0 |1 is obsolete| | --- Comment #12 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 139422 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139422&action=edit Bug 27195: Set focus on first input when adding a new city When adding a new city, the focus/cursor should be in the first input field of the form: City To test: * Add a new city in administration > cities - cursur is in no field * Apply patch * Add another new city - cursor is now in the first input field of the form: City https://bugs.koha-community.org/show_bug.cgi?id=27193 Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27195 Barbara Johnson <barbara.johnson@bedfordtx.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27195 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31411 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31411 [Bug 31411] [Omnibus] Set focus to first input field of an add/entry form -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27195 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|ellawipatene@gmail.com |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27195 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27195 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139422|0 |1 is obsolete| | --- Comment #13 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 140732 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140732&action=edit Bug 27195: Set focus on first input when adding a new city When adding a new city, the focus/cursor should be in the first input field of the form: City To test: * Add a new city in administration > cities - cursur is in no field * Apply patch * Add another new city - cursor is now in the first input field of the form: City https://bugs.koha-community.org/show_bug.cgi?id=27193 Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27195 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27195 --- Comment #14 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org