[Bug 21852] New: Add more columns and column configuration to overdues report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21852 Bug ID: 21852 Summary: Add more columns and column configuration to overdues report Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/circ/overdue.pl OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org I propose to add more available columns to the overdues report and column configuration to hide the new columns by default. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21852 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |21837 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21837 [Bug 21837] Overdues report shoudln't set homebranchfilter as holdingbranchfilter -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21852 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21852 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 82550 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82550&action=edit Bug 21852: Add more columns and column configuration to overdues report This patch adds some new columns to the overdue report: Patron category, item home library, item holding library, item type. Adding these columns makes available columns better match the available filter fields in the sidebar form. Column configuration is added to this DataTable, with the new columns defined as hidden by default in order to preserve current functionality. New code has been added to the global DataTables configuration to allow the locally-stored column visibility information to override the default Koha configuration for that table. This lets us take advantage of the "stateSave" option in DataTAbles. This patch also fixes a bug where the home and holding branch template variable names didn't match what was being used in the template for pre-selecting the searched-for value in the sidebar filter menu. To test, apply the patch and go to Circulation -> Overdues. - The list of overdues should look correct, with no new columns shown. - Test the column visibility button, showing the columns which are hidden by default. Confirm that the data in these columns displays correctly. - Show or hide columns in such a way that it doesn't match the default configuration. - Navigate away from this page. - Return to the page. The same set of columns should be visible. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21852 Bug 21852 depends on bug 21837, which changed state. Bug 21837 Summary: Overdues report shoudln't set homebranchfilter as holdingbranchfilter https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21837 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21852 José-Mario Monteiro-Santos <jose-mario.monteiro-santos@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jose-mario.monteiro-santos@ | |inlibro.com Status|Needs Signoff |Patch doesn't apply --- Comment #2 from José-Mario Monteiro-Santos <jose-mario.monteiro-santos@inlibro.com> --- Patch doesn't apply 82550 - Bug 21852: Add more columns and column configuration to overdues report Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 21852: Add more columns and column configuration to overdues report Using index info to reconstruct a base tree... M admin/columns_settings.yml M koha-tmpl/intranet-tmpl/prog/en/modules/circ/overdue.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/circ/overdue.tt Auto-merging admin/columns_settings.yml CONFLICT (content): Merge conflict in admin/columns_settings.yml error: Failed to merge in the changes. Patch failed at 0001 Bug 21852: Add more columns and column configuration to overdues report The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-21852-Add-more-columns-and-column-configuratio-WOKvpz.patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21852 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21852 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82550|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 84281 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84281&action=edit Bug 21852: Add more columns and column configuration to overdues report This patch adds some new columns to the overdue report: Patron category, item home library, item holding library, item type. Adding these columns makes available columns better match the available filter fields in the sidebar form. Column configuration is added to this DataTable, with the new columns defined as hidden by default in order to preserve current functionality. New code has been added to the global DataTables configuration to allow the locally-stored column visibility information to override the default Koha configuration for that table. This lets us take advantage of the "stateSave" option in DataTAbles. This patch also fixes a bug where the home and holding branch template variable names didn't match what was being used in the template for pre-selecting the searched-for value in the sidebar filter menu. To test, apply the patch and go to Circulation -> Overdues. - The list of overdues should look correct, with no new columns shown. - Test the column visibility button, showing the columns which are hidden by default. Confirm that the data in these columns displays correctly. - Show or hide columns in such a way that it doesn't match the default configuration. - Navigate away from this page. - Return to the page. The same set of columns should be visible. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21852 Maryse Simard <maryse.simard@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |maryse.simard@inlibro.com Status|Needs Signoff |Failed QA --- Comment #4 from Maryse Simard <maryse.simard@inlibro.com> --- I followed the test plan and everything works. But I ran into some troubles on the columns settings page (Administration > Configure columns). First, the column names for the table circ-overdues don't appear. Also, on that same page, if I try to save a new column configuration for that table (randomly, because I cannot see the column names), my changes aren't kept. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21852 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21852 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84281|0 |1 is obsolete| | --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 84638 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84638&action=edit Bug 21852: Add more columns and column configuration to overdues report This patch adds some new columns to the overdue report: Patron category, item home library, item holding library, item type. Adding these columns makes available columns better match the available filter fields in the sidebar form. Column configuration is added to this DataTable, with the new columns defined as hidden by default in order to preserve current functionality. New code has been added to the global DataTables configuration to allow the locally-stored column visibility information to override the default Koha configuration for that table. This lets us take advantage of the "stateSave" option in DataTAbles. This patch also fixes a bug where the home and holding branch template variable names didn't match what was being used in the template for pre-selecting the searched-for value in the sidebar filter menu. To test, apply the patch and go to Circulation -> Overdues. - The list of overdues should look correct, with no new columns shown. - Test the column visibility button, showing the columns which are hidden by default. Confirm that the data in these columns displays correctly. - Show or hide columns in such a way that it doesn't match the default configuration. - Navigate away from this page. - Return to the page. The same set of columns should be visible. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21852 --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 84639 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84639&action=edit Bug 21852: (follow-up) Correct columns configuration YAML This patch corrects a parameter name in the columns configuration file. "columnname" was misspelled "columname." To test, apply the patch and restart Plack (or restart_all on kohadevbox). Follow the test plan in the original patch. Important testing note: This patch adds persistence to the column visibility which you select. This means that updating the default column visibility won't necessarily be reflected automatically in the table in question. To confirm that defaults are being loaded one must delete the browser's Local Storage data for that table. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21852 Maryse Simard <maryse.simard@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84638|0 |1 is obsolete| | --- Comment #7 from Maryse Simard <maryse.simard@inlibro.com> --- Created attachment 84648 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84648&action=edit Bug 21852: Add more columns and column configuration to overdues report This patch adds some new columns to the overdue report: Patron category, item home library, item holding library, item type. Adding these columns makes available columns better match the available filter fields in the sidebar form. Column configuration is added to this DataTable, with the new columns defined as hidden by default in order to preserve current functionality. New code has been added to the global DataTables configuration to allow the locally-stored column visibility information to override the default Koha configuration for that table. This lets us take advantage of the "stateSave" option in DataTAbles. This patch also fixes a bug where the home and holding branch template variable names didn't match what was being used in the template for pre-selecting the searched-for value in the sidebar filter menu. To test, apply the patch and go to Circulation -> Overdues. - The list of overdues should look correct, with no new columns shown. - Test the column visibility button, showing the columns which are hidden by default. Confirm that the data in these columns displays correctly. - Show or hide columns in such a way that it doesn't match the default configuration. - Navigate away from this page. - Return to the page. The same set of columns should be visible. Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21852 Maryse Simard <maryse.simard@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21852 Maryse Simard <maryse.simard@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84639|0 |1 is obsolete| | --- Comment #8 from Maryse Simard <maryse.simard@inlibro.com> --- Created attachment 84649 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84649&action=edit Bug 21852: (follow-up) Correct columns configuration YAML This patch corrects a parameter name in the columns configuration file. "columnname" was misspelled "columname." To test, apply the patch and restart Plack (or restart_all on kohadevbox). Follow the test plan in the original patch. Important testing note: This patch adds persistence to the column visibility which you select. This means that updating the default column visibility won't necessarily be reflected automatically in the table in question. To confirm that defaults are being loaded one must delete the browser's Local Storage data for that table. Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21852 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Keywords| |additional_work_needed --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Owen, I am passing QA on this, but can I ask you to please complete the cookie documentation on the wiki according to coding guidelines? https://wiki.koha-community.org/wiki/Use_of_Cookies -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21852 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21852 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84648|0 |1 is obsolete| | --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 84663 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84663&action=edit Bug 21852: Add more columns and column configuration to overdues report This patch adds some new columns to the overdue report: Patron category, item home library, item holding library, item type. Adding these columns makes available columns better match the available filter fields in the sidebar form. Column configuration is added to this DataTable, with the new columns defined as hidden by default in order to preserve current functionality. New code has been added to the global DataTables configuration to allow the locally-stored column visibility information to override the default Koha configuration for that table. This lets us take advantage of the "stateSave" option in DataTAbles. This patch also fixes a bug where the home and holding branch template variable names didn't match what was being used in the template for pre-selecting the searched-for value in the sidebar filter menu. To test, apply the patch and go to Circulation -> Overdues. - The list of overdues should look correct, with no new columns shown. - Test the column visibility button, showing the columns which are hidden by default. Confirm that the data in these columns displays correctly. - Show or hide columns in such a way that it doesn't match the default configuration. - Navigate away from this page. - Return to the page. The same set of columns should be visible. Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21852 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84649|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 84664 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84664&action=edit Bug 21852: (follow-up) Correct columns configuration YAML This patch corrects a parameter name in the columns configuration file. "columnname" was misspelled "columname." To test, apply the patch and restart Plack (or restart_all on kohadevbox). Follow the test plan in the original patch. Important testing note: This patch adds persistence to the column visibility which you select. This means that updating the default column visibility won't necessarily be reflected automatically in the table in question. To confirm that defaults are being loaded one must delete the browser's Local Storage data for that table. Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21852 --- Comment #12 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Katrin Fischer from comment #9)
Hi Owen, I am passing QA on this, but can I ask you to please complete the cookie documentation on the wiki according to coding guidelines?
Done. Let me know if I need to provide more information. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21852 --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Owen Leonard from comment #12)
(In reply to Katrin Fischer from comment #9)
Hi Owen, I am passing QA on this, but can I ask you to please complete the cookie documentation on the wiki according to coding guidelines?
Done. Let me know if I need to provide more information.
Thx! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21852 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion CC| |nick@bywatersolutions.com --- Comment #14 from Nick Clemens <nick@bywatersolutions.com> --- I really really like this, but I kind of want to see the state save on its own bug for highlighting in the release and so we have an example of hwo to do this for many tables - we may also want to add it more broadly upon adding so one table is not inconsistent with others. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21852 --- Comment #15 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 84735 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84735&action=edit Bug 21852: (follow up) Remove persistent DataTables user configuration This patch removes the DataTables function for restoring a user's previous configuration. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21852 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21852 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19282 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19282 [Bug 19282] Add the copy, print and export DataTables buttons on all koha tables -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21852 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22276 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21852 Marjorie Barry-Vila <marjorie.barry-vila@collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@collect | |o.ca -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21852 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed |Academy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21852 Maryse Simard <maryse.simard@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #16 from Maryse Simard <maryse.simard@inlibro.com> --- Patch doesn't apply Applying: Bug 21852: Add more columns and column configuration to overdues report Using index info to reconstruct a base tree... M admin/columns_settings.yml M koha-tmpl/intranet-tmpl/prog/en/modules/circ/overdue.tt M koha-tmpl/intranet-tmpl/prog/js/datatables.js Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/js/datatables.js CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/js/datatables.js Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/circ/overdue.tt Auto-merging admin/columns_settings.yml error: Failed to merge in the changes. Patch failed at 0001 Bug 21852: Add more columns and column configuration to overdues report -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21852 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21852 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84663|0 |1 is obsolete| | Attachment #84664|0 |1 is obsolete| | Attachment #84735|0 |1 is obsolete| | --- Comment #17 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 90269 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90269&action=edit Bug 21852: Add more columns and column configuration to overdues report This patch adds some new columns to the overdue report: Patron category, item home library, item holding library, item type. Adding these columns makes available columns better match the available filter fields in the sidebar form. Column configuration is added to this DataTable, with the new columns defined as hidden by default in order to preserve current functionality. New code has been added to the global DataTables configuration to allow the locally-stored column visibility information to override the default Koha configuration for that table. This lets us take advantage of the "stateSave" option in DataTAbles. This patch also fixes a bug where the home and holding branch template variable names didn't match what was being used in the template for pre-selecting the searched-for value in the sidebar filter menu. To test, apply the patch and go to Circulation -> Overdues. - The list of overdues should look correct, with no new columns shown. - Test the column visibility button, showing the columns which are hidden by default. Confirm that the data in these columns displays correctly. - Show or hide columns in such a way that it doesn't match the default configuration. - Navigate away from this page. - Return to the page. The same set of columns should be visible. Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21852 --- Comment #18 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 90270 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90270&action=edit Bug 21852: (follow-up) Correct columns configuration YAML This patch corrects a parameter name in the columns configuration file. "columnname" was misspelled "columname." To test, apply the patch and restart Plack (or restart_all on kohadevbox). Follow the test plan in the original patch. Important testing note: This patch adds persistence to the column visibility which you select. This means that updating the default column visibility won't necessarily be reflected automatically in the table in question. To confirm that defaults are being loaded one must delete the browser's Local Storage data for that table. Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21852 --- Comment #19 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 90271 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90271&action=edit Bug 21852: (follow up) Remove persistent DataTables user configuration This patch removes the DataTables function for restoring a user's previous configuration. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21852 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #20 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Owen, could you please rebase? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21852 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |23273 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23273 [Bug 23273] Downloading from overdues.pl doesn't use set filters -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21852 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21852 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90269|0 |1 is obsolete| | Attachment #90270|0 |1 is obsolete| | Attachment #90271|0 |1 is obsolete| | --- Comment #21 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 92369 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92369&action=edit Bug 21852: Add more columns and column configuration to overdues report This patch adds some new columns to the overdue report: Patron category, item home library, item holding library, item type. Adding these columns makes available columns better match the available filter fields in the sidebar form. Column configuration is added to this DataTable, with the new columns defined as hidden by default in order to preserve current functionality. New code has been added to the global DataTables configuration to allow the locally-stored column visibility information to override the default Koha configuration for that table. This lets us take advantage of the "stateSave" option in DataTAbles. This patch also fixes a bug where the home and holding branch template variable names didn't match what was being used in the template for pre-selecting the searched-for value in the sidebar filter menu. To test, apply the patch and go to Circulation -> Overdues. - The list of overdues should look correct, with no new columns shown. - Test the column visibility button, showing the columns which are hidden by default. Confirm that the data in these columns displays correctly. - Show or hide columns in such a way that it doesn't match the default configuration. - Navigate away from this page. - Return to the page. The same set of columns should be visible. Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21852 --- Comment #22 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 92370 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92370&action=edit Bug 21852: (follow-up) Correct columns configuration YAML This patch corrects a parameter name in the columns configuration file. "columnname" was misspelled "columname." To test, apply the patch and restart Plack (or restart_all on kohadevbox). Follow the test plan in the original patch. Important testing note: This patch adds persistence to the column visibility which you select. This means that updating the default column visibility won't necessarily be reflected automatically in the table in question. To confirm that defaults are being loaded one must delete the browser's Local Storage data for that table. Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21852 --- Comment #23 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 92371 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92371&action=edit Bug 21852: (follow up) Remove persistent DataTables user configuration This patch removes the DataTables function for restoring a user's previous configuration. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21852 --- Comment #24 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Sorry to ask, but do the test plans of the first 2 patches still apply with the last patch removing persistent DataTables? (By the way...I'd like that) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21852 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92369|0 |1 is obsolete| | --- Comment #25 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 92373 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92373&action=edit Bug 21852: Add more columns and column configuration to overdues report This patch adds some new columns to the overdue report: Patron category, item home library, item holding library, item type. Adding these columns makes available columns better match the available filter fields in the sidebar form. Column configuration is added to this DataTable, with the new columns defined as hidden by default in order to preserve current functionality. New code has been added to the global DataTables configuration to allow the locally-stored column visibility information to override the default Koha configuration for that table. This lets us take advantage of the "stateSave" option in DataTAbles. This patch also fixes a bug where the home and holding branch template variable names didn't match what was being used in the template for pre-selecting the searched-for value in the sidebar filter menu. To test, apply the patch and go to Circulation -> Overdues. - The list of overdues should look correct, with no new columns shown. - Test the column visibility button, showing the columns which are hidden by default. Confirm that the data in these columns displays correctly. - Show or hide columns in such a way that it doesn't match the default configuration. - Navigate away from this page. - Return to the page. The same set of columns should be visible. Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21852 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92370|0 |1 is obsolete| | --- Comment #26 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 92374 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92374&action=edit Bug 21852: (follow-up) Correct columns configuration YAML This patch corrects a parameter name in the columns configuration file. "columnname" was misspelled "columname." To test, apply the patch and restart Plack (or restart_all on kohadevbox). Follow the test plan in the original patch. Important testing note: This patch adds persistence to the column visibility which you select. This means that updating the default column visibility won't necessarily be reflected automatically in the table in question. To confirm that defaults are being loaded one must delete the browser's Local Storage data for that table. Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21852 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92371|0 |1 is obsolete| | --- Comment #27 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 92375 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92375&action=edit Bug 21852: (follow up) Remove persistent DataTables user configuration This patch removes the DataTables function for restoring a user's previous configuration. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21852 --- Comment #28 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Owen, before pushing this I tihnk it would be nice to clarify the commit messages to not give a false impression. I'd also love to see persistency added on a follow-up bug as it's especially annoying here to lose your selection everytime you change your search/filters. Note: Atm this suffers from the same missing filter as the dependency. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21852 --- Comment #29 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Katrin Fischer from comment #28)
before pushing this I tihnk it would be nice to clarify the commit messages to not give a false impression.
Would it be useful for me to squash the patches and revise the commit message? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21852 --- Comment #30 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Owen, I think that would help to clear up the confusion. Should we file a new bug for adding persistance? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21852 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #31 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I wanted to go ahead and squash, but there is a slight conflict with the datatables update I think. I tried to fix it, but failed - can you have a look please? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21852 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21852 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92373|0 |1 is obsolete| | Attachment #92374|0 |1 is obsolete| | Attachment #92375|0 |1 is obsolete| | --- Comment #32 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 92575 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92575&action=edit Bug 21852: Add more columns and column configuration to overdues report This patch adds some new columns to the overdue report: Patron category, item home library, item holding library, item type. Adding these columns makes available columns better match the available filter fields in the sidebar form. Column configuration is added to this DataTable, with the new columns defined as hidden by default in order to preserve current functionality. This patch also fixes a bug where the home and holding branch template variable names didn't match what was being used in the template for pre-selecting the searched-for value in the sidebar filter menu. To test, apply the patch and go to Circulation -> Overdues. - The list of overdues should look correct, with no new columns shown. - Test the column visibility button, showing the columns which are hidden by default. Confirm that the data in these columns displays correctly. - Update the default configuration for this table in Administration -> Configure columns. Confirm that your changes are applied to the overdues report. Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21852 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21852 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92575|0 |1 is obsolete| | --- Comment #33 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 92823 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92823&action=edit Bug 21852: Add more columns and column configuration to overdues report This patch adds some new columns to the overdue report: Patron category, item home library, item holding library, item type. Adding these columns makes available columns better match the available filter fields in the sidebar form. Column configuration is added to this DataTable, with the new columns defined as hidden by default in order to preserve current functionality. This patch also fixes a bug where the home and holding branch template variable names didn't match what was being used in the template for pre-selecting the searched-for value in the sidebar filter menu. To test, apply the patch and go to Circulation -> Overdues. - The list of overdues should look correct, with no new columns shown. - Test the column visibility button, showing the columns which are hidden by default. Confirm that the data in these columns displays correctly. - Update the default configuration for this table in Administration -> Configure columns. Confirm that your changes are applied to the overdues report. Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21852 --- Comment #34 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thx for your patience! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21852 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21852 --- Comment #35 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21852 --- Comment #36 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 13710 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21852 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #37 from David Cook <dcook@prosentient.com.au> --- Sorry to say it but this patch actually makes the overdues report (potentially) inaccurate in terms of libraries. See Bug 26362 for the explanation and upcoming patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21852 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26362 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26362 [Bug 26362] Overdue report shows incorrect branches for patron, holdingbranch, and homebranch -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org