[Bug 8570] New: Add pagination to the Z39.50 results page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8570 Priority: P5 - low Change sponsored?: --- Bug ID: 8570 CC: m.de.rooy@rijksmuseum.nl Assignee: gmcharlt@gmail.com Summary: Add pagination to the Z39.50 results page Severity: enhancement Classification: Unclassified OS: All Reporter: fcapovilla@live.ca Hardware: All Status: NEW Version: rel_3_8 Component: Z39.50 / SRU / OpenSearch Servers Product: Koha Created attachment 11347 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11347&action=edit Add paginations to the Z39.50 search results. When doing Z39.50 searches, a maximum of 20 results are show even if there are a lot more matching results returned by the server. This patch adds some pagination code to the Z39.50 results pages so all results returned by the Z39.50 server can be accessed. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8570 Frédérick Capovilla <fcapovilla@live.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Change sponsored?|--- |Sponsored Assignee|gmcharlt@gmail.com |fcapovilla@live.ca --- Comment #1 from Frédérick Capovilla <fcapovilla@live.ca> --- Patch sponsored by the CCSR ( http://www.ccsr.qc.ca ) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8570 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- *** Bug 5044 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8570 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|rel_3_8 |master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8570 Jane Wagner <jwagner@ptfs.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jwagner@ptfs.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8570 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- I am really happy to see this long-missing feature added, but I'm not so happy to see an entirely new method of offering the user pagination options. Currently we have two primary ways of offering pagination options: The plain link kind (as seen on catalog search results) and the DataTables way. It would be much, much better in my opinion to pick one of these established interface patterns than to introduce a whole new one. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8570 --- Comment #4 from Frédérick Capovilla <fcapovilla@live.ca> --- This feature was made a long time ago and got approved for release to the community by our client recently. There is no doubt using the existing patterns would be the best way to do this, but for now all we have is a working version with it's own pagination method. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8570 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11347|0 |1 is obsolete| | --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 11671 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11671&action=edit [SIGNED-OFF] Bug 8570 - Add pagination to the Z39.50 results page Add paginations to the Z39.50 search results. http://bugs.koha-community.org/show_bug.cgi?id=8570 Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8570 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8570 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8570 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain@biblibre.com --- Comment #6 from Paul Poulain <paul.poulain@biblibre.com> --- QA comment: I'm really annoyed, as Owen is, to see that this patch does not use datatable... It's an improvement expected since a long time OTOH. We have: * Owen = yes * Paul = would prefer no and ask for another patch, that could never be submitted * another one opinion ? PS: "This feature was made a long time ago and got approved for release to the community by our client recently." I think this is a wrong way to do with customers. You should say *before* the contract that everything will be released ASAP. That's how we do at BibLibre, librarians are OK with that. We even put everything on a public git repo before the development is done. If you ask *after*, they will ask their legal advisor, and it will take a long time (but I'm french, maybe it's different in north-america...) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8570 --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- (In reply to comment #6)
* Paul = would prefer no and ask for another patch, that could never be submitted
I get the impression that this implementation is good enough for the original sponsor and that a follow-up is unlikely. I signed off because I think getting this functionality into Koha is important, despite my reservations about the way it was done. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8570 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch --- Comment #8 from Marc Véron <veron@veron.ch> --- Agree with Owen. Marc -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8570 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Version|master |rel_3_8 --- Comment #9 from Paul Poulain <paul.poulain@biblibre.com> --- QA comment * passes koha-qa.pl after fixing some remaining tabs in the code, i've added a follow-up * passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8570 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #10 from Paul Poulain <paul.poulain@biblibre.com> --- Patch pushed to master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8570 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Version|rel_3_8 |rel_3_10 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8570 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org