[Bug 33766] New: Accessibility: Fix ambiguous form-field in opac-auth.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766 Bug ID: 33766 Summary: Accessibility: Fix ambiguous form-field in opac-auth.tt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: matt.blenkinsop@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org The form field for "userid" is called Login. This is confusing for screen readers and has been flagged as non-compliant in an accessibility report carried out for the British Museum. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23003 See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33764, | |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33765 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23003 [Bug 23003] Accessibility improvements -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766 --- Comment #1 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 151416 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151416&action=edit Bug 33766: Fix ambiguous "Login" field This patch changes the use of "Login" to "Username" to assist with screen reading Test plan: 1) On the OPAC homepage, click on Lists in the top left 2) Click Log in to create your own lists 3) The login form should have the first field labelled as Username, not Login -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Matt Blenkinsop from comment #0)
has been flagged as non-compliant in an accessibility report carried out for the British Museum.
What is problematic screen reader behavior? It seems wrong to me that the screen reader should care what name or id the field has as long as it has an associated label. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |matt.blenkinsop@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Laura.escamilla@bywatersolu | |tions.com --- Comment #3 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- (In reply to Owen Leonard from comment #2)
(In reply to Matt Blenkinsop from comment #0)
has been flagged as non-compliant in an accessibility report carried out for the British Museum.
What is problematic screen reader behavior? It seems wrong to me that the screen reader should care what name or id the field has as long as it has an associated label.
It's not so much an issue with the screen reader device, but with the patrons using the device to login into our Opac. Since the field is currently named "Login" it might confuse patrons using the screen reader since they might not understand that it is the "Username" field. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151416|0 |1 is obsolete| | --- Comment #4 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 151427 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151427&action=edit Bug 33766: Fix ambiguous "Login" field This patch changes the use of "Login" to "Username" to assist with screen reading Test plan: 1) On the OPAC homepage, click on Lists in the top left 2) Click Log in to create your own lists 3) The login form should have the first field labelled as Username, not Login Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Sorry, but have to veto here: we picked login on purpose as Koha accepts both, the username and the cardnumber. So login was the best fit we found that was not indicating one or the other only. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766 --- Comment #6 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #5)
Sorry, but have to veto here: we picked login on purpose as Koha accepts both, the username and the cardnumber. So login was the best fit we found that was not indicating one or the other only.
Maybe we can update it to "Login ID"? That way patrons will understand that it's intended to be a username/cardnumber field and not the Login button itself? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- But doesn't the screen reader indicate if something is a link or button? Just wondering because login seems a very common field label. And I worry with login ID people will overthink it. Would be great to get more opinions/eyes on this one. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766 Jonathan Field <jonathan.field@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.field@ptfs-europe. | |com --- Comment #8 from Jonathan Field <jonathan.field@ptfs-europe.com> --- I'll post the full comment from the screen reader assessor: - "Providing a descriptive form field label will allow users to know what information to enter in a form field. Where a series of form fields relate to similar information, the context of the form fields needs to be included in the field description. The form field label should also show how it relates to other items in the form. On the ‘Login’ page there is a form field ambiguously labelled ‘Login’. This labelling does not help the user to understand what information is required. When there are any fields that are not sufficiently labelled it will be very difficult, or impossible for the information to be successfully submitted. All form fields need to be labelled clearly. This will allow a screen reader user to have all the information needed to complete any process. When all form fields are clearly labelled, then it is not only beneficial to the visitor, but also for the site owners; as correct information will get to them." So, to summarise, "Login" is really the action that is happening on this page (we are "logging" into the system), it is ambiguous to the user as to what information to provide in order to initiate the "login". As you say, in order to login, we can use "username or cardnumber" here so maybe we should label as such? As things stand this is a WCAG 2.1 Priority A fail, not even AA. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I see the problem, I just feel there is no easy solution. For us some libraries don't use the cardnumbers (chip cards), but only a username, other only use cardnumbers, others use both. The flexibility of Koha makes it hard to give an accurate description in terms of "one that fits all" Not a native speaker, so not sure if any of these would work: * Login name * User ID Make it super accurate, but preference + template driven to allow one of those options: * Username * Cardnumber * Username/cardnumber -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766 --- Comment #10 from Owen Leonard <oleonard@myacpl.org> --- Perhaps we should say "Username or card number" ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766 --- Comment #11 from Jonathan Field <jonathan.field@ptfs-europe.com> --- Yes, I agree Owen -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766 --- Comment #12 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- *** Bug 33764 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766 --- Comment #13 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- *** Bug 33765 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766 --- Comment #14 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- There are multiple instances of this that need changing once a solution is agreed on, closing the other bugs and will wrap all the changes into this bug once we have a way forward -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766 --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- We have a lot of variations where libraries only use one or the other, but having both on the label reflects what Koha actually does, so we can do that. (Still a fan of the pref idea tho - jQuery'ing your way out of such a change is no fun with lots of languages) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766 claire.hernandez@biblibre.com <claire.hernandez@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |claire.hernandez@biblibre.c | |om -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |adrien.saurat@biblibre.com --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 7867 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.derscheid@lmscloud.de --- Comment #17 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Any suggestions on the pref name? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766 --- Comment #18 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Decision reached: OPACLoginLabelTextContent -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151427|0 |1 is obsolete| | --- Comment #19 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 154566 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154566&action=edit Bug 33766: Fix ambiguous "Login" field This patch introduces a new syspref 'OPACLoginLabelTextContent' which can be set to the following values - Cardnumber - Username - Cardnumber or Username To test: - Check that the label for - The masthead inc - The opac-auth template - The opac-main template - The opac-password-recovery template - The opac-registration-confirmation template - The opac-reset-password template - The sco-main template reflect the changes you made to the syspref -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766 --- Comment #20 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Just noticed that this is not translatable in this way. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154566|0 |1 is obsolete| | --- Comment #21 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 154567 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154567&action=edit Bug 33766: Fix ambiguous "Login" field This patch introduces a new syspref 'OPACLoginLabelTextContent' which can be set to the following values - Cardnumber - Username - Cardnumber or Username To test: - Check that the label for - The masthead inc - The opac-auth template - The opac-main template - The opac-password-recovery template - The opac-registration-confirmation template - The opac-reset-password template - The sco-main template reflect the changes you made to the syspref Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #22 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Didn't see your comment before SO! Changing back to NSO -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766 --- Comment #23 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 154570 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154570&action=edit Bug 33766: (follow-up) Fix ambiguous "Login" field This follow-up fixes some problems w/ the unconventional parts of the first commit. We now use conditionals in a BLOCK to map the selected value from the preference to string representations which should now be easily translatable. To test: - Check that the label for - The masthead inc - The opac-auth template - The opac-main template - The opac-password-recovery template - The opac-registration-confirmation template - The opac-reset-password template - The sco-main template reflect the changes you made to the syspref -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766 --- Comment #24 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- I think it needs to be sentence case i.e. "Cardnumber or username" rather than "Cardnumber or Username" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154567|0 |1 is obsolete| | --- Comment #25 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 155017 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155017&action=edit Bug 33766: Fix ambiguous "Login" field This patch introduces a new syspref 'OPACLoginLabelTextContent' which can be set to the following values - Cardnumber - Username - Cardnumber or Username To test: - Check that the label for - The masthead inc - The opac-auth template - The opac-main template - The opac-password-recovery template - The opac-registration-confirmation template - The opac-reset-password template - The sco-main template reflect the changes you made to the syspref Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154570|0 |1 is obsolete| | --- Comment #26 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 155018 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155018&action=edit Bug 33766: (follow-up) Fix ambiguous "Login" field This follow-up fixes some problems w/ the unconventional parts of the first commit. We now use conditionals in a BLOCK to map the selected value from the preference to string representations which should now be easily translatable. To test: - Check that the label for - The masthead inc - The opac-auth template - The opac-main template - The opac-password-recovery template - The opac-registration-confirmation template - The opac-reset-password template - The sco-main template reflect the changes you made to the syspref Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766 --- Comment #27 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 155019 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155019&action=edit Bug 33766: (sign-off follow-up) Fix sentence case "Cardnumber or Username" is now "Cardnumber or username" Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155017|0 |1 is obsolete| | Attachment #155018|0 |1 is obsolete| | Attachment #155019|0 |1 is obsolete| | --- Comment #28 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 155022 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155022&action=edit Bug 33766: Fix ambiguous "Login" field This patch introduces a new syspref 'OPACLoginLabelTextContent' which can be set to the following values - Cardnumber - Username - Cardnumber or Username To test: - Check that the label for - The masthead inc - The opac-auth template - The opac-main template - The opac-password-recovery template - The opac-registration-confirmation template - The opac-reset-password template - The sco-main template reflect the changes you made to the syspref Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766 --- Comment #29 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 155023 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155023&action=edit Bug 33766: (follow-up) Fix ambiguous "Login" field This follow-up fixes some problems w/ the unconventional parts of the first commit. We now use conditionals in a BLOCK to map the selected value from the preference to string representations which should now be easily translatable. To test: - Check that the label for - The masthead inc - The opac-auth template - The opac-main template - The opac-password-recovery template - The opac-registration-confirmation template - The opac-reset-password template - The sco-main template reflect the changes you made to the syspref Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766 --- Comment #30 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 155024 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155024&action=edit Bug 33766: (sign-off follow-up) Fix sentence case "Cardnumber or Username" is now "Cardnumber or username" Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766 --- Comment #31 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 155025 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155025&action=edit Bug 33766: (follow-up) Enable translation for strings In my test the strings inside a SET directive were not picked up for translation. This patch adds the t() function around the new strings in order to allow them to be translated. To test, apply the patch and test the translation process for any language, in this example fr-FR: - Run 'perl translate update fr-FR' - Open misc/translator/po/fr-FR-messages.po - Look for the affected strings: "Username", "Cardnumber", and "Cardnumber or username." - Update the po file with translations of the strings - Run 'perl translate install fr-FR' - View the OPAC in your translated language and test each setting of OPACLoginLabelTextContent to confirm that the translated strings appear. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766 --- Comment #32 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 155026 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155026&action=edit Bug 33766: (follow-up) Change "cardnumber" to "card number" "Cardnumber' isn't really a word, and I think it comes off as librarian-speak. This patch updates it to "Card number" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |michaela.sieber@kit.edu -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #33 from Lucas Gass <lucas@bywatersolutions.com> --- It looks like there are now some merge conflicts with html_helpers.inc -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155022|0 |1 is obsolete| | Attachment #155023|0 |1 is obsolete| | Attachment #155024|0 |1 is obsolete| | Attachment #155025|0 |1 is obsolete| | Attachment #155026|0 |1 is obsolete| | --- Comment #34 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 157854 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157854&action=edit Bug 33766: Fix ambiguous "Login" field This patch introduces a new syspref 'OPACLoginLabelTextContent' which can be set to the following values - Cardnumber - Username - Cardnumber or Username To test: - Check that the label for - The masthead inc - The opac-auth template - The opac-main template - The opac-password-recovery template - The opac-registration-confirmation template - The opac-reset-password template - The sco-main template reflect the changes you made to the syspref Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766 --- Comment #35 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 157855 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157855&action=edit Bug 33766: (follow-up) Fix ambiguous "Login" field This follow-up fixes some problems w/ the unconventional parts of the first commit. We now use conditionals in a BLOCK to map the selected value from the preference to string representations which should now be easily translatable. To test: - Check that the label for - The masthead inc - The opac-auth template - The opac-main template - The opac-password-recovery template - The opac-registration-confirmation template - The opac-reset-password template - The sco-main template reflect the changes you made to the syspref Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766 --- Comment #36 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 157856 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157856&action=edit Bug 33766: (sign-off follow-up) Fix sentence case "Cardnumber or Username" is now "Cardnumber or username" Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766 --- Comment #37 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 157857 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157857&action=edit Bug 33766: (follow-up) Enable translation for strings In my test the strings inside a SET directive were not picked up for translation. This patch adds the t() function around the new strings in order to allow them to be translated. To test, apply the patch and test the translation process for any language, in this example fr-FR: - Run 'perl translate update fr-FR' - Open misc/translator/po/fr-FR-messages.po - Look for the affected strings: "Username", "Cardnumber", and "Cardnumber or username." - Update the po file with translations of the strings - Run 'perl translate install fr-FR' - View the OPAC in your translated language and test each setting of OPACLoginLabelTextContent to confirm that the translated strings appear. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766 --- Comment #38 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 157858 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157858&action=edit Bug 33766: (follow-up) Change "cardnumber" to "card number" "Cardnumber' isn't really a word, and I think it comes off as librarian-speak. This patch updates it to "Card number" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #39 from Lucas Gass <lucas@bywatersolutions.com> --- I found 2 issues here: 1. There is now a space between the text and the colon. Card number or username : 2. I notices that on opac-auth, I do not see the translated string and instead only get a colon. If I add [% PROCESS 'i18n.inc' %] it seems to fix that. However, since I can use the modal login on any page, I find a lot of pages where we do not do so. Can we add [% PROCESS 'i18n.inc' %] inside the block in html_helpers? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766 --- Comment #40 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 159342 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159342&action=edit Bug 33766: Fix whitespace and add i18n to helper block -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #41 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Looks like some whitespace was being added either side of the string. I've removed it and added the i18n block to the helper block -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157854|0 |1 is obsolete| | Attachment #157855|0 |1 is obsolete| | Attachment #157856|0 |1 is obsolete| | Attachment #157857|0 |1 is obsolete| | Attachment #157858|0 |1 is obsolete| | Attachment #159342|0 |1 is obsolete| | --- Comment #42 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 159546 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159546&action=edit Bug 33766: Fix ambiguous "Login" field This patch introduces a new syspref 'OPACLoginLabelTextContent' which can be set to the following values - Cardnumber - Username - Cardnumber or Username To test: - Check that the label for - The masthead inc - The opac-auth template - The opac-main template - The opac-password-recovery template - The opac-registration-confirmation template - The opac-reset-password template - The sco-main template reflect the changes you made to the syspref Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766 --- Comment #43 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 159547 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159547&action=edit Bug 33766: (follow-up) Fix ambiguous "Login" field This follow-up fixes some problems w/ the unconventional parts of the first commit. We now use conditionals in a BLOCK to map the selected value from the preference to string representations which should now be easily translatable. To test: - Check that the label for - The masthead inc - The opac-auth template - The opac-main template - The opac-password-recovery template - The opac-registration-confirmation template - The opac-reset-password template - The sco-main template reflect the changes you made to the syspref Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766 --- Comment #44 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 159548 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159548&action=edit Bug 33766: (sign-off follow-up) Fix sentence case "Cardnumber or Username" is now "Cardnumber or username" Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766 --- Comment #45 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 159549 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159549&action=edit Bug 33766: (follow-up) Enable translation for strings In my test the strings inside a SET directive were not picked up for translation. This patch adds the t() function around the new strings in order to allow them to be translated. To test, apply the patch and test the translation process for any language, in this example fr-FR: - Run 'perl translate update fr-FR' - Open misc/translator/po/fr-FR-messages.po - Look for the affected strings: "Username", "Cardnumber", and "Cardnumber or username." - Update the po file with translations of the strings - Run 'perl translate install fr-FR' - View the OPAC in your translated language and test each setting of OPACLoginLabelTextContent to confirm that the translated strings appear. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766 --- Comment #46 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 159550 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159550&action=edit Bug 33766: (follow-up) Change "cardnumber" to "card number" "Cardnumber' isn't really a word, and I think it comes off as librarian-speak. This patch updates it to "Card number" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766 Phan Tung Bui <phan-tung.bui@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |phan-tung.bui@inlibro.com Status|Needs Signoff |Failed QA --- Comment #47 from Phan Tung Bui <phan-tung.bui@inlibro.com> --- When i enter an incorrect username or password on the opac-user pl pages then click on log-in, instead of seeing the expected information like your username or card number, you only see a colon ":". -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766 --- Comment #48 from Owen Leonard <oleonard@myacpl.org> --- html_helpers.inc defines a variable, preference_value, with the contents of the OPACLoginLabelTextContent system preference. This variable seems to be available everywhere but on the login screen (opac-auth.tt). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766 claire.hernandez@biblibre.com <claire.hernandez@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com, | |matt.blenkinsop@ptfs-europe | |.com, oleonard@myacpl.org Component|Templates |Accessibility -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159546|0 |1 is obsolete| | Attachment #159547|0 |1 is obsolete| | Attachment #159548|0 |1 is obsolete| | Attachment #159549|0 |1 is obsolete| | Attachment #159550|0 |1 is obsolete| | --- Comment #49 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 168600 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168600&action=edit Bug 33766: Fix ambiguous "Login" field This patch introduces a new syspref 'OPACLoginLabelTextContent' which can be set to the following values - Cardnumber - Username - Cardnumber or Username To test: - Check that the label for - The masthead inc - The opac-auth template - The opac-main template - The opac-password-recovery template - The opac-registration-confirmation template - The opac-reset-password template - The sco-main template reflect the changes you made to the syspref Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766 --- Comment #50 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 168601 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168601&action=edit Bug 33766: (follow-up) Fix ambiguous "Login" field This follow-up fixes some problems w/ the unconventional parts of the first commit. We now use conditionals in a BLOCK to map the selected value from the preference to string representations which should now be easily translatable. To test: - Check that the label for - The masthead inc - The opac-auth template - The opac-main template - The opac-password-recovery template - The opac-registration-confirmation template - The opac-reset-password template - The sco-main template reflect the changes you made to the syspref Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766 --- Comment #51 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 168602 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168602&action=edit Bug 33766: (sign-off follow-up) Fix sentence case "Cardnumber or Username" is now "Cardnumber or username" Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766 --- Comment #52 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 168603 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168603&action=edit Bug 33766: (follow-up) Enable translation for strings In my test the strings inside a SET directive were not picked up for translation. This patch adds the t() function around the new strings in order to allow them to be translated. To test, apply the patch and test the translation process for any language, in this example fr-FR: - Run 'perl translate update fr-FR' - Open misc/translator/po/fr-FR-messages.po - Look for the affected strings: "Username", "Cardnumber", and "Cardnumber or username." - Update the po file with translations of the strings - Run 'perl translate install fr-FR' - View the OPAC in your translated language and test each setting of OPACLoginLabelTextContent to confirm that the translated strings appear. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766 --- Comment #53 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 168604 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168604&action=edit Bug 33766: (follow-up) Change "cardnumber" to "card number" "Cardnumber' isn't really a word, and I think it comes off as librarian-speak. This patch updates it to "Card number" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766 --- Comment #54 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 168605 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168605&action=edit Bug 33766: (follow-up) Enable use of translation functions in html_helpers.inc -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766 Jan Kissig <bibliothek@th-wildau.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bibliothek@th-wildau.de --- Comment #55 from Jan Kissig <bibliothek@th-wildau.de> --- (In reply to Owen Leonard from comment #52)
Created attachment 168603 [details] [review] Bug 33766: (follow-up) Enable translation for strings
In my test the strings inside a SET directive were not picked up for translation. This patch adds the t() function around the new strings in order to allow them to be translated.
To test, apply the patch and test the translation process for any language, in this example fr-FR:
- Run 'perl translate update fr-FR' - Open misc/translator/po/fr-FR-messages.po - Look for the affected strings: "Username", "Cardnumber", and "Cardnumber or username." - Update the po file with translations of the strings - Run 'perl translate install fr-FR' - View the OPAC in your translated language and test each setting of OPACLoginLabelTextContent to confirm that the translated strings appear.
I am trying on ktd but I get stuck on
- Look for the affected strings: "Username", "Cardnumber", and "Cardnumber or username."
It is not found inside that file. Also checked for "Card umber or username." As I understand the specific string should be picked up automatically by calling "perl translate update fr-FR"? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766 Amit Gupta <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |amit.gupta@informaticsgloba | |l.com, | |amitddng135@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168600|0 |1 is obsolete| | --- Comment #56 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 173757 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173757&action=edit Bug 33766: Fix ambiguous "Login" field This patch introduces a new syspref 'OPACLoginLabelTextContent' which can be set to the following values - Cardnumber - Username - Cardnumber or Username To test: - Check that the label for - The masthead inc - The opac-auth template - The opac-main template - The opac-password-recovery template - The opac-registration-confirmation template - The opac-reset-password template - The sco-main template reflect the changes you made to the syspref Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168601|0 |1 is obsolete| | --- Comment #57 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 173758 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173758&action=edit Bug 33766: (follow-up) Fix ambiguous "Login" field This follow-up fixes some problems w/ the unconventional parts of the first commit. We now use conditionals in a BLOCK to map the selected value from the preference to string representations which should now be easily translatable. To test: - Check that the label for - The masthead inc - The opac-auth template - The opac-main template - The opac-password-recovery template - The opac-registration-confirmation template - The opac-reset-password template - The sco-main template reflect the changes you made to the syspref Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168602|0 |1 is obsolete| | --- Comment #58 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 173759 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173759&action=edit Bug 33766: (sign-off follow-up) Fix sentence case "Cardnumber or Username" is now "Cardnumber or username" Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168603|0 |1 is obsolete| | --- Comment #59 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 173760 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173760&action=edit Bug 33766: (follow-up) Enable translation for strings In my test the strings inside a SET directive were not picked up for translation. This patch adds the t() function around the new strings in order to allow them to be translated. To test, apply the patch and test the translation process for any language, in this example fr-FR: - Run 'perl translate update fr-FR' - Open misc/translator/po/fr-FR-messages.po - Look for the affected strings: "Username", "Cardnumber", and "Cardnumber or username." - Update the po file with translations of the strings - Run 'perl translate install fr-FR' - View the OPAC in your translated language and test each setting of OPACLoginLabelTextContent to confirm that the translated strings appear. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168604|0 |1 is obsolete| | --- Comment #60 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 173761 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173761&action=edit Bug 33766: (follow-up) Change "cardnumber" to "card number" "Cardnumber' isn't really a word, and I think it comes off as librarian-speak. This patch updates it to "Card number" Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168605|0 |1 is obsolete| | --- Comment #61 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 173762 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173762&action=edit Bug 33766: (follow-up) Enable use of translation functions in html_helpers.inc Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766 --- Comment #62 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- A rebase and a signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173757|0 |1 is obsolete| | Attachment #173758|0 |1 is obsolete| | Attachment #173759|0 |1 is obsolete| | Attachment #173760|0 |1 is obsolete| | Attachment #173761|0 |1 is obsolete| | Attachment #173762|0 |1 is obsolete| | --- Comment #63 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 173972 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173972&action=edit Bug 33766: Fix ambiguous "Login" field This patch introduces a new syspref 'OPACLoginLabelTextContent' which can be set to the following values - Cardnumber - Username - Cardnumber or Username To test: - Check that the label for - The masthead inc - The opac-auth template - The opac-main template - The opac-password-recovery template - The opac-registration-confirmation template - The opac-reset-password template - The sco-main template reflect the changes you made to the syspref Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766 --- Comment #64 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 173973 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173973&action=edit Bug 33766: (follow-up) Fix ambiguous "Login" field This follow-up fixes some problems w/ the unconventional parts of the first commit. We now use conditionals in a BLOCK to map the selected value from the preference to string representations which should now be easily translatable. To test: - Check that the label for - The masthead inc - The opac-auth template - The opac-main template - The opac-password-recovery template - The opac-registration-confirmation template - The opac-reset-password template - The sco-main template reflect the changes you made to the syspref Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766 --- Comment #65 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 173974 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173974&action=edit Bug 33766: (sign-off follow-up) Fix sentence case "Cardnumber or Username" is now "Cardnumber or username" Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766 --- Comment #66 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 173975 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173975&action=edit Bug 33766: (follow-up) Enable translation for strings In my test the strings inside a SET directive were not picked up for translation. This patch adds the t() function around the new strings in order to allow them to be translated. To test, apply the patch and test the translation process for any language, in this example fr-FR: - Run 'perl translate update fr-FR' - Open misc/translator/po/fr-FR-messages.po - Look for the affected strings: "Username", "Cardnumber", and "Cardnumber or username." - Update the po file with translations of the strings - Run 'perl translate install fr-FR' - View the OPAC in your translated language and test each setting of OPACLoginLabelTextContent to confirm that the translated strings appear. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766 --- Comment #67 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 173976 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173976&action=edit Bug 33766: (follow-up) Change "cardnumber" to "card number" "Cardnumber' isn't really a word, and I think it comes off as librarian-speak. This patch updates it to "Card number" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766 --- Comment #68 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 173977 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173977&action=edit Bug 33766: (follow-up) Enable use of translation functions in html_helpers.inc -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173972|0 |1 is obsolete| | --- Comment #69 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 174037 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174037&action=edit Bug 33766: Fix ambiguous "Login" field This patch introduces a new syspref 'OPACLoginLabelTextContent' which can be set to the following values - Cardnumber - Username - Cardnumber or Username To test: - Check that the label for - The masthead inc - The opac-auth template - The opac-main template - The opac-password-recovery template - The opac-registration-confirmation template - The opac-reset-password template - The sco-main template reflect the changes you made to the syspref Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173973|0 |1 is obsolete| | --- Comment #70 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 174038 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174038&action=edit Bug 33766: (follow-up) Fix ambiguous "Login" field This follow-up fixes some problems w/ the unconventional parts of the first commit. We now use conditionals in a BLOCK to map the selected value from the preference to string representations which should now be easily translatable. To test: - Check that the label for - The masthead inc - The opac-auth template - The opac-main template - The opac-password-recovery template - The opac-registration-confirmation template - The opac-reset-password template - The sco-main template reflect the changes you made to the syspref Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173974|0 |1 is obsolete| | --- Comment #71 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 174039 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174039&action=edit Bug 33766: (sign-off follow-up) Fix sentence case "Cardnumber or Username" is now "Cardnumber or username" Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173975|0 |1 is obsolete| | --- Comment #72 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 174040 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174040&action=edit Bug 33766: (follow-up) Enable translation for strings In my test the strings inside a SET directive were not picked up for translation. This patch adds the t() function around the new strings in order to allow them to be translated. To test, apply the patch and test the translation process for any language, in this example fr-FR: - Run 'perl translate update fr-FR' - Open misc/translator/po/fr-FR-messages.po - Look for the affected strings: "Username", "Cardnumber", and "Cardnumber or username." - Update the po file with translations of the strings - Run 'perl translate install fr-FR' - View the OPAC in your translated language and test each setting of OPACLoginLabelTextContent to confirm that the translated strings appear. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173976|0 |1 is obsolete| | --- Comment #73 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 174041 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174041&action=edit Bug 33766: (follow-up) Change "cardnumber" to "card number" "Cardnumber' isn't really a word, and I think it comes off as librarian-speak. This patch updates it to "Card number" Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173977|0 |1 is obsolete| | --- Comment #74 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 174042 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174042&action=edit Bug 33766: (follow-up) Enable use of translation functions in html_helpers.inc Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|martin.renvoize@ptfs-europe |lucas@bywatersolutions.com |.com | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Accessibility: Fix |Accessibility: Fix |ambiguous form-field in |ambiguous form field in |opac-auth.tt |OPAC login form -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766 --- Comment #75 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- 1) Database update - We had cardnumber in one and Cardnumber in the other. Fixed in follow-up. - I decided to set cardnumberorusername as default for updating installations as it seemed less disruptive. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766 --- Comment #76 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed --- Comment #77 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This comes with a new system preference and a change to existing installations, I think a short note would still make sense. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | Text to go in the| |This adds the new system release notes| |preference | |`OPACLoginLabelTextContent` | |that allows to control the | |text displayed on the login | |form. Available options | |are: | | | |- card number | |- card | |number or username | |- | |username Summary|Accessibility: Fix |Fix ambiguous form field in |ambiguous form field in |OPAC login form |OPAC login form | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766 Aude Charillon <aude.charillon@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |Aude Charillon contact| | Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/1014 CC| |aude.charillon@ptfs-europe. | |com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766 Aude Charillon <aude.charillon@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #78 from Aude Charillon <aude.charillon@openfifth.co.uk> --- Added to the Manual. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org