[Bug 37715] New: It should be possible to enable/disable each authentication method on the OPAC and staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37715 Bug ID: 37715 Summary: It should be possible to enable/disable each authentication method on the OPAC and staff client Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org When setting up identity provides (OAuth/OpenID) you can enable or disable the provider for the OPAC/Staff client We have the preferences OPACShibOnly and staffShibOnly which will limit everything to Shib It would be nice to instead have a switch for each: OpacEnableLocalLogin OpacEnableCASLogin OpacEnableShibLogin OpacEnableLDAPLogin and staff equivalents additionally - when using identity providers they always add the line: <p>If you do not have an external account, but do have a local account, you can still log in: </p> This needs a class at minimum, but should likely be removed and allow the library to specify the text in loginInstructions html customization -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37715 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de, | |lucas@bywatersolutions.com, | |martin.renvoize@ptfs-europe | |.com, tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37715 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|OPAC |System Administration CC| |gmcharlt@gmail.com Assignee|oleonard@myacpl.org |koha-bugs@lists.koha-commun | |ity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37715 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #1 from David Cook <dcook@prosentient.com.au> --- 100% agreed with all of this -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37715 Oliver Behnke <oliver.behnke@aei.mpg.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oliver.behnke@aei.mpg.de --- Comment #2 from Oliver Behnke <oliver.behnke@aei.mpg.de> --- Just to vote this up a notch! I'm particularly interested in OpacEnableLocalLogin since leaving local login enabled after having switched to OIDC-based SSO is just confusing our users. Thanks -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37715 --- Comment #3 from Oliver Behnke <oliver.behnke@aei.mpg.de> --- Looking into a patch for OpacEnableLocalLogin... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37715 --- Comment #4 from Oliver Behnke <oliver.behnke@aei.mpg.de> --- Created attachment 185341 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185341&action=edit Added OpacEnableLocalLogin/StaffEnableLocalLogin to disable local logins Ok, as promised, here's a first patch. I omitted whitespace changes (indentations) to facilitate the patch discussion. Let me know if you want to go forward with this. Note: what's missing is the corresponding DB rev upgrade. Cheers -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37715 --- Comment #5 from Oliver Behnke <oliver.behnke@aei.mpg.de> --- (In reply to Nick Clemens (kidclamp) from comment #0)
It would be nice to instead have a switch for each: [...] OpacEnableShibLogin OpacEnableLDAPLogin
These two are effectively managed in koha-conf.xml [1], presumably since they need further config entries that sysprefs are probably not tailored for. Do you suggest to move those to the sysprefs anyway? Cheers [1] https://git.koha-community.org/Koha-community/Koha/src/commit/3ea3c2a27a9e7f... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37715 --- Comment #6 from Oliver Behnke <oliver.behnke@aei.mpg.de> --- (In reply to Nick Clemens (kidclamp) from comment #0)
It would be nice to instead have a switch for each: [...] OpacEnableCASLogin
How would that differ from the existing "casAuthentication"? Thanks -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37715 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=40596 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37715 --- Comment #7 from Oliver Behnke <oliver.behnke@aei.mpg.de> --- Thanks @tcohen for referencing bug 40596! That means CAS and Shibboleth are already in the process of being refactored - and rightfully so. May I ask the question if we could thus constrain this bug to controlling local login only, at least if LDAP is out of the question? This way we could expedite my patch which would be highly appreciated by our users ;) Cheers -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37715 Oliver Behnke <oliver.behnke@aei.mpg.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org