[Bug 11059] New: Not possible to sort staged dates in metric format
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11059 Bug ID: 11059 Summary: Not possible to sort staged dates in metric format Change sponsored?: --- Product: Koha Version: 3.10 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: koha@univ-lyon3.fr QA Contact: testopia@bugs.koha-community.org Created attachment 22011 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22011&action=edit Not possible to sort staged dates in metric format In 'Add order to basket' page, when importing from staged file, it was not possible to sort the dates if the metric format is used. The reason is that dt_add_type_uk_date function and call to it were missing. I set no default sorting in datatable parameters. Anyhow the sorting is made on staged date desc by perl and I suppose it's what users are expecting ? I suppressed a split of timestamp data in addorderiso2709.pl because it seems to me that it's useless (but not sure of it.) Olivier Crouzet -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11059 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |koha@univ-lyon3.fr -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11059 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22011|0 |1 is obsolete| | --- Comment #1 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- Created attachment 22012 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22012&action=edit Bug 11059 not possible to sort staged dates in metric format -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11059 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers@biblibre.co | |m --- Comment #2 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Adding dateformat to template vars is not necessary in addorderiso2709.pl : $template->param(dateformat => C4::Context->preference('dateformat')); It is already done in C4/Auth.pm -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11059 --- Comment #3 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- Maybe that SHOULD work without this line, but it does not. I checked it. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11059 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Version|3.10 |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11059 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=9108 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11059 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #4 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Your patch needs a small rebase, because Bug 9108 has already added [% IF (dateformat == 'metric') %] dt_add_type_uk_date(); [% END %] into addorderiso2709.tt -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11059
--- Comment #5 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> ---
(In reply to Koha Team Lyon 3 from comment #3)
> Maybe that SHOULD work without this line, but it does not. I checked it.
It works for me, in current master code.
Tested it by added in addorderiso2709.tt :
$(document).ready(function() {
+ alert('dateformat=[% dateformat %]');
The page displays an alert with "metric" (since I am in France).
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11059 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22012|0 |1 is obsolete| | --- Comment #6 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- Created attachment 22263 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22263&action=edit Bug 11059 Not possible to sort staged dates in metric format Ok Fridolyn, the point is that I opened that bug and tested my patch for 3.10. ( and in 3.10 we must change the condition in template for this : [% IF ( dateformat_metric ) %] to make without assignment of dateformat in addorderiso2709.pl ). I rebased and modified for master as you suggested. Olivier Crouzet -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11059 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11059 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #7 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- (In reply to Koha Team Lyon 3 from comment #6)
Created attachment 22263 [details] [review] Bug 11059 Not possible to sort staged dates in metric format I rebased and modified for master as you suggested. Your patch adds : [% IF (dateformat == 'metric') %] dt_add_type_uk_date(); [% END %] This is not needed, it is done a few lines above.
-- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11059 --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- I prefer the newer method where the DataTables plugin looks for an ISO-formatted date in a title attribute. This means that we don't need any logic around date format. See booksellers.tt for an example. In the DataTables initialization configuration: "aoColumns": [ null,null,null,null,null,null,{ "sType": "title-string" },{ "sType": "title-string" },null ], ...where "sType," the sorting type, is "title-string." This looks for a <span> with a title attribute containing the unformatted date: <td><span title="[% basket.creationdate %]">[% basket.creationdate | $KohaDates %]</span></td> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11059 --- Comment #9 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- (In reply to Fridolyn SOMERS from comment #7)
(In reply to Koha Team Lyon 3 from comment #6)
Created attachment 22263 [details] [review] [review] Bug 11059 Not possible to sort staged dates in metric format I rebased and modified for master as you suggested. Your patch adds : [% IF (dateformat == 'metric') %] dt_add_type_uk_date(); [% END %] This is not needed, it is done a few lines above.
?!! I deleted these lines, there are not any more in the last patch. Did you really test this one (id=2263) ? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11059 --- Comment #10 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- (In reply to Koha Team Lyon 3 from comment #9)
?!! I deleted these lines, there are not any more in the last patch. Did you really test this one (id=2263) ? I still see those lines in actual patch.
(In reply to Owen Leonard from comment #8)
I prefer the newer method where the DataTables plugin looks for an ISO-formatted date in a title attribute Me too, it is more clear and alows to display the time.
-- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11059 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22263|0 |1 is obsolete| | --- Comment #11 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- Created attachment 22882 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22882&action=edit Bug 11059 Not possible to sort staged dates in metric format Here's a new patch using title-string type. Olivier Crouzet -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11059 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11059 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22882|0 |1 is obsolete| | Status|Needs Signoff |Signed Off Assignee|koha-bugs@lists.koha-commun |fridolyn.somers@biblibre.co |ity.org |m --- Comment #12 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 22885 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22885&action=edit Bug 11059 - Not possible to sort staged dates in metric format Signed-off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11059 --- Comment #13 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 22886 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22886&action=edit Bug 11059 - Restore time in staged dates in addorderiso2709.tt Follow-up patch to restore the display of time in acqui/addorderiso2709.tt in staged date. Simply uses an option of KohaDates TT plugin. This time may be usefull if there where several imports in the same day. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11059 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #14 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Follow-up needs signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11059 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|Small patch |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11059 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22886|0 |1 is obsolete| | --- Comment #15 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 22943 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22943&action=edit [SIGNED-OFF] Bug 11059 - Restore time in staged dates in addorderiso2709.tt Follow-up patch to restore the display of time in acqui/addorderiso2709.tt in staged date. Simply uses an option of KohaDates TT plugin. This time may be usefull if there where several imports in the same day. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11059 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22885|0 |1 is obsolete| | --- Comment #16 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 23098 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23098&action=edit Bug 11059 - Not possible to sort staged dates in metric format Adds title-string sorting type to enable this. Signed-off-by: Fridolyn SOMERS <fridolyn.somers@biblibre.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11059 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11059 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22943|0 |1 is obsolete| | --- Comment #17 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 23099 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23099&action=edit Bug 11059 - Restore time in staged dates in addorderiso2709.tt Follow-up patch to restore the display of time in acqui/addorderiso2709.tt in staged date. Simply uses an option of KohaDates TT plugin. This time may be usefull if there where several imports in the same day. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11059 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #18 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Oliver! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11059 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #19 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Those patches has been pushed to 3.14.x, will be in 3.14.1 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org