[Bug 10906] New: Reimported records into Koha are imported only as DEFAULT frameworks, not what they were originally
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10906 Bug ID: 10906 Summary: Reimported records into Koha are imported only as DEFAULT frameworks, not what they were originally Change sponsored?: --- Product: Koha Version: 3.10 Hardware: PC OS: Windows Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Bibliographic record staging/import Assignee: gmcharlt@gmail.com Reporter: ceciloh@hotmail.com QA Contact: testopia@bugs.koha-community.org Our bibliographic records have differing frameworks for the various formats. We do NOT use the default framework. We then use MarcEdit to add all those nifty RDA fields to our records. We catalog our records and then export them to MarcEdit. MarcEdit does its stuff and then we reimport the records back into Koha. This is where the problem lies. They get reimported back into Koha with the DEFAULT framework. This did NOT happen when we were on 3.8 but it is happening now in 3.10 and it looks like it also happens in 3.12. They match just fine on the control number but the framework changes. This adds much time and steps to our cataloging process. Is this a bug or an enhancement request? I've been informed that this is how it is supposed to work. Cecil Hillyard Washoe County Library Reno, Nevada -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10906 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com --- Comment #1 from Nicole C. Engard <nengard@gmail.com> --- I want to add to this that the problem is also a language issue - the text says "Add new bibliographic records into this framework" but the records in question aren't 'new' so that's where part of the confusion occurs -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10906 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10906 Marjorie Barry-Vila <marjorie.barry-vila@ccsr.qc.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10906 Jacek Ablewicz <abl@biblos.pk.edu.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11064 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10906 Jacek Ablewicz <abl@biblos.pk.edu.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |abl@biblos.pk.edu.pl --- Comment #2 from Jacek Ablewicz <abl@biblos.pk.edu.pl> --- This is still broken in current master (but only when records are being matched & replaced when importing; for the records imported 'as new', framework choosen by the user seems to be saved and retained properly - ?). Looks like some changes introduced by commit 82dc7b55a8b5a7642a906dcd8963952b7464adb1 ("Bug 4321: clean C4::Biblio::GetBiblio and uses") got inadvertantly reverted by next commmit (6e71b80ca39e6f1d2c31659a9a656de807ef3f32, "Bug 7475: Teach matching rules to handle authorities"). Another remaining place where GetBiblio() return results are wrongly assigned is serials/subscription-history.pl script. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10906 --- Comment #3 from Jacek Ablewicz <ablewicz@gmail.com> --- Created attachment 37126 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37126&action=edit Bug 10906 - Reimported records into Koha are imported only as DEFAULT frameworks, not what they were originally Existing framework code is currently not retained when local record gets replaced during batch import, or when the restore/reverse function is being used. This patch fixes aforementioned issues by correcting outdated GetBiblio() calls in C4/ImportBatch.pm To test: 1/ try to replicate the issue: import some MARC records with "Tools -> Stage MARC records for import" etc., using test setup, matching rules and so on such that some existing records will get replaced with imported ones 2/ observe that records replaced during import now open in the editor with 'Default' framework, even if they have some other framework set up previously 3/ apply patch 4/ redo 1/, confirming that this problem is no longer replicable 5/ try use 'restore' function with some freshly imported records, ensure that original framework code got retained in the records which had their imports reverted -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10906 Jacek Ablewicz <abl@biblos.pk.edu.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- OS|Windows |All Status|NEW |Needs Signoff Assignee|gmcharlt@gmail.com |abl@biblos.pk.edu.pl Patch complexity|--- |Trivial patch Version|3.10 |master Hardware|PC |All -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10906 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10906 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37126|0 |1 is obsolete| | --- Comment #4 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 37442 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37442&action=edit Bug 10906 - Reimported records into Koha are imported only as DEFAULT frameworks, not what they were originally Existing framework code is currently not retained when local record gets replaced during batch import, or when the restore/reverse function is being used. This patch fixes aforementioned issues by correcting outdated GetBiblio() calls in C4/ImportBatch.pm To test: 1/ try to replicate the issue: import some MARC records with "Tools -> Stage MARC records for import" etc., using test setup, matching rules and so on such that some existing records will get replaced with imported ones 2/ observe that records replaced during import now open in the editor with 'Default' framework, even if they have some other framework set up previously 3/ apply patch 4/ redo 1/, confirming that this problem is no longer replicable 5/ try use 'restore' function with some freshly imported records, ensure that original framework code got retained in the records which had their imports reverted NOTE: I confirmed this change by 1) git grep "=\s*GetBiblio\s*(" -- this shows how GetBiblio is called elsewhere. It differed! So then... 2) vi C4/Biblio.pm /sub GetBiblio -- find the right one, notice it only returns a HASH ref, not an array. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10906 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13947 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10906 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10906 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37442|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 37456 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37456&action=edit [PASSED QA] Bug 10906 - Reimported records into Koha are imported only as DEFAULT frameworks, not what they were originally Existing framework code is currently not retained when local record gets replaced during batch import, or when the restore/reverse function is being used. This patch fixes aforementioned issues by correcting outdated GetBiblio() calls in C4/ImportBatch.pm To test: 1/ try to replicate the issue: import some MARC records with "Tools -> Stage MARC records for import" etc., using test setup, matching rules and so on such that some existing records will get replaced with imported ones 2/ observe that records replaced during import now open in the editor with 'Default' framework, even if they have some other framework set up previously 3/ apply patch 4/ redo 1/, confirming that this problem is no longer replicable 5/ try use 'restore' function with some freshly imported records, ensure that original framework code got retained in the records which had their imports reverted NOTE: I confirmed this change by 1) git grep "=\s*GetBiblio\s*(" -- this shows how GetBiblio is called elsewhere. It differed! So then... 2) vi C4/Biblio.pm /sub GetBiblio -- find the right one, notice it only returns a HASH ref, not an array. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10906 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Jacek! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10906 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #7 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.18.x will be in 3.18.6 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10906 --- Comment #8 from Jonathan Druart <jonathan.druart@biblibre.com> --- *** Bug 11064 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org