[Bug 11035] New: Replace shortcut plugin jquery.hotkeys.min.js
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11035 Bug ID: 11035 Summary: Replace shortcut plugin jquery.hotkeys.min.js Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: blocker Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt@gmail.com Reporter: philippe.blouin@inlibro.com QA Contact: testopia@bugs.koha-community.org (Not sure I have have the right Component or Severity, feedbacks welcomed). A sponsor asked for some specific keyboard shortcuts. After discussion a month ago with (oleonard, jcamins), it seemed a change of plugin was needed because the current one is not maintained and would limit our ability to upgrade jquery, simply. I was suggested a few independant ones, and implemented my feature with openjs's. This bug is ONLY about changing the plugin. It brings no new functionnality nor does it changes behavior. Enhancement to shortcut could bring a lot of discussion. Refression TESTING: 1) apply the patch, 2) in intranet, validate that the three available shortcuts (Alt-r, alt-u, alt-q) are still functionning perfectly. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11035 Blou <philippe.blouin@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |philippe.blouin@inlibro.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11035 Blou <philippe.blouin@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|blocker |normal -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11035 --- Comment #1 from Blou <philippe.blouin@inlibro.com> --- Created attachment 21952 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21952&action=edit Bug 11035 - Replace shortcut plugin jquery.hotkeys.min.js To old plugin prevents the upgrade to the latest jquery. By replacing with openjs' shortcut.js, we have now one less hurdle in upgrading Koha to latest. Changes: - removed jquery.hotkeys.min.js - added shortcut.js - modified the related includes (doc-head-close.inc and help-top.inc) - modified the calls in staff-global.js Regression test: 1) apply the patch 2) in the intranet, test the shortcuts alt-q, alt-r, alt-u. These are the only affected functionalities. There is no new functionnality. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11035 Blou <philippe.blouin@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11035 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #2 from Jonathan Druart <jonathan.druart@biblibre.com> --- Note for QA: circ/offline-mf.tt uses jquery.hotkeys.min.js too. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11035 Blou <philippe.blouin@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21952|0 |1 is obsolete| | --- Comment #3 from Blou <philippe.blouin@inlibro.com> --- Created attachment 22311 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22311&action=edit Bug 11035 - Replace shortcut plugin jquery.hotkeys.min.js Seems a new file circ/offline-mf.tt got added with hotkeys.js. I replaced it but I couldn't find ANY usage of it to fix. Rebased and fixed. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11035 Blou <philippe.blouin@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21952|1 |0 is obsolete| | Attachment #21952|Bug 11035 - Replace |Bug 11035 - (first patch) description|shortcut plugin |Replace shortcut plugin |jquery.hotkeys.min.js |jquery.hotkeys.min.js -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11035 Blou <philippe.blouin@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22311|Bug 11035 - Replace |Bug 11035 - (patching the description|shortcut plugin |patch) Replace shortcut |jquery.hotkeys.min.js |plugin | |jquery.hotkeys.min.js -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11035 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21952|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 22415 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22415&action=edit Bug 11035 - Replace shortcut plugin jquery.hotkeys.min.js To old plugin prevents the upgrade to the latest jquery. By replacing with openjs' shortcut.js, we have now one less hurdle in upgrading Koha to latest. Changes: - removed jquery.hotkeys.min.js - added shortcut.js - modified the related includes (doc-head-close.inc and help-top.inc) - modified the calls in staff-global.js Regression test: 1) apply the patch 2) in the intranet, test the shortcuts alt-q, alt-r, alt-u. These are the only affected functionalities. There is no new functionnality. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11035 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22311|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 22416 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22416&action=edit Bug 11035 - Replace shortcut plugin jquery.hotkeys.min.js Seems a new file circ/offline-mf.tt got added with hotkeys.js. I replaced it but I couldn't find ANY usage of it to fix. Rebased and fixed. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11035 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11035 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jcamins@cpbibliography.com --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Blou from comment #3)
Seems a new file circ/offline-mf.tt got added with hotkeys.js. I replaced it but I couldn't find ANY usage of it to fix.
Same for me. Jared, could you confirm your development for Offline circulation (bug 10240) includes this js file but don't use it? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11035 --- Comment #7 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- (In reply to Jonathan Druart from comment #6)
(In reply to Blou from comment #3)
Seems a new file circ/offline-mf.tt got added with hotkeys.js. I replaced it but I couldn't find ANY usage of it to fix.
Same for me. Jared, could you confirm your development for Offline circulation (bug 10240) includes this js file but don't use it?
The offline circulation module includes the file via doc-head-close.inc. If the file is changed there, it must be changed in the manifest as well. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11035 --- Comment #8 from Jonathan Druart <jonathan.druart@biblibre.com> --- Haaa :) Thanks Jared for the clarification! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11035 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11035 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22415|0 |1 is obsolete| | Attachment #22416|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 23259 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23259&action=edit [PASSED QA] Bug 11035 - Replace shortcut plugin jquery.hotkeys.min.js To old plugin prevents the upgrade to the latest jquery. By replacing with openjs' shortcut.js, we have now one less hurdle in upgrading Koha to latest. Changes: - removed jquery.hotkeys.min.js - added shortcut.js - modified the related includes (doc-head-close.inc and help-top.inc) - modified the calls in staff-global.js Regression test: 1) apply the patch 2) in the intranet, test the shortcuts alt-q, alt-r, alt-u. These are the only affected functionalities. There is no new functionnality. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes all tests and QA script. Tested existing shortcuts for the search bar tabs on various circulation related pages. This uses a Javascript under BSD license, I wonder if it should be listed in the About>licenses section that we are using it. As Yui is also BSD I assume the license is compatible. +/** + * http://www.openjs.com/scripts/events/keyboard_shortcuts/ + * Version : 2.01.B + * By Binny V A + * License : BSD + */ -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11035 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23259|0 |1 is obsolete| | --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 23260 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23260&action=edit [PASSED QA] Bug 11035 - Replace shortcut plugin jquery.hotkeys.min.js Seems a new file circ/offline-mf.tt got added with hotkeys.js. I replaced it but I couldn't find ANY usage of it to fix. Rebased and fixed. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11035 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23259|1 |0 is obsolete| | CC| |katrin.fischer@bsz-bw.de --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Comment on attachment 23259 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23259 [PASSED QA] Bug 11035 - Replace shortcut plugin jquery.hotkeys.min.js Please have different subjects on various patches - or git bz automatically obsoletes the first when attaching the second :) Also, Galen - please can you take a look at my note on the first patch before pushing? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11035 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #12 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master, along with followups to move it out of jquery/plugins (as shortcuts.js is not actually a jQuery plugin) and to update the About | Licenses page. Thanks, Philippe! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11035 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolyn.somers@biblibre.co | |m --- Comment #13 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Those patches has been pushed to 3.14.x, will be in 3.14.1. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11035 Francois Charbonnier <francharb@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |francharb@gmail.com -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org