[Bug 8334] New: Authority UNIMARC 100 field plugin
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8334 Priority: P5 - low Change sponsored?: --- Bug ID: 8334 Assignee: gmcharlt@gmail.com Summary: Authority UNIMARC 100 field plugin Severity: enhancement Classification: Unclassified OS: All Reporter: vfernandes@keep.pt Hardware: All Status: NEW Version: unspecified Component: MARC Authority data support Product: Koha There is no 100 authority field plugin. It would be nice to have it. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8334 Vitor Fernandes <vfernandes@keep.pt> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P1 - high --- Comment #1 from Vitor Fernandes <vfernandes@keep.pt> --- Many people are asking to this plugin. Can anyone with more UNIMARC knowlegdes than me start this? I can improve the plugin later. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8334 --- Comment #2 from Vitor Fernandes <vfernandes@keep.pt> --- Created attachment 21115 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21115&action=edit Script to generate UNIMARC authorities 100 field -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8334 --- Comment #3 from Vitor Fernandes <vfernandes@keep.pt> --- Created attachment 21116 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21116&action=edit Template for UNIMARC authorities 100 field -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8334 Vitor Fernandes <vfernandes@keep.pt> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #4 from Vitor Fernandes <vfernandes@keep.pt> --- The script needs to be copied to ../intranet/cgi-bin/cataloguing/value_builder/ The template needs to be copied to ../intranet/htdocs/intranet-tmpl/prog/en/modules/cataloguing/value_builder/ I've tested and everything worked fine. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8334 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |bgkriegel@gmail.com --- Comment #5 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Vitor, looks promising, tested and works well AFAIK. But: 1) You must make a patch a) Verify unimarc_field_100_authorities.pl is chmoded +x b) Update licence information, you do not work for katipo :) read http://wiki.koha-community.org/wiki/Coding_Guidelines#Licence c) do git add cataloguing/value_builder/unimarc_field_100_authorities.pl git add koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_100_authorities.tt git commit -m "Bug 8334 - Authority UNIMARC 100 field plugin" d) then do git bz attach -e 8334 HEAD or git format-patch origin/master, and upload that as patch 2) But before upload, you must fix the following errors koha-qa -c 1 -v 3 testing 1 commit(s) (applied to dcbe50c 'Bug 10897: remove test for module tha') FAIL cataloguing/value_builder/unimarc_field_100_authorities.pl OK pod FAIL forbidden patterns forbidden pattern: tab char (line 124) forbidden pattern: tab char (line 119) forbidden pattern: tab char (line 118) forbidden pattern: tab char (line 122) forbidden pattern: tab char (line 117) forbidden pattern: tab char (line 121) forbidden pattern: tab char (line 123) OK valid OK critic FAIL koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_100_authorities.tt FAIL forbidden patterns forbidden pattern: trailing space char (line 326) forbidden pattern: trailing space char (line 187) forbidden pattern: trailing space char (line 372) forbidden pattern: trailing space char (line 321) forbidden pattern: trailing space char (line 213) forbidden pattern: tab char (line 213) forbidden pattern: trailing space char (line 74) forbidden pattern: trailing space char (line 361) forbidden pattern: trailing space char (line 100) forbidden pattern: trailing space char (line 134) forbidden pattern: trailing space char (line 239) forbidden pattern: tab char (line 188) forbidden pattern: tab char (line 187) forbidden pattern: trailing space char (line 106) forbidden pattern: trailing space char (line 45) forbidden pattern: trailing space char (line 389) forbidden pattern: trailing space char (line 124) forbidden pattern: trailing space char (line 205) forbidden pattern: trailing space char (line 393) forbidden pattern: trailing space char (line 354) forbidden pattern: trailing space char (line 334) forbidden pattern: trailing space char (line 405) forbidden pattern: trailing space char (line 149) forbidden pattern: trailing space char (line 315) OK tt_valid OK valid_template 3) Finally, you must add a test plan to the bug description, for example a) Edit authority framework XXX, link subfield 'a' with plugin b) create a new record or edit one c) use plugin d) save 4) Question: Is there a link to valid language codes? that could be a useful. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8334 --- Comment #6 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> ---
d) then do git bz attach -e 8334 HEAD
Sorry, it's git bz attach 8334 HEAD -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8334 --- Comment #7 from Vitor Fernandes <vfernandes@keep.pt> --- Hi Bernardo, Sorry but at this point I can't do a patch for this. If anyone could do that I'll be very appreciated. Bernardo, thanks for testing it and give this info. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8334 --- Comment #8 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Vitor, If you do not mind, I'll post a patch on your behalf. Bernardo -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8334 --- Comment #9 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 21217 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21217&action=edit Bug 8334 - Authority UNIMARC 100 field plugin The work for this patch belongs to Vitor Fernandez This patch adds a plugin for field 100 of UNIMARC authorities. To test on a UNIMARC site: 1) Apply the patch 2) Edit some authority framework, field 100 3) Link subfield 'a' to unimarc_field_100_authorities.pl plugin, save 4) Edit or add auth record, clic on '...' to bring plugin 5) Modify field 100a 6) Save record Please someone with UNIMARC experience take a look at this. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8334 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8334 --- Comment #10 from Vitor Fernandes <vfernandes@keep.pt> --- Thanks Bernardo for the patch :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8334 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21217|0 |1 is obsolete| | --- Comment #11 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 21230 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21230&action=edit Bug 8334 - Authority UNIMARC 100 field plugin The work for this patch belongs to Vitor Fernandez Udated License information. This patch adds a plugin for field 100 of UNIMARC authorities. To test on a UNIMARC site: 1) Apply the patch 2) Edit some authority framework, field 100 3) Link subfield 'a' to unimarc_field_100_authorities.pl plugin, save 4) Edit or add auth record, clic on '...' to bring plugin 5) Modify field 100a 6) Save record Please someone with UNIMARC experience take a look at this. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8334 I'm just a bot <gitbot@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gitbot@bugs.koha-community. | |org When did the bot| |2013-09-24 last check this| | --- Comment #12 from I'm just a bot <gitbot@bugs.koha-community.org> --- Patch applied cleanly, go forth and signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8334 I'm just a bot <gitbot@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- When did the bot|2013-09-24 00:00:00 |2013-10-25 last check this| | --- Comment #13 from I'm just a bot <gitbot@bugs.koha-community.org> --- Patch applied cleanly, go forth and signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8334 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathieu.saby@univ-rennes2.f | |r --- Comment #14 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- It works well, I sign off. Mathieu -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8334 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21230|0 |1 is obsolete| | --- Comment #15 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- Created attachment 23228 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23228&action=edit [PATCH][SIGNED OFF] Bug 8334 - Authority UNIMARC 100 field plugin -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8334 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21116|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8334 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21115|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8334 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8334 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8334 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P1 - high |P2 --- Comment #16 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- I lower a bit priority... Mathieu -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8334 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8334 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #17 from Jonathan Druart <jonathan.druart@biblibre.com> --- Looks good to me, I ask to Stéphane to have a look too. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8334 --- Comment #18 from Jonathan Druart <jonathan.druart@biblibre.com> --- Bernardo, could you confirm I can delete commented JS code in the tt file? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8334 delaye <stephane.delaye@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |stephane.delaye@biblibre.co | |m --- Comment #19 from delaye <stephane.delaye@biblibre.com> --- It works well, I sign off. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8334 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8334 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23228|0 |1 is obsolete| | --- Comment #20 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 23513 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23513&action=edit Bug 8334 - Authority UNIMARC 100 field plugin The work for this patch belongs to Vitor Fernandez Udated License information. This patch adds a plugin for field 100 of UNIMARC authorities. To test on a UNIMARC site: 1) Apply the patch 2) Edit some authority framework, field 100 3) Link subfield 'a' to unimarc_field_100_authorities.pl plugin, save 4) Edit or add auth record, clic on '...' to bring plugin 5) Modify field 100a 6) Save record Please someone with UNIMARC experience take a look at this. Signed-off-by: Mathieu Saby <mathieu.saby@univ-rennes2.fr> Signed-off-by: Stephane Delaye <stephane.delaye@biblibre.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8334 --- Comment #21 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 23514 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23514&action=edit Bug 8334: Remove commented JS code Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8334 --- Comment #22 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- (In reply to Jonathan Druart from comment #18)
Bernardo, could you confirm I can delete commented JS code in the tt file?
I confirm :-) That code was on the original file submited by Vitor, I suppose taken from a file he used as template. Anyway, if this pass I think an update to UNIMARC frameworks will be needed to link this plugin permanently. Bernardo -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8334 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #23 from Galen Charlton <gmcharlt@gmail.com> --- I've pushed this to master. Thanks, Vitor! And thanks, Bernardo, for rescuing this kitten. I updated the author attribution in the base patch to use Vitor's name and credit Bernardo for converting it to a testable Git patch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8334 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolyn.somers@biblibre.co | |m --- Comment #24 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Patches pushed to 3.14.x, will be in 3.14.2 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org