[Bug 31015] New: Remove option to clear pickup location selects on multi-holds page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31015 Bug ID: 31015 Summary: Remove option to clear pickup location selects on multi-holds page Change sponsored?: --- Product: Koha Version: 21.11 Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: jrobb@sekls.org QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com When placing multiple holds at once, the various selects for pickup location have a little X at the far right next to the dropdown arrow. Clicking the X clears the field and allows for holds to be created with null pickup locations. We discovered the hard way that things like the holds queue completely break when there are null pickup locations lurking about. It also seems to prevent the holds tab on the patron account from loading. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31015 --- Comment #1 from Jason Robb <jrobb@sekls.org> --- After a picking at this a little bit more, it seems the custom jQuery I'm using to prefill the pickup locations is facilitating the problem. If I disable the jQuery, the page pops up an alert and won't save with an empty pickup location. The X to clear that top pickup location select doesn't appear when placing a single-title hold so it might still make sense to get rid of it on the multi-hold page to match behaviors. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31015 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|21.11 |master --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- The x is part of the select2 pull downs, not sure if it can be removed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31015 --- Comment #3 from Jason Robb <jrobb@sekls.org> --- The larger issue was that holds could be placed without branchcodes assigned under certain circumstances. If I'm understanding correctly, bug 31086 seems to fully prevent that from happening so this may not be a problem any longer. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31015 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |MOVED Status|NEW |RESOLVED --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Jason Robb from comment #3)
The larger issue was that holds could be placed without branchcodes assigned under certain circumstances.
If I'm understanding correctly, bug 31086 seems to fully prevent that from happening so this may not be a problem any longer.
Marking as MOVED. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org