[Bug 8707] New: tags always say approved
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8707 Priority: P5 - low Change sponsored?: --- Bug ID: 8707 Assignee: gmcharlt@gmail.com Summary: tags always say approved Severity: major Classification: Unclassified OS: All Reporter: nengard@gmail.com Hardware: All Status: NEW Version: rel_3_8 Component: Tools Product: Koha Created attachment 11900 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11900&action=edit rejected say approved This happens in master and 3.8.4 (those are the ones I tested). When you look at your tags there used to be tabs across the top for pending/approved/rejected - now there isn't, but this isn't as big a deal as the fact that tags that were rejected have the 'approved' box depressed. See attached images. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8707 --- Comment #1 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 11901 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11901&action=edit rejected and approved all say approved See the buttons on the right show approved no matter what. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8707 --- Comment #2 from Marc Véron <veron@veron.ch> --- Comment on attachment 11901 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11901 rejected and approved all say approved Workaround I: Check checkboxes next tags you want to approve again and use the "Approve" button at the bottom of the table. Workaround II: On the line of a rejected tag, click the "Reject" button. Thsi will activate the "Approved" button. Marc -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8707 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8707 --- Comment #3 from Marc Véron <veron@veron.ch> --- ...but with Workaround II the "Approved" button becomes active, but it does nothing... Marc -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8707 --- Comment #4 from Marc Véron <veron@veron.ch> --- ...and some more findings: The button I mentioned in Comment #3 only _seems_ to do nothing. As soon I reload the page or apply the filter again the status is changed. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8707 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8707 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 13118 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13118&action=edit Bug 8707 - tags always say approved Template scope error caused an incorrect state on the approval/rejection buttons when viewing rejected tags. To test, go to Tags and view the list of rejected tags. In the "Actions" column, the "rejected" button should be greyed out, and the "approve" button active. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8707 --- Comment #6 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 13144 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13144&action=edit [SIGNED-OFF] Bug 8707 - tags always say approved Template scope error caused an incorrect state on the approval/rejection buttons when viewing rejected tags. To test, go to Tags and view the list of rejected tags. In the "Actions" column, the "rejected" button should be greyed out, and the "approve" button active. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8707 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13118|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8707 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Version|rel_3_8 |rel_3_10 --- Comment #7 from Nicole C. Engard <nengard@gmail.com> --- If this can go in to 3.10 and 3.8 that would be awesome!! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8707 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart@biblibre.co | |m --- Comment #8 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA Comments: Easy fix, just one : I think this line could be removed in the review.pl file approved => 0, # dummy value (also EXPR) Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8707 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |oleonard@myacpl.org QA Contact| |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8707 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #9 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8707 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13144|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8707 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain@biblibre.com --- Comment #10 from Paul Poulain <paul.poulain@biblibre.com> --- Patch pushed to branch 3.10.x -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8707 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED CC| |chris@bigballofwax.co.nz Resolution|--- |FIXED --- Comment #11 from Chris Cormack <chris@bigballofwax.co.nz> --- Released with 3.10.0 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org