[Bug 30870] New: Don't skip tests if Test::Deep is not installed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30870 Bug ID: 30870 Summary: Don't skip tests if Test::Deep is not installed Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Test Suite Assignee: jonathan.druart+koha@gmail.com Reporter: jonathan.druart+koha@gmail.com QA Contact: testopia@bugs.koha-community.org We are using Test::Deep in different tests, but from t/db_dependent/Koha.t the tests are skippted if the module is not installed. We must assume the module is installed (or skip everywhere). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30870 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29883 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29883 [Bug 29883] Uninitialized value warning when GetAuthorisedValues gets called with no parameters -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30870 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30870 --- Comment #1 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 135483 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135483&action=edit Bug 30870: Don't skip tests if Test::Deep if not installed We are using Test::Deep in different tests, but from t/db_dependent/Koha.t the tests are skippted if the module is not installed. We must assume the module is installed Test plan: prove t/db_dependent/Koha.t should return green in ktd -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30870 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30870 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135483|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 135513 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135513&action=edit Bug 30870: Don't skip tests if Test::Deep if not installed We are using Test::Deep in different tests, but from t/db_dependent/Koha.t the tests are skippted if the module is not installed. We must assume the module is installed Test plan: prove t/db_dependent/Koha.t should return green in ktd Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30870 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135513|0 |1 is obsolete| | --- Comment #3 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 135514 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135514&action=edit Bug 30870: Don't skip tests if Test::Deep if not installed We are using Test::Deep in different tests, but from t/db_dependent/Koha.t the tests are skippted if the module is not installed. We must assume the module is installed Test plan: prove t/db_dependent/Koha.t should return green in ktd Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30870 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net Status|Signed Off |Passed QA --- Comment #4 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Works, qa script happy, code looks good, passing QA :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30870 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30870 --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30870 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |victor@tuxayo.net |y.org | CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30870 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Version(s)|22.11.00 |22.11.00, 22.05.01 released in| | Status|Pushed to master |Pushed to stable --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- Pushed to 22.05.x for 22.05.01 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30870 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED --- Comment #7 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. And nothing to document, resolving. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30870 Bug 30870 depends on bug 29883, which changed state. Bug 29883 Summary: Uninitialized value warning when GetAuthorisedValues gets called with no parameters https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29883 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org