[Bug 24264] New: Cannot search for genre/form authorities
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24264 Bug ID: 24264 Summary: Cannot search for genre/form authorities Change sponsored?: --- Product: Koha Version: 19.05 Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com When search with an authtype in ES we are using the term filter to limit to a type. This filter is analyzed and the forward slash in genre/form seems to be problematic bug 20589 fixed this incidentally to other changes, however, 19.05 still has this bug. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24264 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Cannot search for |Elasticsearch - Cannot |genre/form authorities |search for genre/form | |authorities Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24264 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24264 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 96421 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96421&action=edit Bug 24264: Use raw field when limiting by authtype To test: 1 - Have a genre form record in your authorities file 2 - Search authorities for 'Default' 3 - The result is returned 4 - Set the dropdown to 'Genre/Form' and search matchign term 5 - No results 6 - Apply patch 7 - Restart all the things 8 - Repeat search for 'Genre/Form' and search matching term 9 - Record is returned -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24264 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24286 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24264 Myka Kennedy Stephens <mkstephens@lancasterseminary.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mkstephens@lancasterseminar | |y.edu Status|Needs Signoff |Patch doesn't apply --- Comment #2 from Myka Kennedy Stephens <mkstephens@lancasterseminary.edu> --- I'm sorry, Nick, but I can't get the patch to apply. I've tried on two different systems (Mac and Linux) using docker. Results: Setup: 19.05.x branch (19.05.06.000 on last attempt); ES enabled, query auto truncate turned off 1. There are 13 authority records in the test database containing "fiction" 2. 'Default' authority search for "fiction" 3. Yields 13 results - 3 topical and 10 genre/form 4. 'Genre/Form Term' authority search for "fiction" 5. Yields 0 results 6. Apply patch 7. restart_all, updatedatabase, dbic, reindex ES 8. 'Genre/Form Term' authority search for "fiction" 9. Yields 0 results Plack error log doesn't show anything. If there's another place to check for errors to troubleshoot the patch, please let me know. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24264 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24264 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96421|0 |1 is obsolete| | --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 96682 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96682&action=edit Bug 24264: Use raw field when limiting by authtype To test: 1 - Have a genre form record in your authorities file 2 - Search authorities for 'Default' 3 - The result is returned 4 - Set the dropdown to 'Genre/Form' and search matchign term 5 - No results 6 - Apply patch 7 - Restart all the things 8 - Repeat search for 'Genre/Form' and search matching term 9 - Record is returned -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24264 --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Myka Kennedy Stephens from comment #2)
I'm sorry, Nick, but I can't get the patch to apply. I've tried on two different systems (Mac and Linux) using docker.
Hi Myka, 'Patch does not apply' is for when there are errors when trying to apply the patch 'Failed QA' is for when a patch doesn't work after it is applied. That was the case here, I wrote a bad patch :-) When using 'raw' we also need to remove the lowercasing, otherwise it doesn't match. New patch attached, please retest -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24264 Myka Kennedy Stephens <mkstephens@lancasterseminary.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24264 Myka Kennedy Stephens <mkstephens@lancasterseminary.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96682|0 |1 is obsolete| | --- Comment #5 from Myka Kennedy Stephens <mkstephens@lancasterseminary.edu> --- Created attachment 96694 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96694&action=edit Bug 24264: Use raw field when limiting by authtype To test: 1 - Have a genre form record in your authorities file 2 - Search authorities for 'Default' 3 - The result is returned 4 - Set the dropdown to 'Genre/Form' and search matchign term 5 - No results 6 - Apply patch 7 - Restart all the things 8 - Repeat search for 'Genre/Form' and search matching term 9 - Record is returned Signed-off-by: Myka Kennedy Stephens <mkstephens@lancasterseminary.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24264 --- Comment #6 from Myka Kennedy Stephens <mkstephens@lancasterseminary.edu> --- (In reply to Nick Clemens from comment #4)
New patch attached, please retest
Patch worked as expected this time. Thanks, Nick! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24264 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24264 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96694|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 96733 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96733&action=edit Bug 24264: Use raw field when limiting by authtype To test: 1 - Have a genre form record in your authorities file 2 - Search authorities for 'Default' 3 - The result is returned 4 - Set the dropdown to 'Genre/Form' and search matchign term 5 - No results 6 - Apply patch 7 - Restart all the things 8 - Repeat search for 'Genre/Form' and search matching term 9 - Record is returned Signed-off-by: Myka Kennedy Stephens <mkstephens@lancasterseminary.edu> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24264 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com, | |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24264 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_19_05_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24264 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to oldstable Version(s)| |19.05.07 released in| | --- Comment #8 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 19.05.x for 19.05.07 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org