[Bug 21758] New: Navigation in Z39.50 result pages not working in Acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21758 Bug ID: 21758 Summary: Navigation in Z39.50 result pages not working in Acquisitions Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-rose@inlibro.com QA Contact: testopia@bugs.koha-community.org When I try to add a record to a basket from Z39.50, I can't seem to go to the next pages of results. I'm stuck on the first page. To reproduce: 1) Go to Acquisitions 2) Search for a Vendor (or add a vendor) 3) Create a new basket 4) Click 'Add to basket' 5) Choose 'from external source' 6) Search for a term (I searched for 'cats' in title and the target is Library of Congress) 7) Check the number of results (I get 1 to 20 of 20, which I find suspect, I'm pretty sure LOC has more than 20 titles containing 'cats' in their collection) 8) Check the number of results pages (I have 1 / 286) 9) Click on Next page (nothing happens) 10) Enter a page number in the 'Go to page' box and click 'Go' (I get an error message saying 'Please choose at least one external target') Can someone test and tell me if they get the same thing? Thanks! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21758 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Severity|enhancement |major --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I can confirm - the navigation is broken. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21758 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com, | |oleonard@myacpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21758 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20038 Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | Status|NEW |ASSIGNED --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Caused by Bug 20038. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20038 [Bug 20038] Switch single-column templates to Bootstrap grid: Acquisitions -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21758 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21758 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 82569 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82569&action=edit Bug 21758: Navigation in Z39.50 result pages not working in Acquisitions This patch makes markup corrections to the acquisitions Z39.50 search results template so that the navigation form works correctly. Also changed: Removed invalid type attributes from style and script tags. To test, apply the patch and go to Acquisitions -> Vendor -> Basket. - Add to basket -> From an external source - Perform a Z39.50 search which will return multiple pages of results - On the search results page, use the form at the bottom of the page to navigate through results. Confirm that both the "Go" form and the next/previous buttons work. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21758 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82569|0 |1 is obsolete| | --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 82575 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82575&action=edit Bug 21758: Navigation in Z39.50 result pages not working in Acquisitions This patch makes markup corrections to the acquisitions Z39.50 search results template so that the navigation form works correctly. Also changed: Removed invalid type attributes from style and script tags. To test, apply the patch and go to Acquisitions -> Vendor -> Basket. - Add to basket -> From an external source - Perform a Z39.50 search which will return multiple pages of results - On the search results page, use the form at the bottom of the page to navigate through results. Confirm that both the "Go" form and the next/previous buttons work. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21758 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21758 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Hours Worked| |0.50 Text to go in the| |The next page, previous release notes| |page, and go buttons now | |work when navigating the | |search results when adding | |a record to a basket from | |an external source. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21758 --- Comment #6 from David Nind <david@davidnind.com> --- Noticed that search results displays 'Showing 1 to 20 of 20' at the start and end of every search results page. Should this display the total number of results and the place in the pagination? This doesn't affect fixing up the issue in the bug, but would be good to fix up as well if it is easy enough to do. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21758 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21758 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82575|0 |1 is obsolete| | --- Comment #7 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 82587 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82587&action=edit Bug 21758: Navigation in Z39.50 result pages not working in Acquisitions This patch makes markup corrections to the acquisitions Z39.50 search results template so that the navigation form works correctly. Also changed: Removed invalid type attributes from style and script tags. To test, apply the patch and go to Acquisitions -> Vendor -> Basket. - Add to basket -> From an external source - Perform a Z39.50 search which will return multiple pages of results - On the search results page, use the form at the bottom of the page to navigate through results. Confirm that both the "Go" form and the next/previous buttons work. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21758 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21758 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #8 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21758 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED CC| |lucas@bywatersolutions.com --- Comment #9 from Lucas Gass <lucas@bywatersolutions.com> --- Doesn't apply cleanly. Please rebase for 18.05. Thanks -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org