[Bug 33820] New: Add hints to warn the librarian that they will be logged out if they change their username
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33820 Bug ID: 33820 Summary: Add hints to warn the librarian that they will be logged out if they change their username Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: rel_23_11_candidate Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: dpavlin@rot13.org, gmcharlt@gmail.com, jonathan.druart+koha@gmail.com, kyle.m.hall@gmail.com, testopia@bugs.koha-community.org, tomascohen@gmail.com Depends on: 33815 Moving this aspect of Bug 33815 to its own bug: We should warn librarians that if they change their own username in the staff interface that they will be logged out. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33815 [Bug 33815] Crash when librarian changes their own username in the staff interface -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33820 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33820 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 151639 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151639&action=edit Bug 33820: Add hints to warn the librarian that they will be logged out if they change their username This patch adds some JavaScript to the patron entry form which adds a hint if the logged-in librarian tries to change their own username. It warns them that they will be logged out. To test, apply the patch and log into the staff interface. - Locate and edit your own patron record. - In the "OPAC/Staff interface login" section, change the value in the username field. When focus leaves that form field a hint should appear, "You will be logged out if you modify your username." - Change the username field back to your original username. The hint should disappear. - Confirm that submitting a username change works correctly: You should be logged out, and when you log in again your username should be updated. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33820 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 151640 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151640&action=edit Bug 33820: (follow-up) Add hint to member-password.tt This follow-up makes the same change to the "Change password" template. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33820 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33820 --- Comment #3 from Sam Lau <samalau@gmail.com> --- First attachment works as expected. The problem occurs when clicking on the "Change Password" template. When editing the username, the hint occurs properly, however, if you press save changes while leaving the new password fields blank, the username doesn't change and it does not log you out. In order for the username change to take effect, you have to enter a new password which basically goes against the text that is listed at the bottom of this page: "Koha cannot display existing passwords. Leave the field blank to leave password unchanged." -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33820 Sam Lau <samalau@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |samalau@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33820 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33832 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33820 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Sam Lau from comment #3)
In order for the username change to take effect, you have to enter a new password which basically goes against the text that is listed at the bottom of this page:
"Koha cannot display existing passwords. Leave the field blank to leave password unchanged."
This issue is unrelated to the patch, so I've created Bug 33832. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33820 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33820 Sam Lau <samalau@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33820 Sam Lau <samalau@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151639|0 |1 is obsolete| | --- Comment #5 from Sam Lau <samalau@gmail.com> --- Created attachment 151685 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151685&action=edit Bug 33820: Add hints to warn the librarian that they will be logged out if they change their username This patch adds some JavaScript to the patron entry form which adds a hint if the logged-in librarian tries to change their own username. It warns them that they will be logged out. To test, apply the patch and log into the staff interface. - Locate and edit your own patron record. - In the "OPAC/Staff interface login" section, change the value in the username field. When focus leaves that form field a hint should appear, "You will be logged out if you modify your username." - Change the username field back to your original username. The hint should disappear. - Confirm that submitting a username change works correctly: You should be logged out, and when you log in again your username should be updated. Signed-off-by: Sam Lau <samalau@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33820 Sam Lau <samalau@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151640|0 |1 is obsolete| | --- Comment #6 from Sam Lau <samalau@gmail.com> --- Created attachment 151686 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151686&action=edit Bug 33820: (follow-up) Add hint to member-password.tt This follow-up makes the same change to the "Change password" template. Signed-off-by: Sam Lau <samalau@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33820 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #7 from David Cook <dcook@prosentient.com.au> --- Technically this works but the hints are very easy to miss/ignore. Even when I was looking for it, I didn't even notice it the first time or two. I think adding color, bolding, or maybe even a prefix like "Warning!" might help this to stand out. But perhaps that could be a follow up. Not enough of an issue to block this I think. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33820 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33820 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151685|0 |1 is obsolete| | --- Comment #8 from David Cook <dcook@prosentient.com.au> --- Created attachment 151717 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151717&action=edit Bug 33820: Add hints to warn the librarian that they will be logged out if they change their username This patch adds some JavaScript to the patron entry form which adds a hint if the logged-in librarian tries to change their own username. It warns them that they will be logged out. To test, apply the patch and log into the staff interface. - Locate and edit your own patron record. - In the "OPAC/Staff interface login" section, change the value in the username field. When focus leaves that form field a hint should appear, "You will be logged out if you modify your username." - Change the username field back to your original username. The hint should disappear. - Confirm that submitting a username change works correctly: You should be logged out, and when you log in again your username should be updated. Signed-off-by: Sam Lau <samalau@gmail.com> Signed-off-by: David Cook <dcook@prosentient.com.au> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33820 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151686|0 |1 is obsolete| | --- Comment #9 from David Cook <dcook@prosentient.com.au> --- Created attachment 151718 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151718&action=edit Bug 33820: (follow-up) Add hint to member-password.tt This follow-up makes the same change to the "Change password" template. Signed-off-by: Sam Lau <samalau@gmail.com> Signed-off-by: David Cook <dcook@prosentient.com.au> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33820 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33820 --- Comment #10 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33820 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33820 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00 |23.11.00,23.05.02 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33820 --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Thanks for all the hard work! Pushed to 23.05.x for the next release -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33820 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pedro.amorim@ptfs-europe.co | |m Status|Pushed to stable |Needs documenting --- Comment #12 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Enhancement, not backporting to 22.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33820 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/801 Status|Needs documenting |RESOLVED Documentation| |Caroline Cyr La Rose contact| | Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33820 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_23_11_candidate | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org