[Bug 38224] New: Move populate_empty_callnumbers logic into Koha::Biblio for reusability
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38224 Bug ID: 38224 Summary: Move populate_empty_callnumbers logic into Koha::Biblio for reusability Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org Bug 34784 introduced an endpoint for populating empty item callnumbers. In order to be able to create a CLI script for the same purpose, it would be positive to migrate that code into Koha::Biblio. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38224 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Depends on| |34784 CC| |tomascohen@gmail.com Assignee|koha-bugs@lists.koha-commun |tomascohen@gmail.com |ity.org | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34784 [Bug 34784] Add ability to populate empty item call numbers for a record based on the itemcallnumber system preference -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38224 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|34784 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34784 [Bug 34784] Add ability to populate empty item call numbers for a record based on the itemcallnumber system preference -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38224 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |38226 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38226 [Bug 38226] Add RPC endpoint for batch filling empty callnumbers -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38224 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38224 --- Comment #1 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 173134 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173134&action=edit Bug 38224: Unit tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38224 --- Comment #2 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 173135 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173135&action=edit Bug 38224: Add Koha::Biblio::populate_item_callnumbers This patch introduces two methods to the `Koha::Biblio` class: * `get_first_callnumber`: returns the first found callnumber on the record, based on the `itemcallnumber` syspref. * `populate_item_callnumbers`: populates the bibliographic record's items based on the return value of `get_first_callnumber`. Can be passed a filter on the items. To test: 1. Apply this patch 2. Run: $ ktd --shell k$ prove t/db_dependent/Koha/Biblio.t => SUCCESS: Tests pass! 3. Sign off :-D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38224 --- Comment #3 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 173136 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173136&action=edit Bug 38224: (follow-up) Rewrite endpoint using new core methods Now we have core methods, we can use them to rewrite the controller. Behavior should remain unchanged, so to test: 1. Apply this patches 2. Run: $ ktd --shell k$ prove t/db_dependent/api/v1/rpc/biblios.t => SUCCESS: tests pass! 3. Sign off :-D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38224 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38224 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173134|0 |1 is obsolete| | Attachment #173135|0 |1 is obsolete| | Attachment #173136|0 |1 is obsolete| | --- Comment #4 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 174244 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174244&action=edit Bug 38224: Unit tests Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38224 --- Comment #5 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 174245 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174245&action=edit Bug 38224: Add Koha::Biblio::populate_item_callnumbers This patch introduces two methods to the `Koha::Biblio` class: * `get_first_callnumber`: returns the first found callnumber on the record, based on the `itemcallnumber` syspref. * `populate_item_callnumbers`: populates the bibliographic record's items based on the return value of `get_first_callnumber`. Can be passed a filter on the items. To test: 1. Apply this patch 2. Run: $ ktd --shell k$ prove t/db_dependent/Koha/Biblio.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38224 --- Comment #6 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 174246 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174246&action=edit Bug 38224: (follow-up) Rewrite endpoint using new core methods Now we have core methods, we can use them to rewrite the controller. Behavior should remain unchanged, so to test: 1. Apply this patches 2. Run: $ ktd --shell k$ prove t/db_dependent/api/v1/rpc/biblios.t => SUCCESS: tests pass! 3. Sign off :-D Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38224 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org