http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4305 --- Comment #15 from Colin Campbell <colin.campbell@ptfs-europe.com> 2010-11-11 14:05:29 UTC --- Created attachment 2737 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=2737 Further Patch Having instantiated an ISBN object it seems illogical not to use its (tested) method to remove punctuation and instead add our own code (simple but untested) to do it. Plus why overwrite the object with a temporary scalar just for that purpose? Lets try and smooth out the codeflow. Ran some benchmarking and while the speed improvement is not major (4-9 %) its worth having in a routine that will be called frequently. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.