https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33070 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |jonathan.druart+koha@gmail. |y.org |com Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | Depends on| |20256 Patch complexity|--- |Small patch CC| |tomascohen@gmail.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 [Bug 20256] Add ability to limit editing of items to home library or library group -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33070 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 147397 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147397&action=edit Bug 33070: Remove use of can_edit_items Test Plan: 1) Apply this patch 2) prove t/db_dependent/Koha/Acquisition/Order.t 3) git grep "can_edit_item(" should return no results Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33070 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33070 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33070 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED CC| |matt.blenkinsop@ptfs-europe | |.com Resolution|--- |FIXED --- Comment #4 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Not backporting to stable as this is dependent on bug 20256 which has not been backported -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33070 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34173 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34173 [Bug 34173] Imported items do not require home/holding branches, causing uneditable item records -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33070 --- Comment #6 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 196115 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196115&action=edit Bug 33070: (follow-up) Fix IsItemIssued.t mock_userenv mock_userenv was called before the test patron was created and used the default borrowernumber (51), which doesn't necessarily exist in the test database. This caused safe_to_delete to crash on the not_same_branch check when Koha::Patrons->find returned undef. Move mock_userenv after patron creation and pass the actual borrowernumber. -- You are receiving this mail because: You are watching all bug changes.